Re: [PATCH v2 00/10] Remove acpi.h implicit include of of.h

Rafael J. Wysocki
2023-04-06T18:40:30Z

On Wed, Apr 5, 2023 at 10:27 PM Rob Herring <robh@kernel.org> wrote:
>
> In the process of cleaning up DT includes, I found that some drivers
> using DT functions could build without any explicit DT include. I traced
> the include to be coming from acpi.h via irqdomain.h.
>
> I was pleasantly surprised that there were not 100s or even 10s of
> warnings when breaking the include chain. So here's the resulting
> series.
>
> I'd suggest Rafael take the whole series. Alternatively,the fixes can be
> applied in 6.4 and then the last patch either after rc1 or the
> following cycle.
>
> Compile tested on x86 and powerpc allmodconfig and arm64 allmodconfig
> minus CONFIG_ACPI.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Changes in v2:
> - More explicit include fixes reported by Stephen
> - Link to v1: https://lore.kernel.org/r/20230329-acpi-header-cleanup-v1-0-8dc5cd3c610e@kernel.org
>
> ---
> Rob Herring (10):
> iio: adc: ad7292: Add explicit include for of.h
> staging: iio: resolver: ad2s1210: Add explicit include for of.h
> net: rfkill-gpio: Add explicit include for of.h
> serial: 8250_tegra: Add explicit include for of.h
> ata: pata_macio: Add explicit include of irqdomain.h
> pata: ixp4xx: Add explicit include for of.h
> virtio-mmio: Add explicit include for of.h
> tpm: atmel: Add explicit include for of.h
> fpga: lattice-sysconfig-spi: Add explicit include for of.h
> ACPI: Replace irqdomain.h include with struct declarations
>
> drivers/ata/pata_ixp4xx_cf.c | 1 +
> drivers/ata/pata_macio.c | 1 +
> drivers/char/tpm/tpm_atmel.h | 2 +-
> drivers/fpga/lattice-sysconfig-spi.c | 1 +
> drivers/iio/adc/ad7292.c | 1 +
> drivers/staging/iio/resolver/ad2s1210.c | 1 +
> drivers/tty/serial/8250/8250_tegra.c | 1 +
> drivers/virtio/virtio_mmio.c | 1 +
> include/linux/acpi.h | 6 ++++--
> net/rfkill/rfkill-gpio.c | 1 +
> 10 files changed, 13 insertions(+), 3 deletions(-)
> ---
> base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
> change-id: 20230329-acpi-header-cleanup-665331828436

All applied as 6.4 material, thanks!