From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: kvalo@kernel.org, tony0620emma@gmail.com, stable@vger.kernel.org,
dan.carpenter@linaro.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: rtw88: correct qsel_to_ep[] type as int
Date: Mon, 8 May 2023 10:58:20 +0200 [thread overview]
Message-ID: <20230508085820.GU29365@pengutronix.de> (raw)
In-Reply-To: <20230508085539.46795-1-pkshih@realtek.com>
On Mon, May 08, 2023 at 04:55:39PM +0800, Ping-Ke Shih wrote:
> qsel_to_ep[] can be assigned negative value, so change type from 'u8' to
> 'int'. Otherwise, Smatch static checker warns:
> drivers/net/wireless/realtek/rtw88/usb.c:219 rtw_usb_parse() warn:
> assigning (-22) to unsigned variable 'rtwusb->qsel_to_ep[8]'
>
> Cc: stable@vger.kernel.org
> Fixes: a6f187f92bcc ("wifi: rtw88: usb: fix priority queue to endpoint mapping")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Link: https://lore.kernel.org/linux-wireless/c3f70197-829d-48ed-ae15-66a9de80fa90@kili.mountain/
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
> ---
> drivers/net/wireless/realtek/rtw88/usb.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/usb.h b/drivers/net/wireless/realtek/rtw88/usb.h
> index 30647f0dd61c6..ad1d7955c6a51 100644
> --- a/drivers/net/wireless/realtek/rtw88/usb.h
> +++ b/drivers/net/wireless/realtek/rtw88/usb.h
> @@ -78,7 +78,7 @@ struct rtw_usb {
> u8 pipe_interrupt;
> u8 pipe_in;
> u8 out_ep[RTW_USB_EP_MAX];
> - u8 qsel_to_ep[TX_DESC_QSEL_MAX];
> + int qsel_to_ep[TX_DESC_QSEL_MAX];
> u8 usb_txagg_num;
>
> struct workqueue_struct *txwq, *rxwq;
> --
> 2.25.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-05-08 8:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 8:55 [PATCH] wifi: rtw88: correct qsel_to_ep[] type as int Ping-Ke Shih
2023-05-08 8:58 ` Sascha Hauer [this message]
2023-05-08 9:32 ` David Laight
2023-05-08 18:59 ` Larry Finger
2023-05-15 18:16 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230508085820.GU29365@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=dan.carpenter@linaro.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=stable@vger.kernel.org \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox