From: Kevin Lund <kglund@google.com>
To: johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Cc: Kevin Lund <kglund@google.com>
Subject: [PATCH 2/2] wifi: mwifiex: Stop rejecting connection attempts while connected
Date: Fri, 2 Jun 2023 16:57:51 -0600 [thread overview]
Message-ID: <20230602225751.164525-2-kglund@google.com> (raw)
In-Reply-To: <20230602225751.164525-1-kglund@google.com>
Currently, the Marvell WiFi driver rejects any connection attmept while
we are currently connected. This is poor logic, since there are several
legitimate use-cases for initiating a connection attempt while
connected, including re-association and BSS Transitioning. This logic
means that it's impossible for userspace to request the driver to
connect to a different BSS on the same ESS without explicitly requesting
a disconnect first.
Remove the check from the driver so that we can complete BSS transitions
on the first attempt.
Testing on Chrome OS has shown that this change resolves some issues
with failed BSS transitions.
Signed-off-by: Kevin Lund <kglund@google.com>
---
drivers/net/wireless/marvell/mwifiex/cfg80211.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index bcd564dc3554a..84d650c9dceb0 100644
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -2414,12 +2414,6 @@ mwifiex_cfg80211_connect(struct wiphy *wiphy, struct net_device *dev,
return -EINVAL;
}
- if (priv->wdev.connected) {
- mwifiex_dbg(adapter, ERROR,
- "%s: already connected\n", dev->name);
- return -EALREADY;
- }
-
if (priv->scan_block)
priv->scan_block = false;
--
2.39.2
next prev parent reply other threads:[~2023-06-02 22:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 22:57 [PATCH 1/2] wifi: cfg80211: Reject (re-)association to the same BSSID Kevin Lund
2023-06-02 22:57 ` Kevin Lund [this message]
2023-08-04 1:21 ` [PATCH 2/2] wifi: mwifiex: Stop rejecting connection attempts while connected Brian Norris
2023-08-07 22:35 ` Kevin Lund
2023-08-15 0:21 ` Brian Norris
2023-06-03 3:32 ` [PATCH 1/2] wifi: cfg80211: Reject (re-)association to the same BSSID kernel test robot
2023-06-03 5:55 ` kernel test robot
2023-06-05 16:42 ` Johannes Berg
2023-08-04 17:29 ` Kevin Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230602225751.164525-2-kglund@google.com \
--to=kglund@google.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).