linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: ath11k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 05/15] wifi: ath11k: remove unsupported event handlers
Date: Fri,  9 Jun 2023 17:24:30 +0300	[thread overview]
Message-ID: <20230609142440.24643-6-kvalo@kernel.org> (raw)
In-Reply-To: <20230609142440.24643-1-kvalo@kernel.org>

From: Kalle Valo <quic_kvalo@quicinc.com>

Now that we have a default handler there's no need anymore to list every
unsupported event id anymore, so remove that to clean this up.

While at it remove the pointless todo comment and change the debug message to
follow the preferred style.

Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.23

Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
---
 drivers/net/wireless/ath/ath11k/wmi.c | 16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index 99beb7636835..6ce36879a503 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -8663,19 +8663,6 @@ static void ath11k_wmi_tlv_op_rx(struct ath11k_base *ab, struct sk_buff *skb)
 	case WMI_TWT_ADD_DIALOG_EVENTID:
 		ath11k_wmi_twt_add_dialog_event(ab, skb);
 		break;
-	/* add Unsupported events here */
-	case WMI_TBTTOFFSET_EXT_UPDATE_EVENTID:
-	case WMI_PEER_OPER_MODE_CHANGE_EVENTID:
-	case WMI_TWT_ENABLE_EVENTID:
-	case WMI_TWT_DISABLE_EVENTID:
-	case WMI_TWT_DEL_DIALOG_EVENTID:
-	case WMI_TWT_PAUSE_DIALOG_EVENTID:
-	case WMI_TWT_RESUME_DIALOG_EVENTID:
-	case WMI_PDEV_DMA_RING_CFG_RSP_EVENTID:
-	case WMI_PEER_CREATE_CONF_EVENTID:
-		ath11k_dbg(ab, ATH11K_DBG_WMI,
-			   "ignoring unsupported event 0x%x\n", id);
-		break;
 	case WMI_PDEV_DFS_RADAR_DETECTION_EVENTID:
 		ath11k_wmi_pdev_dfs_radar_detected_event(ab, skb);
 		break;
@@ -8697,9 +8684,8 @@ static void ath11k_wmi_tlv_op_rx(struct ath11k_base *ab, struct sk_buff *skb)
 	case WMI_GTK_OFFLOAD_STATUS_EVENTID:
 		ath11k_wmi_gtk_offload_status_event(ab, skb);
 		break;
-	/* TODO: Add remaining events */
 	default:
-		ath11k_dbg(ab, ATH11K_DBG_WMI, "Unknown eventid: 0x%x\n", id);
+		ath11k_dbg(ab, ATH11K_DBG_WMI, "unsupported event id 0x%x\n", id);
 		break;
 	}
 
-- 
2.30.2


  parent reply	other threads:[~2023-06-09 14:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09 14:24 [PATCH 00/15] wifi: ath11k: debug message improvements Kalle Valo
2023-06-09 14:24 ` [PATCH 01/15] wifi: ath11k: debug: remove unused ATH11K_DBG_ANY Kalle Valo
2023-06-13  9:11   ` Kalle Valo
2023-06-09 14:24 ` [PATCH 02/15] wifi: ath11k: print debug level in debug messages Kalle Valo
2023-06-09 14:24 ` [PATCH 03/15] wifi: ath11k: remove manual mask names from " Kalle Valo
2023-06-09 14:24 ` [PATCH 04/15] wifi: ath11k: add WMI event " Kalle Valo
2023-06-09 14:24 ` Kalle Valo [this message]
2023-06-09 14:24 ` [PATCH 06/15] wifi: ath11k: wmi: cleanup error handling in ath11k_wmi_send_init_country_cmd() Kalle Valo
2023-06-09 14:24 ` [PATCH 07/15] wifi: ath11k: wmi: use common error handling style Kalle Valo
2023-06-09 14:24 ` [PATCH 08/15] wifi: ath11k: wmi: add unified command debug messages Kalle Valo
2023-06-09 14:24 ` [PATCH 09/15] wifi: ath11k: pci: cleanup debug logging Kalle Valo
2023-06-09 14:24 ` [PATCH 10/15] wifi: ath11k: dp: cleanup debug message Kalle Valo
2023-06-09 14:24 ` [PATCH 11/15] wifi: ath11k: debug: use all upper case in ATH11k_DBG_HAL Kalle Valo
2023-06-09 14:24 ` [PATCH 12/15] wifi: ath11k: hal: cleanup debug message Kalle Valo
2023-06-09 14:24 ` [PATCH 13/15] wifi: ath11k: don't use %pK Kalle Valo
2023-06-09 14:24 ` [PATCH 14/15] wifi: ath11k: htc: cleanup debug messages Kalle Valo
2023-06-09 14:24 ` [PATCH 15/15] wifi: ath11k: debug: add ATH11K_DBG_CE Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230609142440.24643-6-kvalo@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).