From: Ping-Ke Shih <pkshih@realtek.com>
To: <tony0620emma@gmail.com>, <kvalo@kernel.org>
Cc: <phhuang@realtek.com>, <linux-wireless@vger.kernel.org>
Subject: [PATCH v2 0/6] wifi: rtw88: correct AP and PS mode behaviors
Date: Fri, 16 Jun 2023 20:55:34 +0800 [thread overview]
Message-ID: <20230616125540.36877-1-pkshih@realtek.com> (raw)
In AP mode, HI queue is used to transmit broadcast/multicast right after
issuing beacon, and we need set MORE_DATA in TX description to make
hardware transmits all packets in one go. Also, have special deal with
this queue when doing scan and flush.
After stopping AP from SCC (AP + STA), only one STA is working, so PS mode
is expected to enable. However, firmware checks the MAC port used by AP
mode before, and then can't enter PS mode. We add the last patch to set
"default port" to the port used by STA. Then, firmware will check correct
port to enter PS mode in expectation.
Note: The patch 5/6 ("wifi: rtw88: refine register based H2C command")
adds new static function that is used by patch 6/6, so compiler will
warn unused function if we build this path.
v2:
- fix patch 1/6 problems
* correct to use RTW_TX_DESC_W7_DMA_TXAGG_NUM to set agg_num
* use correct le32p_replace_bits() to set value instead
Po-Hao Huang (6):
wifi: rtw88: use struct instead of macros to set TX desc
wifi: rtw88: Fix AP mode incorrect DTIM behavior
wifi: rtw88: Skip high queue in hci_flush
wifi: rtw88: Stop high queue during scan
wifi: rtw88: refine register based H2C command
wifi: rtw88: fix not entering PS mode after AP stops
drivers/net/wireless/realtek/rtw88/fw.c | 68 ++++++++++
drivers/net/wireless/realtek/rtw88/fw.h | 13 ++
drivers/net/wireless/realtek/rtw88/mac80211.c | 3 +
drivers/net/wireless/realtek/rtw88/main.c | 15 ++-
drivers/net/wireless/realtek/rtw88/main.h | 1 +
drivers/net/wireless/realtek/rtw88/pci.c | 5 +-
drivers/net/wireless/realtek/rtw88/reg.h | 2 +
drivers/net/wireless/realtek/rtw88/rtw8723d.c | 6 +-
drivers/net/wireless/realtek/rtw88/tx.c | 84 +++++++-----
drivers/net/wireless/realtek/rtw88/tx.h | 123 ++++++++----------
drivers/net/wireless/realtek/rtw88/usb.c | 15 ++-
11 files changed, 218 insertions(+), 117 deletions(-)
--
2.25.1
next reply other threads:[~2023-06-16 12:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 12:55 Ping-Ke Shih [this message]
2023-06-16 12:55 ` [PATCH v2 1/6] wifi: rtw88: use struct instead of macros to set TX desc Ping-Ke Shih
2023-06-21 9:42 ` Kalle Valo
2023-06-16 12:55 ` [PATCH v2 2/6] wifi: rtw88: Fix AP mode incorrect DTIM behavior Ping-Ke Shih
2023-06-16 12:55 ` [PATCH v2 3/6] wifi: rtw88: Skip high queue in hci_flush Ping-Ke Shih
2023-06-16 12:55 ` [PATCH v2 4/6] wifi: rtw88: Stop high queue during scan Ping-Ke Shih
2023-06-16 12:55 ` [PATCH v2 5/6] wifi: rtw88: refine register based H2C command Ping-Ke Shih
2023-06-16 12:55 ` [PATCH v2 6/6] wifi: rtw88: fix not entering PS mode after AP stops Ping-Ke Shih
2023-06-21 9:21 ` [PATCH v2 0/6] wifi: rtw88: correct AP and PS mode behaviors Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230616125540.36877-1-pkshih@realtek.com \
--to=pkshih@realtek.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=phhuang@realtek.com \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).