From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAB19C0015E for ; Wed, 12 Jul 2023 23:55:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232992AbjGLXz3 (ORCPT ); Wed, 12 Jul 2023 19:55:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232636AbjGLXz2 (ORCPT ); Wed, 12 Jul 2023 19:55:28 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A69501FC9 for ; Wed, 12 Jul 2023 16:55:26 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-5577900c06bso172747a12.2 for ; Wed, 12 Jul 2023 16:55:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689206126; x=1691798126; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/vU/3bfdHl64WUkd75ReRDYfirTILS0gvYwUTQH7DSM=; b=J7alN4E4ewEYIushjF5RhD5xtHURzl5VVAKqYeqMlBLF8w84WUPewCv7Owf2hO1Sx8 s+NCKO3579s52rnAVRhkl9Bu3oO8BbS3ffYhxKwUqGrTmYDf88Wx6URNb5AOSDmk5OMZ e9iOjL4hPL/awuWYemSCQciujiFphf+0gfcEU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689206126; x=1691798126; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/vU/3bfdHl64WUkd75ReRDYfirTILS0gvYwUTQH7DSM=; b=lUXPiwZizO5TTY+lNbXPkHno6tTMxx3EzqXTy2JfVb6VK8CX2sxe7peoCQk0CCx8hG XLObgg7K/k351sOZV6joxl+hGkmoPwMMM0DKVeEU8ykacMYiuGLN41XZKWGTWiRMdqIM Qqb3VNDgdLLNvFIeyjwRKg6MH8DU7sx7lINVGiorvczIt/TkxppuifFQori8/FTZzgiP CxCizlDDVUo6gncWglMrf5yNdycI4twsbxcJvF4eHZGBjXNGam9Ei2ze/dBrv/1sNP0r HsQBG+VexZfWaHxeFZ61pIDB0ko2koymGxKb0eLyA7gVCeQClqhg0xbHscyAjNH2a5HE fU8g== X-Gm-Message-State: ABy/qLaLCcNPJHa6ym7DjzniOQw6UHg83/4nf2xwthHGF8X205uW+cpI +l8qWfrY9KQJHxEwAAQC0CepbQ== X-Google-Smtp-Source: APBJJlHQZRshLJRZTXRiub4lrbl9NPrV3egVjkpObEu7LZ5J/dFpr8E4upDYkJFMKJLvoGPiSxabFw== X-Received: by 2002:a05:6a20:3257:b0:120:1baf:e56e with SMTP id hm23-20020a056a20325700b001201bafe56emr21055274pzc.19.1689206126202; Wed, 12 Jul 2023 16:55:26 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id j2-20020aa783c2000000b0064f76992905sm4120145pfn.202.2023.07.12.16.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 16:55:25 -0700 (PDT) Date: Wed, 12 Jul 2023 16:55:25 -0700 From: Kees Cook To: Azeem Shaikh Cc: Amitkumar Karwar , Ganapathi Bhat , Sharvari Harisangam , Xinming Hu , linux-hardening@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Kalle Valo Subject: Re: [PATCH] wifi: mwifiex: Replace strlcpy with strscpy Message-ID: <202307121655.C365BB8@keescook> References: <20230710030625.812707-1-azeemshaikh38@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230710030625.812707-1-azeemshaikh38@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, Jul 10, 2023 at 03:06:25AM +0000, Azeem Shaikh wrote: > strlcpy() reads the entire source buffer first. > This read may exceed the destination size limit. > This is both inefficient and can lead to linear read > overflows if a source string is not NUL-terminated [1]. > In an effort to remove strlcpy() completely [2], replace > strlcpy() here with strscpy(). > > Direct replacement is safe here since return value of -errno > is used to check for truncation instead of sizeof(dest). > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy > [2] https://github.com/KSPP/linux/issues/89 > > Signed-off-by: Azeem Shaikh Reviewed-by: Kees Cook -- Kees Cook