From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kalle Valo <kvalo@kernel.org>, Yanik Fuchs <Yanik.fuchs@mbv.ch>
Subject: Re: [PATCH] wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM
Date: Fri, 8 Sep 2023 13:36:55 +0200 [thread overview]
Message-ID: <20230908113655.GF637806@pengutronix.de> (raw)
In-Reply-To: <bed0e0cacc44476582fc58180d77519c@realtek.com>
On Fri, Sep 08, 2023 at 12:23:13AM +0000, Ping-Ke Shih wrote:
>
>
> > -----Original Message-----
> > From: Sascha Hauer <s.hauer@pengutronix.de>
> > Sent: Thursday, September 7, 2023 3:16 PM
> > To: linux-wireless@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org; Kalle Valo <kvalo@kernel.org>; Ping-Ke Shih <pkshih@realtek.com>; Yanik
> > Fuchs <Yanik.fuchs@mbv.ch>
> > Subject: [PATCH] wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM
> >
> > The MAC address is stored at offset 0x107 in the EEPROM, like correctly
> > stated in the comment. Add a two bytes reserved field right before the
> > MAC address to shift it from offset 0x105 to 0x107.
> >
> > With this the MAC address returned from my RTL8723du wifi stick can be
> > correctly decoded as "Shenzhen Four Seas Global Link Network Technology
> > Co., Ltd."
>
> With this correctness, my stick can be recognized as:
> " Bus 003 Device 010: ID 0bda:d723 Realtek Semiconductor Corp. 802.11n WLAN Adapter"
It should be recognized like this also without this patch, but with this
patch the MAC address should be read correctly.
>
> Should it add a Fixes tag?
> Fixes: 87caeef032fc ("wifi: rtw88: Add rtw8723du chipset support")
Yes, I forgot this. Kalle, can you add it once again while applying?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-09-08 11:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 7:16 [PATCH] wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM Sascha Hauer
2023-09-08 0:23 ` Ping-Ke Shih
2023-09-08 11:36 ` Sascha Hauer [this message]
2023-09-08 13:26 ` Kalle Valo
2023-09-18 13:19 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2023-09-07 8:09 [PATCH] " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230908113655.GF637806@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=Yanik.fuchs@mbv.ch \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).