From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFD51EEAA59 for ; Thu, 14 Sep 2023 16:52:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229592AbjINQwp (ORCPT ); Thu, 14 Sep 2023 12:52:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230502AbjINQwo (ORCPT ); Thu, 14 Sep 2023 12:52:44 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 352341FDE for ; Thu, 14 Sep 2023 09:52:40 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1c0db66af1bso8971225ad.2 for ; Thu, 14 Sep 2023 09:52:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1694710359; x=1695315159; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=r0PIFkgAKbrMcVoY24lLipEKJInCl7seVpo3l//wznQ=; b=BJ461dA1fUKAUWLqaFfkW0wq1mkuVcAUOnYtQPQKpOIwfQu8JJaxnj1TQkL0q5OzKm iME5BxFhF3vXxnarUfr+Bnvih7Y66Sw1N0m4rUPLtKaO+C+jYtSTP9+8cwoHgEsexlSq 4xnkP3phPTDF+rLbES56cGhdm5Iuq7ubd4Kqk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694710359; x=1695315159; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=r0PIFkgAKbrMcVoY24lLipEKJInCl7seVpo3l//wznQ=; b=r8v7ajYjyWzojWryJCkVTKegPGXmmEag0vvgS2ZqXzOvd+yqFr4KVWyCBp5hFlsXo2 LPL2iLxNqdwx+EAmLUDfZAJd9DEL94+xt7LFgKUC9ifxB5sxaHsx2xjoatMZuPjOhmnB 5KK+aMdRX8vWxpZbImGTh2Ve9iRoCKatcs7ORRTTjyCEDIkeceHr4uZsAQ5yPXCCdlgT o+P48CLjGSR/Dd4iN+2xke6WX/JN6QdIK1HLGXQfHxgSS/Pl4o/bi0mJxk3evoe9kKTw SuHMbZkCPREsCzzs/LGfBexwEDLj3aQ49oM518nPAjtWUe00YV0t51JtXQqWzc/VdUbH PXEQ== X-Gm-Message-State: AOJu0YxUM1bfJEbKEZQgk7f0TcWduOeNa6lSlZQGMZ3EIn3rORGNDed5 eERe3lpNoeDu3m9o75QMqEBtzQ== X-Google-Smtp-Source: AGHT+IH334ra+z6TaPT2K2le+CKl26jjaRaWR5gBvgujVzunOvDx1yIYuftdJvAeTfi6FAe4UebEgQ== X-Received: by 2002:a17:902:b281:b0:1b8:7fd7:e022 with SMTP id u1-20020a170902b28100b001b87fd7e022mr6178845plr.28.1694710359638; Thu, 14 Sep 2023 09:52:39 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id f24-20020a170902ab9800b001bb3beb2bc6sm1820038plr.65.2023.09.14.09.52.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 09:52:38 -0700 (PDT) Date: Thu, 14 Sep 2023 09:52:38 -0700 From: Kees Cook To: Juerg Haefliger Cc: SHA-cyfmac-dev-list@infineon.com, aspriel@gmail.com, brcm80211-dev-list.pdl@broadcom.com, franky.lin@broadcom.com, gustavoars@kernel.org, hante.meuleman@broadcom.com, hdegoede@redhat.com, kvalo@kernel.org, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, marcan@marcan.st, ryohei.kondo@cypress.com, stable@vger.kernel.org Subject: Re: [PATCH v2] wifi: brcmfmac: Replace 1-element arrays with flexible arrays Message-ID: <202309140952.98489A964@keescook> References: <20230913065421.12615-1-juerg.haefliger@canonical.com> <20230914070227.12028-1-juerg.haefliger@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230914070227.12028-1-juerg.haefliger@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, Sep 14, 2023 at 09:02:27AM +0200, Juerg Haefliger wrote: > Since commit 2d47c6956ab3 ("ubsan: Tighten UBSAN_BOUNDS on GCC"), > UBSAN_BOUNDS no longer pretends 1-element arrays are unbounded. Walking > 'element' and 'channel_list' will trigger warnings, so make them proper > flexible arrays. > > False positive warnings were: > > UBSAN: array-index-out-of-bounds in drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:6984:20 > index 1 is out of range for type '__le32 [1]' > > UBSAN: array-index-out-of-bounds in drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1126:27 > index 1 is out of range for type '__le16 [1]' > > for these lines of code: > > 6884 ch.chspec = (u16)le32_to_cpu(list->element[i]); > > 1126 params_le->channel_list[i] = cpu_to_le16(chanspec); > > Cc: stable@vger.kernel.org # 6.5+ > Signed-off-by: Juerg Haefliger Reviewed-by: Kees Cook -- Kees Cook