From: Bjorn Helgaas <helgaas@kernel.org>
To: Ingo Rohloff <lundril@gmx.de>
Cc: Felix Fietkau <nbd@nbd.name>, Ryder Lee <ryder.lee@mediatek.com>,
linux-wireless@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] wifi: mt76: mt7921e: Support MT7992 IP in Xiaomi Redmibook 15 Pro (2023)
Date: Fri, 29 Sep 2023 17:57:52 -0500 [thread overview]
Message-ID: <20230929225752.GA560382@bhelgaas> (raw)
In-Reply-To: <20230826200241.5077-1-lundril@gmx.de>
On Sat, Aug 26, 2023 at 10:02:41PM +0200, Ingo Rohloff wrote:
> In the Xiaomi Redmibook 15 Pro (2023) laptop I have got, a wifi chip is
> used, which according to its PCI Vendor ID is from "ITTIM Technology".
>
> This chip works flawlessly with the mt7921e module. The driver doesn't
> bind to this PCI device, because the Vendor ID from "ITTIM Technology" is
> not recognized.
>
> This patch adds the PCI Vendor ID from "ITTIM Technology" to the list of
> PCI Vendor IDs and lets the mt7921e driver bind to the mentioned wifi
> chip.
>
> Signed-off-by: Ingo Rohloff <lundril@gmx.de>
Acked-by: Bjorn Helgaas <bhelgaas@google.com> # pci_ids.h
> ---
> Changes in v2:
> As requested, move the definition of the PCI Vendor ID for
> ITTIM Technology to the (hopefully) right place in pci_ids.h
> ---
> drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 2 ++
> include/linux/pci_ids.h | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> index 95610a117d2f..ed5a220763ce 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> @@ -17,6 +17,8 @@ static const struct pci_device_id mt7921_pci_device_table[] = {
> .driver_data = (kernel_ulong_t)MT7921_FIRMWARE_WM },
> { PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x7922),
> .driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
> + { PCI_DEVICE(PCI_VENDOR_ID_ITTIM, 0x7922),
> + .driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
> { PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x0608),
> .driver_data = (kernel_ulong_t)MT7921_FIRMWARE_WM },
> { PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x0616),
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 2dc75df1437f..6ae1803bcd2f 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -180,6 +180,8 @@
> #define PCI_DEVICE_ID_BERKOM_A4T 0xffa4
> #define PCI_DEVICE_ID_BERKOM_SCITEL_QUADRO 0xffa8
>
> +#define PCI_VENDOR_ID_ITTIM 0x0b48
> +
> #define PCI_VENDOR_ID_COMPAQ 0x0e11
> #define PCI_DEVICE_ID_COMPAQ_TOKENRING 0x0508
> #define PCI_DEVICE_ID_COMPAQ_TACHYON 0xa0fc
> --
> 2.30.2
>
prev parent reply other threads:[~2023-09-29 22:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-26 20:02 [PATCH v2] wifi: mt76: mt7921e: Support MT7992 IP in Xiaomi Redmibook 15 Pro (2023) Ingo Rohloff
2023-09-29 22:57 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230929225752.GA560382@bhelgaas \
--to=helgaas@kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lundril@gmx.de \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox