linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael Büsch" <m@bues.ch>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH] ssb: relax SSB_EMBEDDED dependencies
Date: Thu, 12 Oct 2023 19:39:38 +0200	[thread overview]
Message-ID: <20231012193938.16fb7db6@barney> (raw)
In-Reply-To: <13eeb01a-2f4f-4c8e-b097-6e80d822862b@infradead.org>

[-- Attachment #1: Type: text/plain, Size: 612 bytes --]

On Wed, 11 Oct 2023 20:44:49 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:

> > I thought about something like this:
> > 
> > depends on (SSB_DRIVER_MIPS && PCI=n) || (SSB_DRIVER_MIPS &&
> > SSB_PCICORE_HOSTMODE)
> > 
> > Would that solve the warning?  
> 
> Yes, that works as well, although I prefer to express it like this:
> 
>  config SSB_EMBEDDED
>  	bool
> -	depends on SSB_DRIVER_MIPS && SSB_PCICORE_HOSTMODE
> +	depends on SSB_DRIVER_MIPS
> +	depends on PCI=n || SSB_PCICORE_HOSTMODE
>  	default y

Acked-by: Michael Büsch <m@bues.ch>


-- 
Michael Büsch
https://bues.ch/

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2023-10-12 17:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-07 18:24 [RFC PATCH] ssb: relax SSB_EMBEDDED dependencies Randy Dunlap
2023-10-08  7:35 ` Michael Büsch
2023-10-08 14:08   ` Randy Dunlap
2023-10-09  6:12     ` Randy Dunlap
2023-10-10 18:43       ` Michael Büsch
2023-10-12  3:44         ` Randy Dunlap
2023-10-12 17:39           ` Michael Büsch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231012193938.16fb7db6@barney \
    --to=m@bues.ch \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).