From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Shiji Yang <yangshiji66@outlook.com>
Cc: linux-wireless@vger.kernel.org,
Helmut Schaa <helmut.schaa@googlemail.com>,
Kalle Valo <kvalo@kernel.org>, Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Ryder Lee <ryder.lee@mediatek.com>
Subject: Re: [PATCH 0/3] wifi: rt2x00: various improvements for MT7620 initialization
Date: Sat, 14 Oct 2023 19:54:28 +0200 [thread overview]
Message-ID: <20231014175428.GA477888@wp.pl> (raw)
In-Reply-To: <TYAP286MB03159DF41F754CB4F3AA4566BCD2A@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM>
On Sat, Oct 14, 2023 at 07:21:27AM +0800, Shiji Yang wrote:
> This series patches aim to improve the initialization of MT7620. All
> changes and register values were ported from the Mediatek vendor
> driver, and I have been testing them on OpenWrt for several weeks.
Hi Shiji!
Thank you for improving MT7620 support in rt2x00!
Your patches generally look ok to me.
I would suggest however consider to move support of MT7620 to
mt76 driver. It's much nicer and better written driver with
better mac80211/linux integration and support of various
features that rt2x00 lacks. Adding mt7620 sub-driver there
should not be that hard, and would be much "cooler" project
for you in my opinion.
This of course depend of how much time do you have to work
on this. Tweaking/improving rt2x00 can be easier and faster
way to achieve your goals and I don't want discourage
you from doing this, if that's something you prefer.
Keep good work!
Regards
Stanislaw
next prev parent reply other threads:[~2023-10-14 17:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 23:21 [PATCH 0/3] wifi: rt2x00: various improvements for MT7620 initialization Shiji Yang
2023-10-14 17:54 ` Stanislaw Gruszka [this message]
2023-10-16 12:45 ` Shiji Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231014175428.GA477888@wp.pl \
--to=stf_xl@wp.pl \
--cc=helmut.schaa@googlemail.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
--cc=yangshiji66@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).