From: "Michael Büsch" <m@bues.ch>
To: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
Cc: Larry.Finger@lwfinger.net, kvalo@kernel.org,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] b43legacy: Removed unneeded variable in debugfs
Date: Fri, 20 Oct 2023 11:35:14 +0200 [thread overview]
Message-ID: <20231020113514.122bfb6e@barney> (raw)
In-Reply-To: <20231020092735.2565-1-bragathemanick0908@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 474 bytes --]
On Fri, 20 Oct 2023 14:57:35 +0530
Bragatheswaran Manickavel <bragathemanick0908@gmail.com> wrote:
> Removed unneeded variable. Issue identified using Coccinelle semantic.
> No functional impact
This patch is completely wrong. It would not even compile.
Please compile your patches before submitting them!
And it is the second time we see this nonsense.
The code is correct as-is. There is no unused variable.
NACK.
--
Michael Büsch
https://bues.ch/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-10-20 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 9:27 [PATCH] b43legacy: Removed unneeded variable in debugfs Bragatheswaran Manickavel
2023-10-20 9:35 ` Michael Büsch [this message]
2023-10-20 12:00 ` Julian Calaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020113514.122bfb6e@barney \
--to=m@bues.ch \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=bragathemanick0908@gmail.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).