From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68BCBC25B47 for ; Fri, 27 Oct 2023 07:07:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345289AbjJ0HHo (ORCPT ); Fri, 27 Oct 2023 03:07:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229590AbjJ0HHn (ORCPT ); Fri, 27 Oct 2023 03:07:43 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66D7B116; Fri, 27 Oct 2023 00:07:41 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51BD8C433C7; Fri, 27 Oct 2023 07:07:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698390461; bh=wJS+QNrJXp1MsR3/ZUU86Cl8sI9OcARWlPbkBdr/bKk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1cKRZ/dqG1UPyK7jGIKlc7d4qyLaGMVNalQpqY5YHNuJmLJssUWMCh6+DxStZzOCx ycijrCqRKHCwG3bBlKXxj6ROCUqVDwp9sptIHEiJoXAY5OMP9E1PBCQQoH3nnqTxU/ IxMV/TmCRUpp4AVho4hqjROmuArhRVLTI/EHMcDk= Date: Fri, 27 Oct 2023 09:07:36 +0200 From: Greg KH To: Kalle Valo Cc: Witold Baryluk , arnd@kernel.org, Larry.Finger@lwfinger.net, alexandre.belloni@bootlin.com, arnd@arndb.de, claudiu.beznea@tuxon.dev, davem@davemloft.net, geert@linux-m68k.org, geoff@infradead.org, gregory.greenman@intel.com, ilw@linux.intel.com, johannes@sipsolutions.net, kuba@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-wireless@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, nicolas.ferre@microchip.com, pavel@ucw.cz, quic_jjohnson@quicinc.com, stas.yakovlev@gmail.com, stf_xl@wp.pl Subject: Re: [PATCH 10/10] [RFC] wifi: remove ipw2100/ipw2200 drivers Message-ID: <2023102709-purse-repressed-d8b9@gregkh> References: <87o7gld8l4.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o7gld8l4.fsf@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, Oct 26, 2023 at 12:41:27PM +0300, Kalle Valo wrote: > For example, I see lots of dead code under '#ifdef NOT_YET' and '#if 0', > removing those is a good a start. Also converting the ugly debug_level > procfs file to something more modern would be nice, maybe using just > dev_dbg() throught the driver is a good option? Or maybe use a module > parameter instead? Ick, no new module parameters, this isn't the 1990's, please just use the netdev debug lines instead :) thanks, greg k-h