From: Jakub Kicinski <kuba@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Marc MERLIN <marc@merlins.org>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
ilw@linux.intel.com, intel-wired-lan@lists.osuosl.org,
Tony Nguyen <anthony.l.nguyen@intel.com>
Subject: Re: Thinkpad P17 keep hanging in ipv6_addrconf addrconf_verify_work / netlink in 6.4 and 6.6
Date: Mon, 4 Dec 2023 13:16:15 -0800 [thread overview]
Message-ID: <20231204131615.26b57722@kernel.org> (raw)
In-Reply-To: <69717129398d05b18df1c1300bfb41da268c52a0.camel@sipsolutions.net>
CC: Intel Wired
https://lore.kernel.org/all/20231204004003.GB29484@merlins.org/
On Mon, 04 Dec 2023 11:57:44 +0100 Johannes Berg wrote:
> On Sun, 2023-12-03 at 23:35 -0800, Marc MERLIN wrote:
> > So, I thought that maybe my custom built kernel had options that somehow
> > made P17 unhappy, and went to a stock debian kernel.
> > It's not really looking better with that kernel unfortunately :-/
> >
> > Still seems unhappy with networking, first wireless and then ethtool.
> > Adding wireless lists to Cc just in case
>
> Well clearly something is not unlocking the RTNL, but digging through
> the below I only found places that want to acquire the RTNL and wait
> forever on it (including wireless), but none that actually got stuck
> while having it acquired already.
>
>
> Actually ... no that's wrong.
>
> I can:
>
> > > [ 363.945427] INFO: task powertop:6279 blocked for more than 120 seconds.
> > > [ 363.945446] Tainted: G U 6.6.3-amd64-preempt-sysrq-20220227 #4
> > > [ 363.945452] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
> > > [ 363.945456] task:powertop state:D stack:0 pid:6279 ppid:6267 flags:0x00004002
> > > [ 363.945468] Call Trace:
> > > [ 363.945473] <TASK>
> > > [ 363.945481] __schedule+0xba0/0xc05
> > > [ 363.945497] schedule+0x95/0xce
> > > [ 363.945504] schedule_preempt_disabled+0x15/0x22
> > > [ 363.945511] __mutex_lock.constprop.0+0x18b/0x291
> > > [ 363.945520] ? __pfx_pci_pm_runtime_resume+0x40/0x40
> > > [ 363.945531] igc_resume+0x18b/0x1ca [igc 1a96e277f8878a2a3c9599226acd0eeb7de577b7]
>
> this is trying to acquire the RTNL, by looking at the code
>
> > > [ 363.945566] __rpm_callback+0x7a/0xe7
> > > [ 363.945578] rpm_callback+0x35/0x64
> > > [ 363.945587] ? __pfx_pci_pm_runtime_resume+0x40/0x40
> > > [ 363.945592] rpm_resume+0x342/0x44a
> > > [ 363.945600] ? __kmem_cache_alloc_node+0x123/0x154
> > > [ 363.945614] __pm_runtime_resume+0x5a/0x7a
> > > [ 363.945624] dev_ethtool+0x15a/0x24e7
>
> but this already holds it
>
> So looks like bug in the 'igc' driver wrt. runtime PM locking.
>
> johannes
>
>
next prev parent reply other threads:[~2023-12-04 21:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231202171326.GB24486@merlins.org>
[not found] ` <20231204004003.GB29484@merlins.org>
2023-12-04 7:35 ` Thinkpad P17 keep hanging in ipv6_addrconf addrconf_verify_work / netlink in 6.4 and 6.6 Marc MERLIN
2023-12-04 10:57 ` Johannes Berg
2023-12-04 16:52 ` Marc MERLIN
2023-12-04 18:34 ` Johannes Berg
2023-12-04 21:16 ` Jakub Kicinski [this message]
2023-12-04 21:17 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204131615.26b57722@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=ilw@linux.intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=marc@merlins.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox