From: Ma Jun <Jun.Ma2@amd.com>
To: <amd-gfx@lists.freedesktop.org>, <lenb@kernel.org>,
<hdegoede@redhat.com>, <johannes@sipsolutions.net>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <alexander.deucher@amd.com>,
<Lijo.Lazar@amd.com>, <mario.limonciello@amd.com>,
<netdev@vger.kernel.org>, <linux-wireless@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>
Cc: <majun@amd.com>, Ma Jun <Jun.Ma2@amd.com>
Subject: [PATCH v15 1/9] Documentation/driver-api: Add document about WBRF mechanism
Date: Wed, 6 Dec 2023 15:29:39 +0800 [thread overview]
Message-ID: <20231206072947.1331729-2-Jun.Ma2@amd.com> (raw)
In-Reply-To: <20231206072947.1331729-1-Jun.Ma2@amd.com>
Add documentation about AMD's Wifi band RFI mitigation (WBRF) mechanism
explaining the theory and how it is used.
Signed-off-by: Ma Jun <Jun.Ma2@amd.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
---
Documentation/driver-api/wbrf.rst | 78 +++++++++++++++++++++++++++++++
1 file changed, 78 insertions(+)
create mode 100644 Documentation/driver-api/wbrf.rst
diff --git a/Documentation/driver-api/wbrf.rst b/Documentation/driver-api/wbrf.rst
new file mode 100644
index 000000000000..12793bb1abce
--- /dev/null
+++ b/Documentation/driver-api/wbrf.rst
@@ -0,0 +1,78 @@
+.. SPDX-License-Identifier: GPL-2.0-or-later
+
+=================================
+WBRF - Wifi Band RFI Mitigations
+=================================
+
+Due to electrical and mechanical constraints in certain platform designs
+there may be likely interference of relatively high-powered harmonics of
+the GPU memory clocks with local radio module frequency bands used by
+certain Wifi bands.
+
+To mitigate possible RFI interference producers can advertise the
+frequencies in use and consumers can use this information to avoid using
+these frequencies for sensitive features.
+
+When a platform is known to have this issue with any contained devices,
+the platform designer will advertise the availability of this feature via
+ACPI devices with a device specific method (_DSM).
+* Producers with this _DSM will be able to advertise the frequencies in use.
+* Consumers with this _DSM will be able to register for notifications of
+frequencies in use.
+
+Some general terms
+==================
+
+Producer: such component who can produce high-powered radio frequency
+Consumer: such component who can adjust its in-use frequency in
+ response to the radio frequencies of other components to
+ mitigate the possible RFI.
+
+To make the mechanism function, those producers should notify active use
+of their particular frequencies so that other consumers can make relative
+internal adjustments as necessary to avoid this resonance.
+
+ACPI interface
+==============
+
+Although initially used by for wifi + dGPU use cases, the ACPI interface
+can be scaled to any type of device that a platform designer discovers
+can cause interference.
+
+The GUID used for the _DSM is 7B7656CF-DC3D-4C1C-83E9-66E721DE3070.
+
+3 functions are available in this _DSM:
+
+* 0: discover # of functions available
+* 1: record RF bands in use
+* 2: retrieve RF bands in use
+
+Driver programming interface
+============================
+
+.. kernel-doc:: drivers/platform/x86/amd/wbrf.c
+
+Sample Usage
+=============
+
+The expected flow for the producers:
+1. During probe, call `acpi_amd_wbrf_supported_producer` to check if WBRF
+ can be enabled for the device.
+2. On using some frequency band, call `acpi_amd_wbrf_add_remove` with 'add'
+ param to get other consumers properly notified.
+3. Or on stopping using some frequency band, call
+ `acpi_amd_wbrf_add_remove` with 'remove' param to get other consumers notified.
+
+The expected flow for the consumers:
+1. During probe, call `acpi_amd_wbrf_supported_consumer` to check if WBRF
+ can be enabled for the device.
+2. Call `amd_wbrf_register_notifier` to register for notification
+ of frequency band change(add or remove) from other producers.
+3. Call the `amd_wbrf_retrieve_freq_band` initally to retrieve
+ current active frequency bands considering some producers may broadcast
+ such information before the consumer is up.
+4. On receiving a notification for frequency band change, run
+ `amd_wbrf_retrieve_freq_band` again to retrieve the latest
+ active frequency bands.
+5. During driver cleanup, call `amd_wbrf_unregister_notifier` to
+ unregister the notifier.
--
2.34.1
next prev parent reply other threads:[~2023-12-06 7:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 7:29 [PATCH v15 0/9] Enable Wifi RFI interference mitigation feature support Ma Jun
2023-12-06 7:29 ` Ma Jun [this message]
2023-12-07 12:01 ` [PATCH v15 1/9] Documentation/driver-api: Add document about WBRF mechanism kernel test robot
2023-12-06 7:29 ` [PATCH v15 2/9] platform/x86/amd: Add support for AMD ACPI based Wifi band RFI mitigation feature Ma Jun
2023-12-06 7:29 ` [PATCH v15 3/9] cfg80211: expose nl80211_chan_width_to_mhz for wide sharing Ma Jun
2023-12-06 7:29 ` [PATCH v15 4/9] wifi: mac80211: Add support for WBRF features Ma Jun
2023-12-06 7:29 ` [PATCH v15 5/9] drm/amd/pm: update driver_if and ppsmc headers for coming wbrf feature Ma Jun
2023-12-06 7:29 ` [PATCH v15 6/9] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature Ma Jun
2023-12-06 7:29 ` [PATCH v15 7/9] drm/amd/pm: add flood detection for wbrf events Ma Jun
2023-12-06 7:29 ` [PATCH v15 8/9] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0 Ma Jun
2023-12-06 7:29 ` [PATCH v15 9/9] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.7 Ma Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206072947.1331729-2-Jun.Ma2@amd.com \
--to=jun.ma2@amd.com \
--cc=Lijo.Lazar@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hdegoede@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=majun@amd.com \
--cc=mario.limonciello@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox