From: Zenm Chen <zenmchen@gmail.com>
To: Larry.Finger@lwfinger.net
Cc: Jes.Sorensen@gmail.com, kvalo@kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
pkshih@realtek.com, rtl8821cerfe2@gmail.com, zenmchen@gmail.com
Subject: Re: [PATCH v2] wifi: rtl8xxxu: Add additional USB IDs for RTL8192EU
Date: Sun, 17 Dec 2023 04:13:59 +0800 [thread overview]
Message-ID: <20231216201359.8176-1-zenmchen@gmail.com> (raw)
In-Reply-To: <20231216165259.5389-1-zenmchen@gmail.com>
>> On 12/16/23 10:52, Zenm Chen wrote:
>> Add additional USB IDs found in the vendor driver from
>> https://github.com/Mange/rtl8192eu-linux-driver to support more
>> RTL8192EU devices.
>>
>> Signed-off-by: Zenm Chen <zenmchen@gmail.com>
>> ---
>> v2:
>> - Not to put these USB IDs in CONFIG_RTL8XXXU_UNTESTED
>
> Have you tested all modes including STA, AP, P2P, etc? If not, then your devices
> belong in the CONFIG_RTL8XXXU_UNTESTED section.
You're right, I haven't tested these four devices, so they should be in the
CONFIG_RTL8XXXU_UNTESTED section.
Please drop this patch, thanks.
>
> I am also not fond of splitting the rtl8192eu devices into several different
> spots in the table. That only makes it harder to see what devices are supported.
>
> NACKed by Larry Finger <Larry.Finger@lwfinger.net>
>
> Larry
prev parent reply other threads:[~2023-12-16 20:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-16 16:52 [PATCH v2] wifi: rtl8xxxu: Add additional USB IDs for RTL8192EU devices Zenm Chen
2023-12-16 18:35 ` Larry Finger
2023-12-16 20:13 ` Zenm Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231216201359.8176-1-zenmchen@gmail.com \
--to=zenmchen@gmail.com \
--cc=Jes.Sorensen@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox