[PATCH v2] wifi: rtl8xxxu: Add additional USB IDs for RTL8192EU devices

[PATCH v2] wifi: rtl8xxxu: Add additional USB IDs for RTL8192EU devices

[Zenm Chen]

Add additional USB IDs found in the vendor driver from
https://github.com/Mange/rtl8192eu-linux-driver to support more
RTL8192EU devices.

Signed-off-by: Zenm Chen <zenmchen@gmail.com>
---
v2:
 - Not to put these USB IDs in CONFIG_RTL8XXXU_UNTESTED
---
 .../net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c    | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 43ee7592bc6e..3f30795f9375 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -7732,12 +7732,24 @@ static const struct usb_device_id dev_table[] = {
 /* TP-Link TL-WN822N v4 */
 {USB_DEVICE_AND_INTERFACE_INFO(0x2357, 0x0108, 0xff, 0xff, 0xff),
 	.driver_info = (unsigned long)&rtl8192eu_fops},
+/* D-Link DWA-131 rev C1 */
+{USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x3312, 0xff, 0xff, 0xff),
+	.driver_info = (unsigned long)&rtl8192eu_fops},
 /* D-Link DWA-131 rev E1, tested by David Patiño */
 {USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x3319, 0xff, 0xff, 0xff),
 	.driver_info = (unsigned long)&rtl8192eu_fops},
 /* Tested by Myckel Habets */
 {USB_DEVICE_AND_INTERFACE_INFO(0x2357, 0x0109, 0xff, 0xff, 0xff),
 	.driver_info = (unsigned long)&rtl8192eu_fops},
+/* TP-Link TL-WN8200ND V2 */
+{USB_DEVICE_AND_INTERFACE_INFO(0x2357, 0x0126, 0xff, 0xff, 0xff),
+	.driver_info = (unsigned long)&rtl8192eu_fops},
+/* Mercusys MW300UM */
+{USB_DEVICE_AND_INTERFACE_INFO(0x2c4e, 0x0100, 0xff, 0xff, 0xff),
+	.driver_info = (unsigned long)&rtl8192eu_fops},
+/* Mercusys MW300UH */
+{USB_DEVICE_AND_INTERFACE_INFO(0x2c4e, 0x0104, 0xff, 0xff, 0xff),
+	.driver_info = (unsigned long)&rtl8192eu_fops},
 {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDOR_ID_REALTEK, 0xb720, 0xff, 0xff, 0xff),
 	.driver_info = (unsigned long)&rtl8723bu_fops},
 {USB_DEVICE_AND_INTERFACE_INFO(0x7392, 0xa611, 0xff, 0xff, 0xff),
-- 
2.43.0

Re: [PATCH v2] wifi: rtl8xxxu: Add additional USB IDs for RTL8192EU devices

[Larry Finger]

On 12/16/23 10:52, Zenm Chen wrote:
> Add additional USB IDs found in the vendor driver from
> https://github.com/Mange/rtl8192eu-linux-driver to support more
> RTL8192EU devices.
> 
> Signed-off-by: Zenm Chen <zenmchen@gmail.com>
> ---
> v2:
>   - Not to put these USB IDs in CONFIG_RTL8XXXU_UNTESTED

Have you tested all modes including STA, AP, P2P, etc? If not, then your devices 
belong in the CONFIG_RTL8XXXU_UNTESTED section.

I am also not fond of splitting the rtl8192eu devices into several different 
spots in the table. That only makes it harder to see what devices are supported.

NACKed by Larry Finger <Larry.Finger@lwfinger.net>

Larry

Re: [PATCH v2] wifi: rtl8xxxu: Add additional USB IDs for RTL8192EU

[Zenm Chen]

>> On 12/16/23 10:52, Zenm Chen wrote:
>> Add additional USB IDs found in the vendor driver from
>> https://github.com/Mange/rtl8192eu-linux-driver to support more
>> RTL8192EU devices.
>>
>> Signed-off-by: Zenm Chen <zenmchen@gmail.com>
>> ---
>> v2:
>>   - Not to put these USB IDs in CONFIG_RTL8XXXU_UNTESTED
>
> Have you tested all modes including STA, AP, P2P, etc? If not, then your devices
> belong in the CONFIG_RTL8XXXU_UNTESTED section.

You're right, I haven't tested these four devices, so they should be in the 
CONFIG_RTL8XXXU_UNTESTED section.

Please drop this patch, thanks.

>
> I am also not fond of splitting the rtl8192eu devices into several different
> spots in the table. That only makes it harder to see what devices are supported.
>
> NACKed by Larry Finger <Larry.Finger@lwfinger.net>
>
> Larry