* [PATCH v2] wifi: wilc1000: remove setting msg.spi
@ 2024-02-01 20:12 David Lechner
2024-02-05 18:17 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: David Lechner @ 2024-02-01 20:12 UTC (permalink / raw)
To: Kalle Valo
Cc: David Lechner, Ajay Singh, Claudiu Beznea, linux-wireless,
linux-kernel
Calling spi_sync() unconditionally sets the spi field of struct
spi_message. Therefore setting msg.spi = spi before calling spi_sync()
has no effect and can be removed.
(spi_message_add_tail() does not access this field.)
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
v2 changes:
* fixed incomplete commit message
Link to v1: https://patchwork.kernel.org/project/linux-wireless/patch/20240123212135.2607178-1-dlechner@baylibre.com/
drivers/net/wireless/microchip/wilc1000/spi.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/wireless/microchip/wilc1000/spi.c b/drivers/net/wireless/microchip/wilc1000/spi.c
index 77b4cdff73c3..7eb0f8a421a3 100644
--- a/drivers/net/wireless/microchip/wilc1000/spi.c
+++ b/drivers/net/wireless/microchip/wilc1000/spi.c
@@ -300,7 +300,6 @@ static int wilc_spi_tx(struct wilc *wilc, u8 *b, u32 len)
memset(&msg, 0, sizeof(msg));
spi_message_init(&msg);
- msg.spi = spi;
spi_message_add_tail(&tr, &msg);
ret = spi_sync(spi, &msg);
@@ -343,7 +342,6 @@ static int wilc_spi_rx(struct wilc *wilc, u8 *rb, u32 rlen)
memset(&msg, 0, sizeof(msg));
spi_message_init(&msg);
- msg.spi = spi;
spi_message_add_tail(&tr, &msg);
ret = spi_sync(spi, &msg);
@@ -381,8 +379,6 @@ static int wilc_spi_tx_rx(struct wilc *wilc, u8 *wb, u8 *rb, u32 rlen)
memset(&msg, 0, sizeof(msg));
spi_message_init(&msg);
- msg.spi = spi;
-
spi_message_add_tail(&tr, &msg);
ret = spi_sync(spi, &msg);
if (ret < 0)
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] wifi: wilc1000: remove setting msg.spi
2024-02-01 20:12 [PATCH v2] wifi: wilc1000: remove setting msg.spi David Lechner
@ 2024-02-05 18:17 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2024-02-05 18:17 UTC (permalink / raw)
To: David Lechner
Cc: David Lechner, Ajay Singh, Claudiu Beznea, linux-wireless,
linux-kernel
David Lechner <dlechner@baylibre.com> wrote:
> Calling spi_sync() unconditionally sets the spi field of struct
> spi_message. Therefore setting msg.spi = spi before calling spi_sync()
> has no effect and can be removed.
>
> (spi_message_add_tail() does not access this field.)
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
Patch applied to wireless-next.git, thanks.
bed41a344426 wifi: wilc1000: remove setting msg.spi
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240201201248.2334798-2-dlechner@baylibre.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-05 18:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-01 20:12 [PATCH v2] wifi: wilc1000: remove setting msg.spi David Lechner
2024-02-05 18:17 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).