* [RESEND PATCH v4] iwlwifi: mvm: adding check if the thermal firmware is running
@ 2024-06-20 12:14 Guilherme Giacomo Simoes
0 siblings, 0 replies; 5+ messages in thread
From: Guilherme Giacomo Simoes @ 2024-06-20 12:14 UTC (permalink / raw)
To: miriam.rachel.korenblit, kvalo, rafael.j.wysocki, daniel.lezcano,
johannes.berg, gregory.greenman, dmantipov
Cc: Guilherme Giacomo Simoes, linux-wireless, linux-kernel
In the dmesg is showing the message "failed to read out thermal zone"
as if the temperature read is failed by don't find the thermal zone.
After researching and debugging, I see that this specific error is
occurrenced because the thermal try read the temperature when is started,
but the firmware is not running yet.
For more legibiliti i change the tt.c for return EAGAIN when this was occurrence.
After this change, in my computer I compile and install kernel in /boot
and in my dmesg the message "failed to read out thermal zone" is not show
any more.
I would like to thanks for Rafael Wysocki <refael.j.wysocki@intel.com> ,
Kalle Valo <kvalo@kernel.org> and Johannes Berg <johannes@sipsolutions.net>
for your suggestions in my previous patch.
Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
index 8083c4b2ab6b..d1dd334b5049 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
@@ -620,8 +620,12 @@ static int iwl_mvm_tzone_get_temp(struct thermal_zone_device *device,
mutex_lock(&mvm->mutex);
- if (!iwl_mvm_firmware_running(mvm) ||
- mvm->fwrt.cur_fw_img != IWL_UCODE_REGULAR) {
+ if (!iwl_mvm_firmware_running(mvm)) {
+ ret = -EAGAIN;
+ goto out;
+ }
+
+ if (mvm->fwrt.cur_fw_img != IWL_UCODE_REGULAR) {
ret = -ENODATA;
goto out;
}
--
2.45.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [RESEND PATCH v4] iwlwifi: mvm: adding check if the thermal firmware is running
@ 2024-06-22 13:43 Guilherme Giacomo Simoes
0 siblings, 0 replies; 5+ messages in thread
From: Guilherme Giacomo Simoes @ 2024-06-22 13:43 UTC (permalink / raw)
To: miriam.rachel.korenblit, kvalo, rafael.j.wysocki, daniel.lezcano,
johannes.berg, gregory.greenman, dmantipov
Cc: Guilherme Giacomo Simoes, linux-wireless, linux-kernel
In the dmesg is showing the message "failed to read out thermal zone"
as if the temperature read is failed by don't find the thermal zone.
After researching and debugging, I see that this specific error is
occurrenced because the thermal try read the temperature when is started,
but the firmware is not running yet.
For more legibiliti i change the tt.c for return EAGAIN when this was occurrence.
After this change, in my computer I compile and install kernel in /boot
and in my dmesg the message "failed to read out thermal zone" is not show
any more.
I would like to thanks for Rafael Wysocki <refael.j.wysocki@intel.com> ,
Kalle Valo <kvalo@kernel.org> and Johannes Berg <johannes@sipsolutions.net>
for your suggestions in my previous patch.
Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
index 8083c4b2ab6b..d1dd334b5049 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
@@ -620,8 +620,12 @@ static int iwl_mvm_tzone_get_temp(struct thermal_zone_device *device,
mutex_lock(&mvm->mutex);
- if (!iwl_mvm_firmware_running(mvm) ||
- mvm->fwrt.cur_fw_img != IWL_UCODE_REGULAR) {
+ if (!iwl_mvm_firmware_running(mvm)) {
+ ret = -EAGAIN;
+ goto out;
+ }
+
+ if (mvm->fwrt.cur_fw_img != IWL_UCODE_REGULAR) {
ret = -ENODATA;
goto out;
}
--
2.45.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [RESEND PATCH v4] iwlwifi: mvm: adding check if the thermal firmware is running
@ 2024-06-24 19:14 Guilherme Giacomo Simoes
2024-06-24 19:37 ` Johannes Berg
0 siblings, 1 reply; 5+ messages in thread
From: Guilherme Giacomo Simoes @ 2024-06-24 19:14 UTC (permalink / raw)
To: miriam.rachel.korenblit, kvalo, rafael.j.wysocki, daniel.lezcano,
johannes.berg, gregory.greenman, dmantipov
Cc: Guilherme Giacomo Simoes, linux-wireless, linux-kernel
In the dmesg is showing the message "failed to read out thermal zone"
as if the temperature read is failed by don't find the thermal zone.
After researching and debugging, I see that this specific error is
occurrenced because the thermal try read the temperature when is started,
but the firmware is not running yet.
For more legibiliti i change the tt.c for return EAGAIN when this was occurrence.
After this change, in my computer I compile and install kernel in /boot
and in my dmesg the message "failed to read out thermal zone" is not show
any more.
I would like to thanks for Rafael Wysocki <refael.j.wysocki@intel.com> ,
Kalle Valo <kvalo@kernel.org> and Johannes Berg <johannes@sipsolutions.net>
for your suggestions in my previous patch.
Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
index 8083c4b2ab6b..d1dd334b5049 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
@@ -620,8 +620,12 @@ static int iwl_mvm_tzone_get_temp(struct thermal_zone_device *device,
mutex_lock(&mvm->mutex);
- if (!iwl_mvm_firmware_running(mvm) ||
- mvm->fwrt.cur_fw_img != IWL_UCODE_REGULAR) {
+ if (!iwl_mvm_firmware_running(mvm)) {
+ ret = -EAGAIN;
+ goto out;
+ }
+
+ if (mvm->fwrt.cur_fw_img != IWL_UCODE_REGULAR) {
ret = -ENODATA;
goto out;
}
--
2.45.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RESEND PATCH v4] iwlwifi: mvm: adding check if the thermal firmware is running
2024-06-24 19:14 Guilherme Giacomo Simoes
@ 2024-06-24 19:37 ` Johannes Berg
0 siblings, 0 replies; 5+ messages in thread
From: Johannes Berg @ 2024-06-24 19:37 UTC (permalink / raw)
To: Guilherme Giacomo Simoes, miriam.rachel.korenblit, kvalo,
rafael.j.wysocki, daniel.lezcano, gregory.greenman, dmantipov
Cc: linux-wireless, linux-kernel
Please stop resending this every two days!
johannes
^ permalink raw reply [flat|nested] 5+ messages in thread
* [RESEND PATCH v4] iwlwifi: mvm: adding check if the thermal firmware is running
@ 2024-07-23 12:03 Guilherme Giacomo Simoes
0 siblings, 0 replies; 5+ messages in thread
From: Guilherme Giacomo Simoes @ 2024-07-23 12:03 UTC (permalink / raw)
To: miriam.rachel.korenblit, kvalo, rafael.j.wysocki, daniel.lezcano,
johannes.berg, gregory.greenman, dmantipov
Cc: Guilherme Giacomo Simoes, linux-wireless, linux-kernel
In the dmesg is showing the message "failed to read out thermal zone"
as if the temperature read is failed by don't find the thermal zone.
After researching and debugging, I see that this specific error is
occurrenced because the thermal try read the temperature when is started,
but the firmware is not running yet.
For more legibiliti i change the tt.c for return EAGAIN when this was occurrence.
After this change, in my computer I compile and install kernel in /boot
and in my dmesg the message "failed to read out thermal zone" is not show
any more.
I would like to thanks for Rafael Wysocki <refael.j.wysocki@intel.com> ,
Kalle Valo <kvalo@kernel.org> and Johannes Berg <johannes@sipsolutions.net>
for your suggestions in my previous patch.
Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
index 8083c4b2ab6b..d1dd334b5049 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
@@ -620,8 +620,12 @@ static int iwl_mvm_tzone_get_temp(struct thermal_zone_device *device,
mutex_lock(&mvm->mutex);
- if (!iwl_mvm_firmware_running(mvm) ||
- mvm->fwrt.cur_fw_img != IWL_UCODE_REGULAR) {
+ if (!iwl_mvm_firmware_running(mvm)) {
+ ret = -EAGAIN;
+ goto out;
+ }
+
+ if (mvm->fwrt.cur_fw_img != IWL_UCODE_REGULAR) {
ret = -ENODATA;
goto out;
}
--
2.45.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-07-23 12:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-20 12:14 [RESEND PATCH v4] iwlwifi: mvm: adding check if the thermal firmware is running Guilherme Giacomo Simoes
-- strict thread matches above, loose matches on Subject: below --
2024-06-22 13:43 Guilherme Giacomo Simoes
2024-06-24 19:14 Guilherme Giacomo Simoes
2024-06-24 19:37 ` Johannes Berg
2024-07-23 12:03 Guilherme Giacomo Simoes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).