From: Andrew Morton <akpm@linux-foundation.org>
To: Julian Sun <sunjunchao2870@gmail.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, jack@suse.cz, brauner@kernel.org,
viro@zeniv.linux.org.uk, masahiroy@kernel.org, n.schier@avm.de,
ojeda@kernel.org, djwong@kernel.org, kvalo@kernel.org
Subject: Re: [PATCH] scripts: add macro_checker script to check unused parameters in macros
Date: Tue, 23 Jul 2024 15:09:31 -0700 [thread overview]
Message-ID: <20240723150931.42f206f9cd86bc391b48c790@linux-foundation.org> (raw)
In-Reply-To: <20240723091154.52458-1-sunjunchao2870@gmail.com>
On Tue, 23 Jul 2024 05:11:54 -0400 Julian Sun <sunjunchao2870@gmail.com> wrote:
> Hi,
>
> Recently, I saw a patch[1] on the ext4 mailing list regarding
> the correction of a macro definition error. Jan mentioned
> that "The bug in the macro is a really nasty trap...".
> Because existing compilers are unable to detect
> unused parameters in macro definitions. This inspired me
> to write a script to check for unused parameters in
> macro definitions and to run it.
Seems a useful contribution thanks. And a nice changelog!
> scripts/macro_checker.py | 101 +++++++++++++++++++++++++++++++++++++++
Makes me wonder who will run this, and why. Perhaps a few people will
run ls and wonder "hey, what's that". But many people who might have
been interested in running this simply won't know about it.
"make help | grep check" shows we have a few ad-hoc integrations but I
wonder if we would benefit from a top-level `make static-checks'
target?
next prev parent reply other threads:[~2024-07-23 22:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 9:11 [PATCH] scripts: add macro_checker script to check unused parameters in macros Julian Sun
2024-07-23 22:09 ` Andrew Morton [this message]
2024-07-24 3:03 ` Julian Sun
2024-07-24 5:03 ` Andrew Morton
2024-07-24 9:06 ` Johannes Berg
2024-07-25 2:30 ` Julian Sun
2024-07-25 2:43 ` Andrew Morton
2024-07-25 3:05 ` Julian Sun
2024-07-25 4:48 ` Nicolas Schier
2024-07-25 8:00 ` Julian Sun
2024-07-24 10:00 ` Jan Kara
2024-07-25 2:12 ` Julian Sun
2024-07-24 13:30 ` Joe Perches
2024-07-25 2:09 ` Julian Sun
2024-07-25 3:40 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240723150931.42f206f9cd86bc391b48c790@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=kvalo@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=n.schier@avm.de \
--cc=ojeda@kernel.org \
--cc=sunjunchao2870@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox