From: "Michael Büsch" <m@bues.ch>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Kalle Valo <kvalo@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: Re: [PATCH v2] wifi: b43: Constify struct lpphy_tx_gain_table_entry
Date: Sun, 4 Aug 2024 10:05:26 +0200 [thread overview]
Message-ID: <20240804100526.19942fbe@barney> (raw)
In-Reply-To: <e33bc9e6dff4a5b6cd8d0ab5399aa1abac5bef9d.1722753127.git.christophe.jaillet@wanadoo.fr>
[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]
On Sun, 4 Aug 2024 08:32:44 +0200
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> 'struct lpphy_tx_gain_table_entry' are not modified in this driver.
>
> Constifying this structure moves some data to a read-only section, so
> increase overall security.
>
> On a x86_64, with allmodconfig:
> Before:
> ======
> text data bss dec hex filename
> 16481 6232 0 22713 58b9 drivers/net/wireless/broadcom/b43/tables_lpphy.o
>
> After:
> =====
> text data bss dec hex filename
> 22305 395 0 22700 58ac drivers/net/wireless/broadcom/b43/tables_lpphy.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested-only.
>
> lpphy_write_gain_table() and lpphy_write_gain_table_bulk() could also be
> made static and removed from tables_lpphy.h, but without knowing the reason
> why it is done this way, I've preferred to leave it as-is.
>
> Changes in v2:
> - remove unrelated and un-needed constification [Michael Büsch]
> - update numbers in the commit log
Acked-By: Michael Büsch <m@bues.ch>
--
Michael Büsch
https://bues.ch/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-08-04 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-04 6:32 [PATCH v2] wifi: b43: Constify struct lpphy_tx_gain_table_entry Christophe JAILLET
2024-08-04 8:05 ` Michael Büsch [this message]
2024-08-07 17:16 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240804100526.19942fbe@barney \
--to=m@bues.ch \
--cc=b43-dev@lists.infradead.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).