From: Marek Vasut <marex@denx.de>
To: linux-wireless@vger.kernel.org
Cc: "Chung-Hsien Hsu" <stanley.hsu@cypress.com>,
"Chung-Hsien Hsu" <chung-hsien.hsu@infineon.com>,
"Marek Vasut" <marex@denx.de>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Arend van Spriel" <arend.vanspriel@broadcom.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Carter Chen" <carter.chen@infineon.com>,
"Duoming Zhou" <duoming@zju.edu.cn>,
"Erick Archer" <erick.archer@outlook.com>,
"Kalle Valo" <kvalo@kernel.org>, "Kees Cook" <kees@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Mathias Krause" <minipli@grsecurity.net>,
"Matthias Brugger" <mbrugger@suse.com>,
"Owen Huang" <Owen.Huang@infineon.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
brcm80211-dev-list.pdl@broadcom.com, brcm80211@lists.linux.dev
Subject: [PATCH 1/2] wifi: brcmfmac: add support for TRX firmware download
Date: Sun, 18 Aug 2024 22:12:25 +0200 [thread overview]
Message-ID: <20240818201533.89669-1-marex@denx.de> (raw)
From: Chung-Hsien Hsu <stanley.hsu@cypress.com>
Add support to download TRX firmware for PCIe and SDIO.
Signed-off-by: Chung-Hsien Hsu <chung-hsien.hsu@infineon.com>
Signed-off-by: Marek Vasut <marex@denx.de> # Upport to current linux-next
---
NOTE: This is downstream upport from
https://github.com/Infineon/ifx-wireless-drivers/
branch RTM/v5.15.58-Indrik / tag release-v5.15.58-2024_0514
- ba34bf4816f9 ("brcmfmac: add support for TRX firmware download")
---
Cc: "Dr. David Alan Gilbert" <linux@treblig.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Carter Chen <carter.chen@infineon.com>
Cc: Chung-Hsien Hsu <stanley.hsu@cypress.com>
Cc: Duoming Zhou <duoming@zju.edu.cn>
Cc: Erick Archer <erick.archer@outlook.com>
Cc: Kalle Valo <kvalo@kernel.org>
Cc: Kees Cook <kees@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Mathias Krause <minipli@grsecurity.net>
Cc: Matthias Brugger <mbrugger@suse.com>
Cc: Owen Huang <Owen.Huang@infineon.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: brcm80211-dev-list.pdl@broadcom.com
Cc: brcm80211@lists.linux.dev
Cc: linux-wireless@vger.kernel.org
---
.../broadcom/brcm80211/brcmfmac/pcie.c | 12 +++++-
.../broadcom/brcm80211/brcmfmac/sdio.c | 20 +++++++---
.../broadcom/brcm80211/brcmfmac/trxhdr.h | 38 +++++++++++++++++++
3 files changed, 63 insertions(+), 7 deletions(-)
create mode 100644 drivers/net/wireless/broadcom/brcm80211/brcmfmac/trxhdr.h
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
index ce482a3877e90..058a742d17eda 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
@@ -42,6 +42,7 @@
#include "chip.h"
#include "core.h"
#include "common.h"
+#include "trxhdr.h"
enum brcmf_pcie_state {
@@ -1684,6 +1685,8 @@ static int brcmf_pcie_download_fw_nvram(struct brcmf_pciedev_info *devinfo,
u32 nvram_len)
{
struct brcmf_bus *bus = dev_get_drvdata(&devinfo->pdev->dev);
+ struct trx_header_le *trx = (struct trx_header_le *)fw->data;
+ u32 fw_size;
u32 sharedram_addr;
u32 sharedram_addr_written;
u32 loop_counter;
@@ -1697,8 +1700,13 @@ static int brcmf_pcie_download_fw_nvram(struct brcmf_pciedev_info *devinfo,
return err;
brcmf_dbg(PCIE, "Download FW %s\n", devinfo->fw_name);
- memcpy_toio(devinfo->tcm + devinfo->ci->rambase,
- (void *)fw->data, fw->size);
+ address = devinfo->ci->rambase;
+ fw_size = fw->size;
+ if (trx->magic == cpu_to_le32(TRX_MAGIC)) {
+ address -= sizeof(struct trx_header_le);
+ fw_size = le32_to_cpu(trx->len);
+ }
+ memcpy_toio(devinfo->tcm + address, (void *)fw->data, fw_size);
resetintr = get_unaligned_le32(fw->data);
release_firmware(fw);
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
index 1461dc453ac22..08881e366cae2 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
@@ -35,6 +35,7 @@
#include "core.h"
#include "common.h"
#include "bcdc.h"
+#include "trxhdr.h"
#define DCMD_RESP_TIMEOUT msecs_to_jiffies(2500)
#define CTL_DONE_TIMEOUT msecs_to_jiffies(2500)
@@ -3346,17 +3347,26 @@ brcmf_sdio_verifymemory(struct brcmf_sdio_dev *sdiodev, u32 ram_addr,
static int brcmf_sdio_download_code_file(struct brcmf_sdio *bus,
const struct firmware *fw)
{
+ struct trx_header_le *trx = (struct trx_header_le *)fw->data;
+ u32 fw_size;
+ u32 address;
int err;
brcmf_dbg(TRACE, "Enter\n");
- err = brcmf_sdiod_ramrw(bus->sdiodev, true, bus->ci->rambase,
- (u8 *)fw->data, fw->size);
+ address = bus->ci->rambase;
+ fw_size = fw->size;
+ if (trx->magic == cpu_to_le32(TRX_MAGIC)) {
+ address -= sizeof(struct trx_header_le);
+ fw_size = le32_to_cpu(trx->len);
+ }
+ err = brcmf_sdiod_ramrw(bus->sdiodev, true, address,
+ (u8 *)fw->data, fw_size);
if (err)
brcmf_err("error %d on writing %d membytes at 0x%08x\n",
- err, (int)fw->size, bus->ci->rambase);
- else if (!brcmf_sdio_verifymemory(bus->sdiodev, bus->ci->rambase,
- (u8 *)fw->data, fw->size))
+ err, (int)fw_size, address);
+ else if (!brcmf_sdio_verifymemory(bus->sdiodev, address,
+ (u8 *)fw->data, fw_size))
err = -EIO;
return err;
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/trxhdr.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/trxhdr.h
new file mode 100644
index 0000000000000..0411c7c7ffb99
--- /dev/null
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/trxhdr.h
@@ -0,0 +1,38 @@
+/* SPDX-License-Identifier: ISC */
+/* Copyright (c) 2020 Cypress Semiconductor Corporation */
+
+#ifndef BRCMFMAC_TRXHDR_H
+#define BRCMFMAC_TRXHDR_H
+
+/* Bootloader makes special use of trx header "offsets" array */
+enum {
+ TRX_OFFSET_SIGN_INFO_IDX = 0,
+ TRX_OFFSET_DATA_FOR_SIGN1_IDX = 1,
+ TRX_OFFSET_DATA_FOR_SIGN2_IDX = 2,
+ TRX_OFFSET_ROOT_MODULUS_IDX = 3,
+ TRX_OFFSET_ROOT_EXPONENT_IDX = 67,
+ TRX_OFFSET_CONT_MODULUS_IDX = 68,
+ TRX_OFFSET_CONT_EXPONENT_IDX = 132,
+ TRX_OFFSET_HASH_FW_IDX = 133,
+ TRX_OFFSET_FW_LEN_IDX = 149,
+ TRX_OFFSET_TR_RST_IDX = 150,
+ TRX_OFFSET_FW_VER_FOR_ANTIROOLBACK_IDX = 151,
+ TRX_OFFSET_IV_IDX = 152,
+ TRX_OFFSET_NONCE_IDX = 160,
+ TRX_OFFSET_SIGN_INFO2_IDX = 168,
+ TRX_OFFSET_MAX_IDX
+};
+
+#define TRX_MAGIC 0x30524448 /* "HDR0" */
+#define TRX_VERSION 4 /* Version 4 */
+#define TRX_MAX_OFFSET TRX_OFFSET_MAX_IDX /* Max number of file offsets */
+
+struct trx_header_le {
+ __le32 magic; /* "HDR0" */
+ __le32 len; /* Length of file including header */
+ __le32 crc32; /* CRC from flag_version to end of file */
+ __le32 flag_version; /* 0:15 flags, 16:31 version */
+ __le32 offsets[TRX_MAX_OFFSET]; /* Offsets of partitions */
+};
+
+#endif /* BRCMFMAC_TRXHDR_H */
--
2.43.0
next reply other threads:[~2024-08-18 20:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-18 20:12 Marek Vasut [this message]
2024-08-18 20:12 ` [PATCH 2/2] wifi: brcmfmac: add support for CYW55572 PCIe chipset Marek Vasut
2024-08-19 8:39 ` kernel test robot
2024-08-19 3:08 ` [PATCH 1/2] wifi: brcmfmac: add support for TRX firmware download Ping-Ke Shih
2024-08-19 11:15 ` Marek Vasut
2024-08-19 14:35 ` Kalle Valo
2024-08-19 15:52 ` Arend Van Spriel
2024-08-19 16:17 ` Marek Vasut
2024-08-19 18:09 ` Florian Fainelli
2024-08-21 16:10 ` Marek Vasut
2024-08-22 8:37 ` Kalle Valo
2024-08-22 15:15 ` Marek Vasut
2024-09-01 6:55 ` Arend Van Spriel
2024-09-09 20:27 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240818201533.89669-1-marex@denx.de \
--to=marex@denx.de \
--cc=Owen.Huang@infineon.com \
--cc=arend.vanspriel@broadcom.com \
--cc=bhelgaas@google.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=carter.chen@infineon.com \
--cc=chung-hsien.hsu@infineon.com \
--cc=duoming@zju.edu.cn \
--cc=erick.archer@outlook.com \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@treblig.org \
--cc=mbrugger@suse.com \
--cc=minipli@grsecurity.net \
--cc=stanley.hsu@cypress.com \
--cc=ulf.hansson@linaro.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).