From: "Michael Büsch" <m@bues.ch>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-wireless@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ssb: Call ssb_bus_may_powerdown(bus) only once in ssb_bus_register()
Date: Wed, 25 Sep 2024 18:27:39 +0200 [thread overview]
Message-ID: <20240925182739.5c9ca063@barney> (raw)
In-Reply-To: <d6037759-4dc8-4cc7-922f-95739761d068@web.de>
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
On Tue, 24 Sep 2024 21:33:49 +0200
Markus Elfring <Markus.Elfring@web.de> wrote:
> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> index aa6165e3db4a..458858b5472e 100644
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -663,11 +663,9 @@ ssb_bus_register(struct ssb_bus *bus,
> ssb_extif_init(&bus->extif);
> ssb_mipscore_init(&bus->mipscore);
> err = ssb_fetch_invariants(bus, get_invariants);
> - if (err) {
> - ssb_bus_may_powerdown(bus);
> - goto err_pcmcia_exit;
> - }
> ssb_bus_may_powerdown(bus);
> + if (err)
> + goto err_pcmcia_exit;
>
> /* Queue it for attach.
> * See the comment at the ssb_is_early_boot definition.
Acked-by: Michael Büsch <m@bues.ch>
--
Michael Büsch
https://bues.ch/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-09-25 17:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 19:33 [PATCH] ssb: Call ssb_bus_may_powerdown(bus) only once in ssb_bus_register() Markus Elfring
2024-09-25 16:27 ` Michael Büsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240925182739.5c9ca063@barney \
--to=m@bues.ch \
--cc=Markus.Elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox