From: Marek Vasut <marex@denx.de>
To: linux-wireless@vger.kernel.org
Cc: "Marek Vasut" <marex@denx.de>,
"Ajay Singh" <ajay.kathat@microchip.com>,
"Alexis Lothoré" <alexis.lothore@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Kalle Valo" <kvalo@kernel.org>
Subject: [PATCH v2] wifi: wilc1000: Keep slot powered on during suspend/resume
Date: Thu, 26 Sep 2024 21:50:55 +0200 [thread overview]
Message-ID: <20240926195113.2823392-1-marex@denx.de> (raw)
The WILC3000 can suspend and enter low power state. According to local
measurements, the WILC3000 consumes the same amount of power if the slot
is powered up and WILC3000 is suspended, and if the WILC3000 is powered
off. Use the former option, keep the WILC3000 powered up as that allows
for things like WoWlan to work.
Note that this is tested on WILC3000 only, not on WILC1000 .
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Ajay Singh <ajay.kathat@microchip.com>
Cc: Alexis Lothoré <alexis.lothore@bootlin.com>
Cc: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Cc: Kalle Valo <kvalo@kernel.org>
Cc: Marek Vasut <marex@denx.de>
Cc: linux-wireless@vger.kernel.org
---
V2: Rebase on next-20240926
---
drivers/net/wireless/microchip/wilc1000/sdio.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c b/drivers/net/wireless/microchip/wilc1000/sdio.c
index b4da05d5a498a..d67662b6b2a1a 100644
--- a/drivers/net/wireless/microchip/wilc1000/sdio.c
+++ b/drivers/net/wireless/microchip/wilc1000/sdio.c
@@ -969,7 +969,6 @@ static int wilc_sdio_suspend(struct device *dev)
{
struct sdio_func *func = dev_to_sdio_func(dev);
struct wilc *wilc = sdio_get_drvdata(func);
- int ret;
dev_info(dev, "sdio suspend\n");
@@ -983,13 +982,7 @@ static int wilc_sdio_suspend(struct device *dev)
wilc_sdio_disable_interrupt(wilc);
- ret = wilc_sdio_reset(wilc);
- if (ret) {
- dev_err(&func->dev, "Fail reset sdio\n");
- return ret;
- }
-
- return 0;
+ return sdio_set_host_pm_flags(func, MMC_PM_KEEP_POWER);
}
static int wilc_sdio_resume(struct device *dev)
--
2.45.2
next reply other threads:[~2024-09-26 19:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 19:50 Marek Vasut [this message]
2024-09-28 11:18 ` [PATCH v2] wifi: wilc1000: Keep slot powered on during suspend/resume Kalle Valo
2024-09-29 15:23 ` Marek Vasut
2024-09-30 4:51 ` Kalle Valo
2024-10-03 8:31 ` Alexis Lothoré
2024-10-03 10:49 ` Marek Vasut
2024-10-03 12:58 ` Alexis Lothoré
2024-10-03 13:18 ` Marek Vasut
2024-10-03 13:59 ` Alexis Lothoré
2024-10-03 14:18 ` Marek Vasut
2024-10-03 15:51 ` Alexis Lothoré
2024-10-17 16:47 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240926195113.2823392-1-marex@denx.de \
--to=marex@denx.de \
--cc=ajay.kathat@microchip.com \
--cc=alexis.lothore@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).