public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: linux@treblig.org
To: johannes@sipsolutions.net, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Dr. David Alan Gilbert" <linux@treblig.org>
Subject: [PATCH 1/2] cfg80211: Remove unused cfg80211_background_cac_abort
Date: Sun,  6 Oct 2024 23:53:02 +0100	[thread overview]
Message-ID: <20241006225303.121445-2-linux@treblig.org> (raw)
In-Reply-To: <20241006225303.121445-1-linux@treblig.org>

From: "Dr. David Alan Gilbert" <linux@treblig.org>

cfg80211_background_cac_abort() is unused.
It got renamed from cfg80211_offchan_cac_abort by commit
a95bfb876fa8 ("cfg80211: rename offchannel_chain structs to background_chain to avoid confusion with ETSI standard")

and that was originally added in commit
1507b1531981 ("cfg80211: move offchan_cac_event to a dedicated work")
but never used.

To me it looks like the queue is still used (I see a queue_work
in __cfg80211_radar_event), so I think it's just the wrapper that's
unused.

Remove cfg80211_background_cac_abort.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 include/net/cfg80211.h | 9 ---------
 net/wireless/mlme.c    | 8 --------
 2 files changed, 17 deletions(-)

diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index 69ec1eb41a09..fd843a519329 100644
--- a/include/net/cfg80211.h
+++ b/include/net/cfg80211.h
@@ -8752,15 +8752,6 @@ void cfg80211_cac_event(struct net_device *netdev,
 			enum nl80211_radar_event event, gfp_t gfp,
 			unsigned int link_id);
 
-/**
- * cfg80211_background_cac_abort - Channel Availability Check offchan abort event
- * @wiphy: the wiphy
- *
- * This function is called by the driver when a Channel Availability Check
- * (CAC) is aborted by a offchannel dedicated chain.
- */
-void cfg80211_background_cac_abort(struct wiphy *wiphy);
-
 /**
  * cfg80211_gtk_rekey_notify - notify userspace about driver rekeying
  * @dev: network device
diff --git a/net/wireless/mlme.c b/net/wireless/mlme.c
index 4dac81854721..8ec236bbbc7c 100644
--- a/net/wireless/mlme.c
+++ b/net/wireless/mlme.c
@@ -1226,14 +1226,6 @@ void cfg80211_background_cac_abort_wk(struct work_struct *work)
 				      NL80211_RADAR_CAC_ABORTED);
 }
 
-void cfg80211_background_cac_abort(struct wiphy *wiphy)
-{
-	struct cfg80211_registered_device *rdev = wiphy_to_rdev(wiphy);
-
-	queue_work(cfg80211_wq, &rdev->background_cac_abort_wk);
-}
-EXPORT_SYMBOL(cfg80211_background_cac_abort);
-
 int
 cfg80211_start_background_radar_detection(struct cfg80211_registered_device *rdev,
 					  struct wireless_dev *wdev,
-- 
2.46.2


  reply	other threads:[~2024-10-06 22:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-06 22:53 [PATCH 0/2] Some cfg80211 deadcode removal linux
2024-10-06 22:53 ` linux [this message]
2024-10-07  6:59   ` [PATCH 1/2] cfg80211: Remove unused cfg80211_background_cac_abort Vasanthakumar Thiagarajan
2024-10-07 11:02     ` Dr. David Alan Gilbert
2024-10-06 22:53 ` [PATCH 2/2] cfg80211: Remove unused cfg80211_vendor_ functions linux
2024-10-07 11:04   ` Johannes Berg
2024-10-07 11:29     ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241006225303.121445-2-linux@treblig.org \
    --to=linux@treblig.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox