From: Francesco Dolcini <francesco@dolcini.it>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Brian Norris <briannorris@chromium.org>,
Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] wifi: mwifiex: cleanup struct mwifiex_auto_tdls_peer
Date: Mon, 7 Oct 2024 09:15:51 +0200 [thread overview]
Message-ID: <20241007071551.GA10017@francesco-nb> (raw)
In-Reply-To: <20240927084317.96687-1-dmantipov@yandex.ru>
Hello Dmitry,
thanks for your patch.
On Fri, Sep 27, 2024 at 11:43:16AM +0300, Dmitry Antipov wrote:
> Remove set but otherwise unused 'do_setup' member of
> 'struct mwifiex_auto_tdls_peer'. Compile tested only.
>
> Fixes: 9927baa3c724 ("mwifiex: add auto TDLS support")
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
It looks like you are not having in Cc: the right people, please verify
your workflow.
In addition I do not think that such kind of patches should have a Fixes
tag. As you correctly wrote in the subject this is a clean-up, not a
fix.
I personally prefer to have a cover letter anytime you have more than 1
patch.
These applies to both the patches in this series.
Francesco
next prev parent reply other threads:[~2024-10-07 7:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 8:43 [PATCH 1/2] wifi: mwifiex: cleanup struct mwifiex_auto_tdls_peer Dmitry Antipov
2024-09-27 8:43 ` [PATCH 2/2] wifi: mwifiex: cleanup struct mwifiex_private Dmitry Antipov
2024-10-07 7:15 ` Francesco Dolcini [this message]
2024-10-17 16:48 ` [1/2] wifi: mwifiex: cleanup struct mwifiex_auto_tdls_peer Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007071551.GA10017@francesco-nb \
--to=francesco@dolcini.it \
--cc=briannorris@chromium.org \
--cc=dmantipov@yandex.ru \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox