From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: Johannes Berg <johannes.berg@intel.com>
Cc: Alexandre Ferrieux <alexandre.ferrieux@gmail.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
<linux-wireless@vger.kernel.org>
Subject: [PATCH v1 wl-next 2/3] wifi: wext: Convert wireless_nlevent_work to per-netns work.
Date: Mon, 14 Oct 2024 13:55:42 -0700 [thread overview]
Message-ID: <20241014205543.94787-3-kuniyu@amazon.com> (raw)
In-Reply-To: <20241014205543.94787-1-kuniyu@amazon.com>
The next patch will namespacify wireless_nlevent_flush(), which is called
by wireless_nlevent_process() and two netdev notifiers.
As a preparation, let's convert wireless_nlevent_work to per-netns work.
Suggested-by: Johannes Berg <johannes.berg@intel.com>
Link: https://lore.kernel.org/netdev/cd8045c03573a012f71a1afdcfb5d9c108b6fefa.camel@sipsolutions.net/
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
net/wireless/wext-core.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/net/wireless/wext-core.c b/net/wireless/wext-core.c
index bfc13e0d9883..4d7699135f46 100644
--- a/net/wireless/wext-core.c
+++ b/net/wireless/wext-core.c
@@ -346,6 +346,7 @@ static const int compat_event_type_size[] = {
struct wext_net {
struct sk_buff_head nlevents;
+ struct work_struct nlevent_work;
};
static int wext_net_id;
@@ -391,11 +392,18 @@ static struct notifier_block wext_netdev_notifier = {
.notifier_call = wext_netdev_notifier_call,
};
+/* Process events generated by the wireless layer or the driver. */
+static void wireless_nlevent_process(struct work_struct *work)
+{
+ wireless_nlevent_flush();
+}
+
static int __net_init wext_pernet_init(struct net *net)
{
struct wext_net *wnet = wext_net(net);
skb_queue_head_init(&wnet->nlevents);
+ INIT_WORK(&wnet->nlevent_work, wireless_nlevent_process);
return 0;
}
@@ -405,6 +413,7 @@ static void __net_exit wext_pernet_exit(struct net *net)
struct wext_net *wnet = wext_net(net);
skb_queue_purge(&wnet->nlevents);
+ cancel_work_sync(&wnet->nlevent_work);
}
static struct pernet_operations wext_pernet_ops = {
@@ -429,14 +438,6 @@ static int __init wireless_nlevent_init(void)
subsys_initcall(wireless_nlevent_init);
-/* Process events generated by the wireless layer or the driver. */
-static void wireless_nlevent_process(struct work_struct *work)
-{
- wireless_nlevent_flush();
-}
-
-static DECLARE_WORK(wireless_nlevent_work, wireless_nlevent_process);
-
static struct nlmsghdr *rtnetlink_ifinfo_prep(struct net_device *dev,
struct sk_buff *skb)
{
@@ -656,7 +657,7 @@ void wireless_send_event(struct net_device * dev,
#endif
wnet = wext_net(dev_net(dev));
skb_queue_tail(&wnet->nlevents, skb);
- schedule_work(&wireless_nlevent_work);
+ schedule_work(&wnet->nlevent_work);
}
EXPORT_SYMBOL(wireless_send_event);
--
2.39.5 (Apple Git-154)
next prev parent reply other threads:[~2024-10-14 20:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 20:55 [PATCH v1 wl-next 0/3] wifi: wext: Namespacify wireless_nlevent_flush() calls Kuniyuki Iwashima
2024-10-14 20:55 ` [PATCH v1 wl-next 1/3] wifi: wext: Move wext_nlevents to net->gen[] Kuniyuki Iwashima
2024-10-15 6:36 ` Johannes Berg
2024-10-16 0:49 ` Kuniyuki Iwashima
2024-10-16 8:56 ` Johannes Berg
2024-10-16 23:58 ` Kuniyuki Iwashima
2024-10-17 8:06 ` Johannes Berg
2024-10-14 20:55 ` Kuniyuki Iwashima [this message]
2024-10-14 20:55 ` [PATCH v1 wl-next 3/3] wifi: wext: Don't iterate all netns in wireless_nlevent_flush() Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014205543.94787-3-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=alexandre.ferrieux@gmail.com \
--cc=johannes.berg@intel.com \
--cc=kuni1840@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox