* [PATCH] wifi: rtw89: Fix TX fail with A2DP after scanning
@ 2024-10-21 6:32 Ping-Ke Shih
2024-10-25 2:25 ` Ping-Ke Shih
0 siblings, 1 reply; 2+ messages in thread
From: Ping-Ke Shih @ 2024-10-21 6:32 UTC (permalink / raw)
To: linux-wireless; +Cc: phhuang
From: Po-Hao Huang <phhuang@realtek.com>
There might be some racing between BT and WiFi after scan. Since
one of the TX related register will be modified by both FW and
rtw89_set_channel() in driver, which could cause Tx fail. Reorder
the calling sequence to only notify coexistence mechanism after
rtw89_set_channel() is called, so that there are no concurrent
operations.
Fixes: 5f499ce69b8d ("wifi: rtw89: pause/proceed MCC for ROC and HW scan")
Signed-off-by: Po-Hao Huang <phhuang@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
drivers/net/wireless/realtek/rtw89/fw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c
index 744a8d277cfc..b1123a4ee999 100644
--- a/drivers/net/wireless/realtek/rtw89/fw.c
+++ b/drivers/net/wireless/realtek/rtw89/fw.c
@@ -6675,6 +6675,8 @@ void rtw89_hw_scan_complete(struct rtw89_dev *rtwdev,
if (!rtwvif_link)
return;
+ rtw89_chanctx_proceed(rtwdev);
+
rtwvif = rtwvif_link->rtwvif;
reg = rtw89_mac_reg_by_idx(rtwdev, mac->rx_fltr, rtwvif_link->mac_idx);
@@ -6692,8 +6694,6 @@ void rtw89_hw_scan_complete(struct rtw89_dev *rtwdev,
scan_info->last_chan_idx = 0;
scan_info->scanning_vif = NULL;
scan_info->abort = false;
-
- rtw89_chanctx_proceed(rtwdev);
}
void rtw89_hw_scan_abort(struct rtw89_dev *rtwdev,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wifi: rtw89: Fix TX fail with A2DP after scanning
2024-10-21 6:32 [PATCH] wifi: rtw89: Fix TX fail with A2DP after scanning Ping-Ke Shih
@ 2024-10-25 2:25 ` Ping-Ke Shih
0 siblings, 0 replies; 2+ messages in thread
From: Ping-Ke Shih @ 2024-10-25 2:25 UTC (permalink / raw)
To: Ping-Ke Shih, linux-wireless; +Cc: phhuang
Ping-Ke Shih <pkshih@realtek.com> wrote:
> From: Po-Hao Huang <phhuang@realtek.com>
>
> There might be some racing between BT and WiFi after scan. Since
> one of the TX related register will be modified by both FW and
> rtw89_set_channel() in driver, which could cause Tx fail. Reorder
> the calling sequence to only notify coexistence mechanism after
> rtw89_set_channel() is called, so that there are no concurrent
> operations.
>
> Fixes: 5f499ce69b8d ("wifi: rtw89: pause/proceed MCC for ROC and HW scan")
> Signed-off-by: Po-Hao Huang <phhuang@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
1 patch(es) applied to rtw-next branch of rtw.git, thanks.
f16c40acd319 wifi: rtw89: Fix TX fail with A2DP after scanning
---
https://github.com/pkshih/rtw.git
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-25 2:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-21 6:32 [PATCH] wifi: rtw89: Fix TX fail with A2DP after scanning Ping-Ke Shih
2024-10-25 2:25 ` Ping-Ke Shih
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).