From: Kalle Valo <kvalo@kernel.org>
To: ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH v2 1/8] wifi: ath12k: ath12k_mac_vdev_create(): use goto for error handling
Date: Fri, 1 Nov 2024 17:16:58 +0200 [thread overview]
Message-ID: <20241101151705.165987-2-kvalo@kernel.org> (raw)
In-Reply-To: <20241101151705.165987-1-kvalo@kernel.org>
From: Kalle Valo <quic_kvalo@quicinc.com>
In commit 477cabfdb776 ("wifi: ath12k: modify link arvif creation and removal
for MLO") I had accidentally left one personal TODO comment about using goto
instead of ret. Switch to use goto to be consistent with the error handling in
the function.
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
---
drivers/net/wireless/ath/ath12k/mac.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
index f5f96a8b1d61..7dd2b66d3386 100644
--- a/drivers/net/wireless/ath/ath12k/mac.c
+++ b/drivers/net/wireless/ath/ath12k/mac.c
@@ -7047,8 +7047,7 @@ int ath12k_mac_vdev_create(struct ath12k *ar, struct ath12k_link_vif *arvif)
ret = ath12k_wait_for_peer_delete_done(ar, arvif->vdev_id,
arvif->bssid);
if (ret)
- /* KVALO: why not goto err? */
- return ret;
+ goto err_vdev_del;
ar->num_peers--;
}
--
2.39.5
next prev parent reply other threads:[~2024-11-01 15:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 15:16 [PATCH v2 0/8] wifi: ath12k: MLO support part 2 Kalle Valo
2024-11-01 15:16 ` Kalle Valo [this message]
2024-11-01 16:21 ` [PATCH v2 1/8] wifi: ath12k: ath12k_mac_vdev_create(): use goto for error handling Jeff Johnson
2024-11-01 15:16 ` [PATCH v2 2/8] wifi: ath12k: MLO vdev bringup changes Kalle Valo
2024-11-01 16:26 ` Jeff Johnson
2024-11-01 15:17 ` [PATCH v2 3/8] wifi: ath12k: Refactor sta state machine Kalle Valo
2024-11-01 16:36 ` Jeff Johnson
2024-11-01 15:17 ` [PATCH v2 4/8] wifi: ath12k: introduce ath12k_hw_warn() Kalle Valo
2024-11-01 16:37 ` Jeff Johnson
2024-11-01 15:17 ` [PATCH v2 5/8] wifi: ath12k: Add helpers for multi link peer creation and deletion Kalle Valo
2024-11-01 16:39 ` Jeff Johnson
2024-11-01 15:17 ` [PATCH v2 6/8] wifi: ath12k: add multi-link flag in peer create command Kalle Valo
2024-11-01 16:46 ` Jeff Johnson
2024-11-01 15:17 ` [PATCH v2 7/8] wifi: ath12k: add helper to find multi-link station Kalle Valo
2024-11-01 16:47 ` Jeff Johnson
2024-11-01 15:17 ` [PATCH v2 8/8] wifi: ath12k: Add MLO peer assoc command support Kalle Valo
2024-11-01 16:50 ` Jeff Johnson
2024-11-01 16:51 ` [PATCH v2 0/8] wifi: ath12k: MLO support part 2 Jeff Johnson
2024-11-04 11:13 ` Kalle Valo
2024-11-04 15:43 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241101151705.165987-2-kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox