Re: [PATCH v2 1/8] dt-bindings: net: wireless: Describe ath12k PCI module with WSI

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1472 bytes --]

On Mon, Dec 09, 2024 at 05:30:27PM +0200, Kalle Valo wrote:
> From: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
> 
> The QCN9274 WiFi device supports WSI (WLAN Serial Interface). WSI is used
> to exchange specific control information across radios using a doorbell
> mechanism. This WSI connection is essential for exchanging control
> information among these devices. The WSI interface in the QCN9274 includes
> TX and RX ports, which are used to connect multiple WSI-supported devices
> together, forming a WSI group.
> 
> Describe QCN9274 PCI wifi device with WSI interface.
> 
> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
> ---
>  .../net/wireless/qcom,ath12k-wsi.yaml         | 205 ++++++++++++++++++
>  1 file changed, 205 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-wsi.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-wsi.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-wsi.yaml
> new file mode 100644
> index 000000000000..7fec15e10a94
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-wsi.yaml

Usually I'd comment on the mismatch between this and the compatible, but
naming the file after the pcie id would do noone any favours. This seems
fine to me,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]