From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AA32250C1F for ; Fri, 21 Feb 2025 19:00:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740164449; cv=none; b=DzMsxrbc7RFX7+OAD5gj4miy3DF2hdu4kcuNvo2GT86CO1cZDn+0CnL6xoQSts6zU+LWKSN77JKuNaVqC3X1n8SseNSLSvTAXHZMwEJgroHNHlyPq6z20wj7Bj6d3NwhFLthk3JY4JteSm/LUhCByYzIzRDE7n3VYSu4VRVlQmE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740164449; c=relaxed/simple; bh=8DcTK+BWqvLFgfUlFyhU8LrkRaYzJUE29H3MUIQ1fWs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=maQKEAtpx4PgCdgH5mEgPhwzPFvm+utKa/hKdsIgZXwLeGbKt0BRK3RGQ3L3h5NRl/OwCW22ehxNkq/cj/9wHfSGIucojaV4YdXg+gmJoyT49jrNDYpWrzcUWP+hYQTzpIPsQHQ+yPTuMCmcnogPAuiuR94jYhcTa6WF0JqtNvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b=UNYvQFMm; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b="UNYvQFMm" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-221050f3f00so56563335ad.2 for ; Fri, 21 Feb 2025 11:00:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1740164445; x=1740769245; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=77hh0wQ+sFBBrkK6MEd/a6yvUwrcItGhllYO30mC8s0=; b=UNYvQFMm8ipUKK4diYQfDub/mJ3b9O2f8Chy60VevlYCmcNPan3W66AyRVIA6wmHxj sEdXQvtj4pUx/R+o/c+9Zmw89vLM6qGHXoczVYe/kus4+VnTjeJqo+ISOq5INGRV0add 81hc29lvOOsp3WQW7s36p2Duld12MGGM3TexmriVIleBupxJSOy6Al3Ql+53xA39jkAm tQzBJ5C2lr01f30oCQlgv9W7TdqF81kI7Go8YQ7NMuL+vxuNhMzx0DOGJQ7rvDh4FUnV XCi9V8cVRDRleYhP/B6LzIiZc5tevohGrxttxwEdHxmKo7ox8fUQiKFYEXmpgPzY9T2p XsfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740164445; x=1740769245; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=77hh0wQ+sFBBrkK6MEd/a6yvUwrcItGhllYO30mC8s0=; b=Xw7trX022uYLCyAKWP+MsEprhDiXfTY8zsbZpmTw0Cktdo2PIOuQ/0Y85A3tiZLEgK Hoq0IJNXVAPfkdj5oYISrMzG6p47MkNeV/vZqiVpjOHVV+yqqS3TDPfNIwEIPkELgh1N McVpRNV6fJbj4jDu8aCOJyN5gXgv8bVY5aUbgfWR8Rp/TjgIYC1zJ1n+G2vD9aovhWu5 NG+EJ2KFPGg45TSWUTA21QjV+ktmWDlnW6HSBLX5jiGb/J18NWy4USjn9/55Vas73Xzo f72XU7H8C2NUJA+/OhARHKSZeGA2py318ZK3jZhtqCyZHpLBknKYhu/vSUFP0Z3B/0u8 8MKg== X-Forwarded-Encrypted: i=1; AJvYcCW4dsMPszfYUFYgqaaa4ZbDmGePFJtVrE7+QuG8O1OnasH9i25+UwxfOJTQz7eC9JpKCAOBg0GCV5OKs8jk6Q==@vger.kernel.org X-Gm-Message-State: AOJu0YxFTRSpMDGDNFcWICRp4kvXSbfi0Esof81xZ3KJ/bpqdVdir8ic F80hLMsMI5KW52i5abCPyU2mq9fsWPHxiFZyULoSA84dy4K8hgV9J96/PXff5bo= X-Gm-Gg: ASbGncsS1o9V7Twz+cdArU69jMM6b87sY5MYe+BSxrsNeP4EJdJ+8yjF+1k3hLC1n7k ykPaTI0nlMSnW2uEqUIXm8fVguzIW6lSu8w8ZJu709td0sd5WCUGlj7Ic0ruDywOWXR5l7clI7z cnB8pPWWn4THJb+jHSmOgMh8lt/sXXLmrMgTQ7ZSkKHJ6tfb2vHW54FJA1c+W8ORBviOoSlUVDR nELYKB+sxLpEX7e9FGKdmKVUjKiDvyKBU9D4YzmqV/TAtGXhyVWL3dY1sX/bVp8Exxh6xLRynag 5duMLpJs3RMX6aVk9XgnwdA9Lc/6XZWGWQjp1hcQkJXzUDWPdLv5Bmf0LBvsD+TbR+IeDjgzadP p9pI= X-Google-Smtp-Source: AGHT+IGGJurj1ywGFGfMqLad+W4V0w/HWPMlDvnZ5WiNoOtzbXCiXiC9jiI+n/maSmmLogJdgVe5uw== X-Received: by 2002:a17:903:2346:b0:21f:6fb9:9299 with SMTP id d9443c01a7336-2219ff5e7c8mr68299995ad.27.1740164445571; Fri, 21 Feb 2025 11:00:45 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d5364676sm141352715ad.82.2025.02.21.11.00.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2025 11:00:45 -0800 (PST) Date: Fri, 21 Feb 2025 11:00:42 -0800 From: Stephen Hemminger To: Zijun Hu Cc: Greg Kroah-Hartman , Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Arnd Bergmann , Thomas Gleixner , Herbert Xu , "David S. Miller" , "Rafael J. Wysocki" , "Danilo Krummrich" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , Simon Horman , Johannes Berg , "Jamal Hadi Salim" , Cong Wang , Jiri Pirko , Jason Gunthorpe , Leon Romanovsky , Linus Walleij , "Bartosz Golaszewski" , Lee Jones , Thomas Graf , Christoph Hellwig , Marek Szyprowski , Robin Murphy , "Miquel Raynal" , Richard Weinberger , Vignesh Raghavendra , Zijun Hu , , , , , , , , , , , Subject: Re: [PATCH *-next 00/18] Remove weird and needless 'return' for void APIs Message-ID: <20250221110042.2ec3c276@hermes.local> In-Reply-To: <20250221-rmv_return-v1-0-cc8dff275827@quicinc.com> References: <20250221-rmv_return-v1-0-cc8dff275827@quicinc.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 21 Feb 2025 05:02:05 -0800 Zijun Hu wrote: > This patch series is to remove weird and needless 'return' for > void APIs under include/ with the following pattern: > > api_header.h: > > void api_func_a(...); > > static inline void api_func_b(...) > { > return api_func_a(...); > } > > Remove the needless 'return' in api_func_b(). > > Signed-off-by: Zijun Hu > --- > Zijun Hu (18): > mm/mmu_gather: Remove needless return in void API tlb_remove_page() > cpu: Remove needless return in void API suspend_enable_secondary_cpus() > crypto: api - Remove needless return in void API crypto_free_tfm() > crypto: scomp - Remove needless return in void API crypto_scomp_free_ctx() > sysfs: Remove needless return in void API sysfs_enable_ns() > skbuff: Remove needless return in void API consume_skb() > wifi: mac80211: Remove needless return in void API _ieee80211_hw_set() > net: sched: Remove needless return in void API qdisc_watchdog_schedule_ns() > ipv4/igmp: Remove needless return in void API ip_mc_dec_group() > IB/rdmavt: Remove needless return in void API rvt_mod_retry_timer() > ratelimit: Remove needless return in void API ratelimit_default_init() > siox: Remove needless return in void API siox_driver_unregister() > gpiolib: Remove needless return in two void APIs > PM: wakeup: Remove needless return in three void APIs > mfd: db8500-prcmu: Remove needless return in three void APIs > rhashtable: Remove needless return in three void APIs > dma-mapping: Remove needless return in five void APIs > mtd: nand: Do not return void function in void function > > include/asm-generic/tlb.h | 2 +- > include/crypto/internal/scompress.h | 2 +- > include/linux/cpu.h | 2 +- > include/linux/crypto.h | 2 +- > include/linux/dma-mapping.h | 12 ++++++------ > include/linux/gpio.h | 4 ++-- > include/linux/igmp.h | 2 +- > include/linux/mfd/dbx500-prcmu.h | 6 +++--- > include/linux/mtd/nand.h | 18 ++++++++++++------ > include/linux/pm_wakeup.h | 6 +++--- > include/linux/ratelimit.h | 4 ++-- > include/linux/rhashtable.h | 6 +++--- > include/linux/siox.h | 2 +- > include/linux/skbuff.h | 2 +- > include/linux/sysfs.h | 2 +- > include/net/mac80211.h | 2 +- > include/net/pkt_sched.h | 2 +- > include/rdma/rdmavt_qp.h | 2 +- > 18 files changed, 42 insertions(+), 36 deletions(-) > --- > base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b > change-id: 20250221-rmv_return-f1dc82d492f0 > > Best regards, Is this something that could be done with a coccinelle script?