* [PATCH] wifi: rtw88: Add __nonstring annotations for unterminated strings
@ 2025-03-10 22:22 Kees Cook
2025-03-13 1:28 ` Ping-Ke Shih
0 siblings, 1 reply; 2+ messages in thread
From: Kees Cook @ 2025-03-10 22:22 UTC (permalink / raw)
To: Ping-Ke Shih
Cc: Kees Cook, Johannes Berg, linux-wireless, linux-kernel,
linux-hardening
When a character array without a terminating NUL character has a static
initializer, GCC 15's -Wunterminated-string-initialization will only
warn if the array lacks the "nonstring" attribute[1]. Mark the arrays
with __nonstring to and correctly identify the char array as "not a C
string" and thereby eliminate the warning.
Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117178 [1]
Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Signed-off-by: Kees Cook <kees@kernel.org>
---
drivers/net/wireless/realtek/rtw88/main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/main.h b/drivers/net/wireless/realtek/rtw88/main.h
index 62cd4c526301..5d6df6b51698 100644
--- a/drivers/net/wireless/realtek/rtw88/main.h
+++ b/drivers/net/wireless/realtek/rtw88/main.h
@@ -822,7 +822,7 @@ struct rtw_vif {
};
struct rtw_regulatory {
- char alpha2[2];
+ char alpha2[2] __nonstring;
u8 txpwr_regd_2g;
u8 txpwr_regd_5g;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wifi: rtw88: Add __nonstring annotations for unterminated strings
2025-03-10 22:22 [PATCH] wifi: rtw88: Add __nonstring annotations for unterminated strings Kees Cook
@ 2025-03-13 1:28 ` Ping-Ke Shih
0 siblings, 0 replies; 2+ messages in thread
From: Ping-Ke Shih @ 2025-03-13 1:28 UTC (permalink / raw)
To: Kees Cook, Ping-Ke Shih
Cc: Kees Cook, Johannes Berg, linux-wireless, linux-kernel,
linux-hardening
Kees Cook <kees@kernel.org> wrote:
> When a character array without a terminating NUL character has a static
> initializer, GCC 15's -Wunterminated-string-initialization will only
> warn if the array lacks the "nonstring" attribute[1]. Mark the arrays
> with __nonstring to and correctly identify the char array as "not a C
> string" and thereby eliminate the warning.
>
> Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117178 [1]
> Cc: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: linux-wireless@vger.kernel.org
> Signed-off-by: Kees Cook <kees@kernel.org>
1 patch(es) applied to rtw-next branch of rtw.git, thanks.
d58ad77d5cc2 wifi: rtw88: Add __nonstring annotations for unterminated strings
---
https://github.com/pkshih/rtw.git
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-13 1:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-10 22:22 [PATCH] wifi: rtw88: Add __nonstring annotations for unterminated strings Kees Cook
2025-03-13 1:28 ` Ping-Ke Shih
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).