* [PATCH v2] wifi: mt76: mt7925: fix the incomplete revert of [tx,rx]_ba for MLO
@ 2025-03-14 9:06 Mingyen Hsieh
2025-03-14 12:25 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Mingyen Hsieh @ 2025-03-14 9:06 UTC (permalink / raw)
To: nbd, lorenzo
Cc: deren.wu, Sean.Wang, Leon.Yen, Michael.Lo, allan.wang,
Eric-SY.Chang, km.lin, Quan.Zhou, Ryder.Lee, Shayne.Chen,
linux-wireless, linux-mediatek, Ming Yen Hsieh, stable
From: Ming Yen Hsieh <mingyen.hsieh@mediatek.com>
Since the `Revert "wifi: mt76: mt7925: Update mt7925_mcu_uni_[tx,rx]_ba for MLO"`
was not completely clean, submit this patch to fully clean it up.
Cc: stable@vger.kernel.org
Fixes: 73915469c55a ("Revert "wifi: mt76: mt7925: Update mt7925_mcu_uni_[tx,rx]_ba for MLO"")
Change-Id: I2d851e6b79905baae35f691578bf50d56ad0adbf
Signed-off-by: Ming Yen Hsieh <mingyen.hsieh@mediatek.com>
---
v2: rewrite the subject
---
drivers/net/wireless/mediatek/mt76/mt7925/mcu.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
index 1ecba46d770d..1bdc313844c4 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
@@ -572,10 +572,10 @@ void mt7925_mcu_rx_event(struct mt792x_dev *dev, struct sk_buff *skb)
static int
mt7925_mcu_sta_ba(struct mt76_dev *dev, struct mt76_vif_link *mvif,
- struct mt76_wcid *wcid,
struct ieee80211_ampdu_params *params,
bool enable, bool tx)
{
+ struct mt76_wcid *wcid = (struct mt76_wcid *)params->sta->drv_priv;
struct sta_rec_ba_uni *ba;
struct sk_buff *skb;
struct tlv *tlv;
@@ -608,13 +608,12 @@ int mt7925_mcu_uni_tx_ba(struct mt792x_dev *dev,
{
struct mt792x_sta *msta = (struct mt792x_sta *)params->sta->drv_priv;
struct mt792x_vif *mvif = msta->vif;
- struct mt76_wcid *wcid = &mvif->sta.deflink.wcid;
if (enable && !params->amsdu)
msta->deflink.wcid.amsdu = false;
- return mt7925_mcu_sta_ba(&dev->mt76, &mvif->bss_conf.mt76, wcid,
- params, enable, true);
+ return mt7925_mcu_sta_ba(&dev->mt76, &mvif->bss_conf.mt76, params,
+ enable, true);
}
int mt7925_mcu_uni_rx_ba(struct mt792x_dev *dev,
@@ -623,10 +622,9 @@ int mt7925_mcu_uni_rx_ba(struct mt792x_dev *dev,
{
struct mt792x_sta *msta = (struct mt792x_sta *)params->sta->drv_priv;
struct mt792x_vif *mvif = msta->vif;
- struct mt76_wcid *wcid = &mvif->sta.deflink.wcid;
- return mt7925_mcu_sta_ba(&dev->mt76, &mvif->bss_conf.mt76, wcid,
- params, enable, false);
+ return mt7925_mcu_sta_ba(&dev->mt76, &mvif->bss_conf.mt76, params,
+ enable, false);
}
static int mt7925_mcu_read_eeprom(struct mt792x_dev *dev, u32 offset, u8 *val)
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] wifi: mt76: mt7925: fix the incomplete revert of [tx,rx]_ba for MLO
2025-03-14 9:06 [PATCH v2] wifi: mt76: mt7925: fix the incomplete revert of [tx,rx]_ba for MLO Mingyen Hsieh
@ 2025-03-14 12:25 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2025-03-14 12:25 UTC (permalink / raw)
To: Mingyen Hsieh
Cc: nbd, lorenzo, deren.wu, Sean.Wang, Leon.Yen, Michael.Lo,
allan.wang, Eric-SY.Chang, km.lin, Quan.Zhou, Ryder.Lee,
Shayne.Chen, linux-wireless, linux-mediatek, stable
On Fri, Mar 14, 2025 at 05:06:54PM +0800, Mingyen Hsieh wrote:
> From: Ming Yen Hsieh <mingyen.hsieh@mediatek.com>
>
> Since the `Revert "wifi: mt76: mt7925: Update mt7925_mcu_uni_[tx,rx]_ba for MLO"`
> was not completely clean, submit this patch to fully clean it up.
>
> Cc: stable@vger.kernel.org
> Fixes: 73915469c55a ("Revert "wifi: mt76: mt7925: Update mt7925_mcu_uni_[tx,rx]_ba for MLO"")
> Change-Id: I2d851e6b79905baae35f691578bf50d56ad0adbf
Please always run scripts/checkpatch.pl before submitting changes :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-14 12:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-14 9:06 [PATCH v2] wifi: mt76: mt7925: fix the incomplete revert of [tx,rx]_ba for MLO Mingyen Hsieh
2025-03-14 12:25 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).