* [PATCH] wifi: rt2x00: remove weird self-assignment in rt2800_loft_search()
@ 2025-03-21 13:42 Dmitry Antipov
2025-03-22 13:18 ` Stanislaw Gruszka
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Antipov @ 2025-03-21 13:42 UTC (permalink / raw)
To: Stanislaw Gruszka
Cc: Daniel Golle, Kalle Valo, linux-wireless, lvc-patches,
Dmitry Antipov
Remove weird self-assignment in 'rt2800_loft_search()' assuming
that it was just a typo. Compile tested only.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
---
drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
index e5f553a1ea24..b7ea606bda08 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
@@ -9393,7 +9393,7 @@ static void rt2800_loft_search(struct rt2x00_dev *rt2x00dev, u8 ch_idx,
p0, p1, pf, idx0, idx1, ibit);
if (bidx != 5 && pf <= p0 && pf < p1) {
- idxf[iorq] = idxf[iorq];
+ /* no need to adjust idxf[] */;
} else if (p0 < p1) {
pf = p0;
idxf[iorq] = idx0 & 0x3F;
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wifi: rt2x00: remove weird self-assignment in rt2800_loft_search()
2025-03-21 13:42 [PATCH] wifi: rt2x00: remove weird self-assignment in rt2800_loft_search() Dmitry Antipov
@ 2025-03-22 13:18 ` Stanislaw Gruszka
0 siblings, 0 replies; 2+ messages in thread
From: Stanislaw Gruszka @ 2025-03-22 13:18 UTC (permalink / raw)
To: Dmitry Antipov; +Cc: Daniel Golle, Kalle Valo, linux-wireless, lvc-patches
On Fri, Mar 21, 2025 at 04:42:56PM +0300, Dmitry Antipov wrote:
> Remove weird self-assignment in 'rt2800_loft_search()' assuming
> that it was just a typo. Compile tested only.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
> ---
> drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> index e5f553a1ea24..b7ea606bda08 100644
> --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> @@ -9393,7 +9393,7 @@ static void rt2800_loft_search(struct rt2x00_dev *rt2x00dev, u8 ch_idx,
> p0, p1, pf, idx0, idx1, ibit);
>
> if (bidx != 5 && pf <= p0 && pf < p1) {
> - idxf[iorq] = idxf[iorq];
> + /* no need to adjust idxf[] */;
> } else if (p0 < p1) {
> pf = p0;
> idxf[iorq] = idx0 & 0x3F;
> --
> 2.49.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-22 13:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-21 13:42 [PATCH] wifi: rt2x00: remove weird self-assignment in rt2800_loft_search() Dmitry Antipov
2025-03-22 13:18 ` Stanislaw Gruszka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).