public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Chris Bainbridge <chris.bainbridge@gmail.com>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"kvalo@kernel.org" <kvalo@kernel.org>,
	"Korenblit, Miriam Rachel" <miriam.rachel.korenblit@intel.com>,
	"Berg, Johannes" <johannes.berg@intel.com>,
	"benjamin@sipsolutions.net" <benjamin@sipsolutions.net>,
	"regressions@lists.linux.dev" <regressions@lists.linux.dev>
Subject: Re: [REGRESSION] iwlwifi: suspend failure, bisected
Date: Wed, 16 Jul 2025 13:50:57 -0500	[thread overview]
Message-ID: <20250716185057.GA2548435@bhelgaas> (raw)
In-Reply-To: <aDsNn70jcX6sDLLT@debian.local>

On Sat, May 31, 2025 at 03:09:35PM +0100, Chris Bainbridge wrote:
> Hi,
> 
> There is a recently introduced iwlwifi regression on suspend. It appears
> the bisected commit was only supposed to fix a warning, but reverting
> the commit (with a small change for revert conflict) does fix the error.
> 
> 7438843df8cf7a484303caee7540a00f0ef972b2 is the first bad commit
> Gustavo A. R. Silva <gustavoars@kernel.org>commit 7438843df8cf7a484303caee7540a00f0ef972b2
> Author: Gustavo A. R. Silva <gustavoars@kernel.org>
> Date:   Wed Mar 26 18:04:02 2025 -0600
> 
>     wifi: iwlwifi: mvm: Avoid -Wflex-array-member-not-at-end warning

https://git.kernel.org/linus/264c844abb29 ("wifi: iwlwifi: mvm: fix
assert on suspend") appeared in v6.16-rc1 and includes a Fixes: tag
for 7438843df8cf.

264c844abb29 is not exactly the same as the patch Miri posted at
https://lore.kernel.org/r/DM3PPF63A6024A9ECC64ACBA27CCABBAB0FA360A@DM3PPF63A6024A9.namprd11.prod.outlook.com,
but maybe it still fixes this regression?

If so, can somebody send the appropriate regzbot fix command to remove
this regression from the tracker
(https://linux-regtracking.leemhuis.info/regzbot/mainline/)?

(See https://linux-regtracking.leemhuis.info/about/#tldr)

I feel like I might be missing something because there are several
regressions in the tracker that *look* like they should have been
resolved months ago.

Bjorn

  parent reply	other threads:[~2025-07-16 18:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-31 14:09 [REGRESSION] iwlwifi: suspend failure, bisected Chris Bainbridge
2025-05-31 18:35 ` Korenblit, Miriam Rachel
2025-05-31 19:48   ` Chris Bainbridge
2025-05-31 20:07     ` Korenblit, Miriam Rachel
2025-05-31 21:16       ` Chris Bainbridge
2025-07-16 18:50 ` Bjorn Helgaas [this message]
2025-07-22 11:23   ` Chris Bainbridge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250716185057.GA2548435@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=benjamin@sipsolutions.net \
    --cc=chris.bainbridge@gmail.com \
    --cc=gustavoars@kernel.org \
    --cc=johannes.berg@intel.com \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=miriam.rachel.korenblit@intel.com \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox