From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Yunseong Kim <ysk@kzalloc.com>
Cc: "Johannes Berg" <johannes.berg@intel.com>,
"Clark Williams" <clrkwllms@kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Jiri Kosina" <jkosina@suse.cz>,
"Aaron Hill" <aa1ronham@gmail.com>,
"Lukas Redlinger" <rel+kernel@agilox.net>,
"Oleksii Shevchuk" <alxchk@gmail.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
linux-wireless@vger.kernel.org, linux-rt-devel@lists.linux.dev,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] mac80211: Potential sleep in atomic context in __ieee80211_wake_txqs
Date: Tue, 19 Aug 2025 12:10:04 +0200 [thread overview]
Message-ID: <20250819101004.KB4KbEO-@linutronix.de> (raw)
In-Reply-To: <c15a819a-51de-467c-93fd-c321dd2e8ec9@kzalloc.com>
On 2025-08-19 01:56:00 [+0900], Yunseong Kim wrote:
> Hi,
Hi,
> I found a potential PREEMPT_RT issue I noticed in __ieee80211_wake_txqs()
>
> static void __ieee80211_wake_txqs(struct ieee80211_sub_if_data *sdata, int ac)
> {
> ...
> local_bh_disable();
> spin_lock(&fq->lock);
> ...
> }
>
> This sequence of local_bh_disable() followed by spin_lock(). On an
As explained in the previous mail regarding for
inet_twsk_hashdance_schedule(), this is fine.
> Best regards,
> Yunseong Kim
Sebastian
prev parent reply other threads:[~2025-08-19 10:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 16:56 [RFC] mac80211: Potential sleep in atomic context in __ieee80211_wake_txqs Yunseong Kim
2025-08-19 10:10 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250819101004.KB4KbEO-@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=aa1ronham@gmail.com \
--cc=alxchk@gmail.com \
--cc=clrkwllms@kernel.org \
--cc=jkosina@suse.cz \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=linux-wireless@vger.kernel.org \
--cc=rel+kernel@agilox.net \
--cc=rostedt@goodmis.org \
--cc=toke@redhat.com \
--cc=ysk@kzalloc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).