From: Alexander Wilhelm <alexander.wilhelm@westermo.com>
To: Jeff Johnson <jjohnson@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: [PATCH v2 0/4] wifi: ath12k: Fix endianness handling in QMI
Date: Tue, 26 Aug 2025 09:20:03 +0200 [thread overview]
Message-ID: <20250826072007.1395416-1-alexander.wilhelm@westermo.com> (raw)
Fix endianness handling in QMI firmware transfer on big-endian
platforms. Without this fix, the firmware download fails due to
misinterpreted data structures exchanged between the host and the
wireless module.
The issue occurs during early bring-up on big endian systems, where QMI
messages are not correctly parsed by the driver, leading to failed
initialization sequences. Ensure all relevant fields are properly
converted between CPU and little-endian format in request and response
messages, as expected by the firmware. Attached logs showing the failure
before the fix:
ath12k_pci 0001:01:00.0: BAR 0: assigned [mem 0xc00000000-0xc001fffff 64bit]
ath12k_pci 0001:01:00.0: boot pci_mem 0xcd4148e9
ath12k_pci 0001:01:00.0: pci probe 17cb:1109 17cb:1109
ath12k_pci 0001:01:00.0: pci tcsr_soc_hw_version major 2 minor 0
ath12k_pci 0001:01:00.0: request MSI one vector
ath12k_pci 0001:01:00.0: MSI vectors: 1
ath12k_pci 0001:01:00.0: msi base data is 0
ath12k_pci 0001:01:00.0: Hardware name: qcn9274 hw2.0
ath12k_pci 0001:01:00.0: boot firmware request ath12k/QCN9274/hw2.0/firmware-2.bin size 15134776
ath12k_pci 0001:01:00.0: found fw timestamp 1722934582
ath12k_pci 0001:01:00.0: found m3 image ie (421880 B)
ath12k_pci 0001:01:00.0: found fw image ie (7229440 B)
ath12k_pci 0001:01:00.0: found dualmac fw image ie (7483392 B)
ath12k_pci 0001:01:00.0: found firmware features ie (1 B)
ath12k_pci 0001:01:00.0: features
ath12k_pci 0001:01:00.0: using fw api 2
ath12k_pci 0001:01:00.0: dualmac fw selected for board id: 1005
ath12k_pci 0001:01:00.0: Assign MSI to user: MHI, num_vectors: 3, user_base_data: 0, base_vector: 0
ath12k_pci 0001:01:00.0: Number of assigned MSI for MHI is 3, base vector is 0
ath12k_pci 0001:01:00.0: Assign MSI to user: CE, num_vectors: 1, user_base_data: 0, base_vector: 0
ath12k_pci 0001:01:00.0: Assign MSI to user: DP, num_vectors: 1, user_base_data: 0, base_vector: 0
ath12k_pci 0001:01:00.0: irq:18 group:0
ath12k_pci 0001:01:00.0: irq:18 group:1
ath12k_pci 0001:01:00.0: irq:18 group:2
ath12k_pci 0001:01:00.0: irq:18 group:3
ath12k_pci 0001:01:00.0: irq:18 group:4
ath12k_pci 0001:01:00.0: irq:18 group:5
ath12k_pci 0001:01:00.0: irq:18 group:6
ath12k_pci 0001:01:00.0: irq:18 group:7
ath12k_pci 0001:01:00.0: pci after request_irq msi_ep_base_data 0
ath12k_pci 0001:01:00.0: cookie:0x0
ath12k_pci 0001:01:00.0: WLAON_WARM_SW_ENTRY 0x2
ath12k_pci 0001:01:00.0: WLAON_WARM_SW_ENTRY 0x2
ath12k_pci 0001:01:00.0: soc reset cause:0
ath12k_pci 0001:01:00.0: MHISTATUS 0xff04
ath12k_pci 0001:01:00.0: pci link_ctl 0x0000 L0s 0 L1 0
ath12k_pci 0001:01:00.0: pci reg 0x3164 instance 0x11 read val 0x11
ath12k_pci 0001:01:00.0: setting mhi state: INIT(0)
ath12k_pci 0001:01:00.0: setting mhi state: POWER_ON(2)
ath12k_pci 0001:01:00.0: mhi notify status reason UNKNOWN
ath12k_pci 0001:01:00.0: mhi notify status reason MHI_CB_EE_MISSION_MODE
ath12k_pci 0001:01:00.0: qmi wifi fw qmi service connected
ath12k_pci 0001:01:00.0: phy capability resp valid 1 num_phy 2 valid 1 board_id 84934656 valid 1 single_chip_mlo_support 0
ath12k_pci 0001:01:00.0: intra device MLO is disabled hence skip QMI MLO cap
---
Changes in v2:
- Handle QMI conversion within the QMI subsystem instead of the driver.
Alexander Wilhelm (4):
soc: qcom: introduce generic QMI encoding/decoding macros
soc: qcom: fix QMI encoding/decoding for basic elements
soc: qcom: preserve CPU endianness for QMI_DATA_LEN
wifi: ath12k: enforce CPU-endian format for all QMI messages
drivers/net/wireless/ath/ath12k/qmi.c | 24 ++++++---
drivers/net/wireless/ath/ath12k/qmi.h | 16 +++---
drivers/soc/qcom/qmi_encdec.c | 74 ++++++++++++++++++++-------
3 files changed, 79 insertions(+), 35 deletions(-)
--
2.34.1
next reply other threads:[~2025-08-26 7:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 7:20 Alexander Wilhelm [this message]
2025-08-26 7:20 ` [PATCH v2 1/4] soc: qcom: introduce generic QMI encoding/decoding macros Alexander Wilhelm
2025-08-26 7:20 ` [PATCH v2 2/4] soc: qcom: fix QMI encoding/decoding for basic elements Alexander Wilhelm
2025-08-26 7:20 ` [PATCH v2 3/4] soc: qcom: preserve CPU endianness for QMI_DATA_LEN Alexander Wilhelm
2025-08-26 7:20 ` [PATCH v2 4/4] wifi: ath12k: enforce CPU-endian format for all QMI messages Alexander Wilhelm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250826072007.1395416-1-alexander.wilhelm@westermo.com \
--to=alexander.wilhelm@westermo.com \
--cc=andersson@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).