From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBDE82D7DEA for ; Tue, 16 Sep 2025 04:48:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757998112; cv=none; b=PygzO4W0RD3XDdrPnzxFqp8oVvGC3lnCgH8rfLiQ37rkXgxATpO556ks8Iv0XjQSNdAKtwRROHE2Z1dzpv78HMxbjZPwYj7M0XUDhYI+AsAS6yPCg2SsnhhHA/6FNwmaL0gLIigHV6XvvsOo8Pq2r1mW2mUo7zZTh7hOOj9cNUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757998112; c=relaxed/simple; bh=ja+bbJPbRSrQwDXA6/q8IikecZ6d8Rw7OMDfeYI0NFk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cNAs1qdo926uQY2tJ0QFNJ8YmgGOFhETin3hnfhBMWb2HqIBMrqG0VmQXwKt73DGZDxy4ZRopEf9cCFMd3ZdvH+yTyb1l2j33fbZ5PNxlwaypl33QZOS7GvqrSmhdhVeKq8iSkmTfNkX7AAAqkbKmtZ0A5iq7aVl4aY2VFTrB8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Fkm2iDgr; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fkm2iDgr" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-267a5aeb9f1so9129555ad.1 for ; Mon, 15 Sep 2025 21:48:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757998108; x=1758602908; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E4GnwUXvg4e1SjHBDj7IOnsANmiVf/8g2S4TikZ2k4g=; b=Fkm2iDgrcPVBuaesrw7FvVYaF9dMzh7OYHeK4JX3EgxQ++R33RT7gwSxXKWspg2bZz 5FOFvJ9AkTWPvAhIegP4B+Vj0Gy+5liVRyC8yoicuKPE5FKhfmFF8b8qV0G+MVzpCmms 4qfEPXAE3lymVWIuTtXVTadXIAI1bFHNZBRgjs69h3p8XbsTTNKEC7MjRXJjx38eAhgc zaoIwDnkLZSXNeCZxzCz630o7NNmGpGKTQrdgbdy1CKScwc/89o++bjOv83NkYZeXeTq FO51pCkeizUOyu86k/oKP//hAvAEpA9Za35Q8X5WtgOWGeoJmw9MQI/icPPvrJpZWAX+ n2Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757998108; x=1758602908; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E4GnwUXvg4e1SjHBDj7IOnsANmiVf/8g2S4TikZ2k4g=; b=eaeiXtzs8O/7Cd6iq8XcZL3w+Avjt6WcxoRYRTciZBgm3ersFyIdNNJun21j+zo3fc UrF8Fe5tVG4MWtOXw5HXPyDZMQ5gYJC8U+3Cr8gy2Iv19Be/lmI3OJwtlQTNvIcuuLUX RolbA21T7v161OG5suYJ3P2j5PDF+pDZeY/XUXcqE1MbK3Y95NA1pYtvMnPWpiu9nCkp S7sOIOobCASUAytpxufD4R9JPhlP5FL0Pn968CRJsqyNS3pSbqbVwQYNGELVjXuQBp2A 2ofo/Djw22mjydUThNRzl6w0JIsjKQYrfyrX7dJ5a0NpQMKtOduWzMdlEeBB2GQxPguB s9OQ== X-Forwarded-Encrypted: i=1; AJvYcCV+vG/LRwPrKbwUNzJc/xtxDyO3Lha5tjPugIUZ/T8vbhmzOM8fSQ5OQUUxd7H9DW8S1cu/efqg76t+O/DQWw==@vger.kernel.org X-Gm-Message-State: AOJu0YxN31dgcmAKZSp0NIpjR/nSqpxfErSktA71DqPLIVpiB2faqICt vLUMPCGTt3KvEALzr9qm8GPa7/Od+Vjc3sLbCjgGx38pyBrMT8uZR4Be X-Gm-Gg: ASbGncvKzijyIY6fgevP/MsxuFV0b/mV6gvXuqANJxA/chJJLLRkWGxvBybIG8aTDkB cv0cQ8TOk5zq4w31Jyo7SxBlTQC6ANIw9GXiC3z4AoZUdiDczUvBd2yCZmIlWGd9ul/yo4WEi+P jpDfdE4Ac3rGeSnmFrcB+z0Yr5R8w4vNbWcfXnHaY6xSIHHk8eX4caODmKBJD+eNYPAd+lsq+Zb /+ZcbZEjpMuEciHOocpMlXywjXKgqjwuuofRCUFFT5oEXTxSqK+NNMBya6D7So/+XDkqB0x9lXK ztZDRtB0lKWOl2aNK94YZ+pT9CVAIy75xMZ5ppWBWx9EubpF3buEeeqH2eURG9V/yxQ56g1DB+c XT1TeQNAopC6+vILjZFlj0TvV/xcZggruq6rODQM= X-Google-Smtp-Source: AGHT+IEX+DuJO9pqL+sh6jlOJbx2wPh/MnPUcew7z+h1RxAPsxkAl191gDKewoy1JkBZ+L5tKb1L0g== X-Received: by 2002:a17:902:ec8e:b0:25d:d848:1cca with SMTP id d9443c01a7336-25dd8481fbdmr195481725ad.35.1757998107572; Mon, 15 Sep 2025 21:48:27 -0700 (PDT) Received: from pengdl-pc.mioffice.cn ([43.224.245.249]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-25ef09c77f8sm104600605ad.15.2025.09.15.21.48.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 21:48:27 -0700 (PDT) From: pengdonglin To: tj@kernel.org, tony.luck@intel.com, jani.nikula@linux.intel.com, ap420073@gmail.com, jv@jvosburgh.net, freude@linux.ibm.com, bcrl@kvack.org, trondmy@kernel.org, longman@redhat.com, kees@kernel.org Cc: bigeasy@linutronix.de, hdanton@sina.com, paulmck@kernel.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-nfs@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-wireless@vger.kernel.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, cgroups@vger.kernel.org, pengdonglin , Joonas Lahtinen , Tvrtko Ursulin , pengdonglin Subject: [PATCH v3 02/14] drm/i915/gt: Remove redundant rcu_read_lock/unlock() in spin_lock Date: Tue, 16 Sep 2025 12:47:23 +0800 Message-Id: <20250916044735.2316171-3-dolinux.peng@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250916044735.2316171-1-dolinux.peng@gmail.com> References: <20250916044735.2316171-1-dolinux.peng@gmail.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: pengdonglin Since commit a8bb74acd8efe ("rcu: Consolidate RCU-sched update-side function definitions") there is no difference between rcu_read_lock(), rcu_read_lock_bh() and rcu_read_lock_sched() in terms of RCU read section and the relevant grace period. That means that spin_lock(), which implies rcu_read_lock_sched(), also implies rcu_read_lock(). There is no need no explicitly start a RCU read section if one has already been started implicitly by spin_lock(). Simplify the code and remove the inner rcu_read_lock() invocation. Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Signed-off-by: pengdonglin Signed-off-by: pengdonglin --- drivers/gpu/drm/i915/gt/intel_ring_submission.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c index 2a6d79abf25b..bf73166a1337 100644 --- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c +++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c @@ -392,14 +392,12 @@ static void reset_rewind(struct intel_engine_cs *engine, bool stalled) rq = NULL; spin_lock_irqsave(&engine->sched_engine->lock, flags); - rcu_read_lock(); list_for_each_entry(pos, &engine->sched_engine->requests, sched.link) { if (!__i915_request_is_complete(pos)) { rq = pos; break; } } - rcu_read_unlock(); /* * The guilty request will get skipped on a hung engine. -- 2.34.1