* [PATCH v2 RESEND 0/4] wifi: ath12k: Fix endianness handling in QMI
@ 2025-09-17 7:04 Alexander Wilhelm
2025-09-17 7:04 ` [PATCH v2 RESEND 1/4] soc: qcom: introduce generic QMI encoding/decoding macros Alexander Wilhelm
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Alexander Wilhelm @ 2025-09-17 7:04 UTC (permalink / raw)
To: Jeff Johnson, Bjorn Andersson, Konrad Dybcio
Cc: linux-wireless, ath12k, linux-kernel, linux-arm-msm
Fix endianness handling in QMI firmware transfer on big-endian
platforms. Without this fix, the firmware download fails due to
misinterpreted data structures exchanged between the host and the
wireless module.
The issue occurs during early bring-up on big endian systems, where QMI
messages are not correctly parsed by the driver, leading to failed
initialization sequences. Ensure all relevant fields are properly
converted between CPU and little-endian format in request and response
messages, as expected by the firmware. Attached logs showing the failure
before the fix:
ath12k_pci 0001:01:00.0: BAR 0: assigned [mem 0xc00000000-0xc001fffff 64bit]
ath12k_pci 0001:01:00.0: boot pci_mem 0xcd4148e9
ath12k_pci 0001:01:00.0: pci probe 17cb:1109 17cb:1109
ath12k_pci 0001:01:00.0: pci tcsr_soc_hw_version major 2 minor 0
ath12k_pci 0001:01:00.0: request MSI one vector
ath12k_pci 0001:01:00.0: MSI vectors: 1
ath12k_pci 0001:01:00.0: msi base data is 0
ath12k_pci 0001:01:00.0: Hardware name: qcn9274 hw2.0
ath12k_pci 0001:01:00.0: boot firmware request ath12k/QCN9274/hw2.0/firmware-2.bin size 15134776
ath12k_pci 0001:01:00.0: found fw timestamp 1722934582
ath12k_pci 0001:01:00.0: found m3 image ie (421880 B)
ath12k_pci 0001:01:00.0: found fw image ie (7229440 B)
ath12k_pci 0001:01:00.0: found dualmac fw image ie (7483392 B)
ath12k_pci 0001:01:00.0: found firmware features ie (1 B)
ath12k_pci 0001:01:00.0: features
ath12k_pci 0001:01:00.0: using fw api 2
ath12k_pci 0001:01:00.0: dualmac fw selected for board id: 1005
ath12k_pci 0001:01:00.0: Assign MSI to user: MHI, num_vectors: 3, user_base_data: 0, base_vector: 0
ath12k_pci 0001:01:00.0: Number of assigned MSI for MHI is 3, base vector is 0
ath12k_pci 0001:01:00.0: Assign MSI to user: CE, num_vectors: 1, user_base_data: 0, base_vector: 0
ath12k_pci 0001:01:00.0: Assign MSI to user: DP, num_vectors: 1, user_base_data: 0, base_vector: 0
ath12k_pci 0001:01:00.0: irq:18 group:0
ath12k_pci 0001:01:00.0: irq:18 group:1
ath12k_pci 0001:01:00.0: irq:18 group:2
ath12k_pci 0001:01:00.0: irq:18 group:3
ath12k_pci 0001:01:00.0: irq:18 group:4
ath12k_pci 0001:01:00.0: irq:18 group:5
ath12k_pci 0001:01:00.0: irq:18 group:6
ath12k_pci 0001:01:00.0: irq:18 group:7
ath12k_pci 0001:01:00.0: pci after request_irq msi_ep_base_data 0
ath12k_pci 0001:01:00.0: cookie:0x0
ath12k_pci 0001:01:00.0: WLAON_WARM_SW_ENTRY 0x2
ath12k_pci 0001:01:00.0: WLAON_WARM_SW_ENTRY 0x2
ath12k_pci 0001:01:00.0: soc reset cause:0
ath12k_pci 0001:01:00.0: MHISTATUS 0xff04
ath12k_pci 0001:01:00.0: pci link_ctl 0x0000 L0s 0 L1 0
ath12k_pci 0001:01:00.0: pci reg 0x3164 instance 0x11 read val 0x11
ath12k_pci 0001:01:00.0: setting mhi state: INIT(0)
ath12k_pci 0001:01:00.0: setting mhi state: POWER_ON(2)
ath12k_pci 0001:01:00.0: mhi notify status reason UNKNOWN
ath12k_pci 0001:01:00.0: mhi notify status reason MHI_CB_EE_MISSION_MODE
ath12k_pci 0001:01:00.0: qmi wifi fw qmi service connected
ath12k_pci 0001:01:00.0: phy capability resp valid 1 num_phy 2 valid 1 board_id 84934656 valid 1 single_chip_mlo_support 0
ath12k_pci 0001:01:00.0: intra device MLO is disabled hence skip QMI MLO cap
---
Changes in v2:
- Handle QMI conversion within the QMI subsystem instead of the driver.
Alexander Wilhelm (4):
soc: qcom: introduce generic QMI encoding/decoding macros
soc: qcom: fix QMI encoding/decoding for basic elements
soc: qcom: preserve CPU endianness for QMI_DATA_LEN
wifi: ath12k: enforce CPU-endian format for all QMI messages
drivers/net/wireless/ath/ath12k/qmi.c | 24 ++++++---
drivers/net/wireless/ath/ath12k/qmi.h | 16 +++---
drivers/soc/qcom/qmi_encdec.c | 74 ++++++++++++++++++++-------
3 files changed, 79 insertions(+), 35 deletions(-)
--
2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 RESEND 1/4] soc: qcom: introduce generic QMI encoding/decoding macros
2025-09-17 7:04 [PATCH v2 RESEND 0/4] wifi: ath12k: Fix endianness handling in QMI Alexander Wilhelm
@ 2025-09-17 7:04 ` Alexander Wilhelm
2025-09-17 7:04 ` [PATCH v2 RESEND 2/4] soc: qcom: fix QMI encoding/decoding for basic elements Alexander Wilhelm
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Alexander Wilhelm @ 2025-09-17 7:04 UTC (permalink / raw)
To: Jeff Johnson, Bjorn Andersson, Konrad Dybcio
Cc: linux-wireless, ath12k, linux-kernel, linux-arm-msm
These macros enable future support for encoding and decoding primitive data
types in a generic way. They handle host CPU endianness while ensuring
little-endian format on the QMI wire, as required by the protocol.
Signed-off-by: Alexander Wilhelm <alexander.wilhelm@westermo.com>
---
drivers/soc/qcom/qmi_encdec.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/soc/qcom/qmi_encdec.c b/drivers/soc/qcom/qmi_encdec.c
index 7660a960fb45..cb43531a8b66 100644
--- a/drivers/soc/qcom/qmi_encdec.c
+++ b/drivers/soc/qcom/qmi_encdec.c
@@ -11,6 +11,19 @@
#include <linux/string.h>
#include <linux/soc/qcom/qmi.h>
+#define QMI_ENCDEC_ENCODE_u8(x) (x)
+#define QMI_ENCDEC_ENCODE_u16(x) __cpu_to_le16(x)
+#define QMI_ENCDEC_ENCODE_u32(x) __cpu_to_le32(x)
+#define QMI_ENCDEC_ENCODE_u64(x) __cpu_to_le64(x)
+
+#define QMI_ENCDEC_DECODE_u8(x) (x)
+#define QMI_ENCDEC_DECODE_u16(x) __le16_to_cpu(x)
+#define QMI_ENCDEC_DECODE_u32(x) __le32_to_cpu(x)
+#define QMI_ENCDEC_DECODE_u64(x) __le64_to_cpu(x)
+
+#define QMI_ENCDEC_ENCODE(val, type) QMI_ENCDEC_ENCODE_##type(val)
+#define QMI_ENCDEC_DECODE(val, type) QMI_ENCDEC_DECODE_##type(val)
+
#define QMI_ENCDEC_ENCODE_TLV(type, length, p_dst) do { \
*p_dst++ = type; \
*p_dst++ = ((u8)((length) & 0xFF)); \
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 RESEND 2/4] soc: qcom: fix QMI encoding/decoding for basic elements
2025-09-17 7:04 [PATCH v2 RESEND 0/4] wifi: ath12k: Fix endianness handling in QMI Alexander Wilhelm
2025-09-17 7:04 ` [PATCH v2 RESEND 1/4] soc: qcom: introduce generic QMI encoding/decoding macros Alexander Wilhelm
@ 2025-09-17 7:04 ` Alexander Wilhelm
2025-09-18 5:59 ` kernel test robot
2025-09-17 7:04 ` [PATCH v2 RESEND 3/4] soc: qcom: preserve CPU endianness for QMI_DATA_LEN Alexander Wilhelm
2025-09-17 7:04 ` [PATCH v2 RESEND 4/4] wifi: ath12k: enforce CPU-endian format for all QMI messages Alexander Wilhelm
3 siblings, 1 reply; 6+ messages in thread
From: Alexander Wilhelm @ 2025-09-17 7:04 UTC (permalink / raw)
To: Jeff Johnson, Bjorn Andersson, Konrad Dybcio
Cc: linux-wireless, ath12k, linux-kernel, linux-arm-msm
Extend the QMI byte encoding and decoding logic to support multiple basic
data type sizes (u8, u16, u32, u64) using existing macros for generic
access. Ensure correct handling of data sizes and proper byte order
conversion on big-endian platforms by consistently applying these macros
during encoding and decoding of basic elements.
Fixes: 9b8a11e82615 ("soc: qcom: Introduce QMI encoder/decoder")
Signed-off-by: Alexander Wilhelm <alexander.wilhelm@westermo.com>
---
drivers/soc/qcom/qmi_encdec.c | 50 ++++++++++++++++++++++++++---------
1 file changed, 38 insertions(+), 12 deletions(-)
diff --git a/drivers/soc/qcom/qmi_encdec.c b/drivers/soc/qcom/qmi_encdec.c
index cb43531a8b66..d8575e92dbf6 100644
--- a/drivers/soc/qcom/qmi_encdec.c
+++ b/drivers/soc/qcom/qmi_encdec.c
@@ -36,18 +36,16 @@
*p_length |= ((u8)*p_src) << 8; \
} while (0)
-#define QMI_ENCDEC_ENCODE_N_BYTES(p_dst, p_src, size) \
-do { \
- memcpy(p_dst, p_src, size); \
- p_dst = (u8 *)p_dst + size; \
- p_src = (u8 *)p_src + size; \
+#define QMI_ENCDEC_ENCODE_N_BYTES(p_dst, p_src, type) do { \
+ *(type *)(p_dst) = QMI_ENCDEC_ENCODE(*(type *)(p_src), type); \
+ p_dst = (u8 *)(p_dst) + sizeof(type); \
+ p_src = (u8 *)(p_src) + sizeof(type); \
} while (0)
-#define QMI_ENCDEC_DECODE_N_BYTES(p_dst, p_src, size) \
-do { \
- memcpy(p_dst, p_src, size); \
- p_dst = (u8 *)p_dst + size; \
- p_src = (u8 *)p_src + size; \
+#define QMI_ENCDEC_DECODE_N_BYTES(p_dst, p_src, type) do { \
+ *(type *)(p_dst) = QMI_ENCDEC_DECODE(*(type *)(p_src), type); \
+ p_dst = (u8 *)(p_dst) + sizeof(type); \
+ p_src = (u8 *)(p_src) + sizeof(type); \
} while (0)
#define UPDATE_ENCODE_VARIABLES(temp_si, buf_dst, \
@@ -182,7 +180,21 @@ static int qmi_encode_basic_elem(void *buf_dst, const void *buf_src,
u32 i, rc = 0;
for (i = 0; i < elem_len; i++) {
- QMI_ENCDEC_ENCODE_N_BYTES(buf_dst, buf_src, elem_size);
+ switch (elem_size) {
+ case sizeof(u8):
+ QMI_ENCDEC_ENCODE_N_BYTES(buf_dst, buf_src, u8);
+ break;
+ case sizeof(u16):
+ QMI_ENCDEC_ENCODE_N_BYTES(buf_dst, buf_src, u16);
+ break;
+ case sizeof(u32):
+ QMI_ENCDEC_ENCODE_N_BYTES(buf_dst, buf_src, u32);
+ break;
+ case sizeof(u64):
+ QMI_ENCDEC_ENCODE_N_BYTES(buf_dst, buf_src, u64);
+ break;
+ }
+
rc += elem_size;
}
@@ -465,7 +477,21 @@ static int qmi_decode_basic_elem(void *buf_dst, const void *buf_src,
u32 i, rc = 0;
for (i = 0; i < elem_len; i++) {
- QMI_ENCDEC_DECODE_N_BYTES(buf_dst, buf_src, elem_size);
+ switch (elem_size) {
+ case sizeof(u8):
+ QMI_ENCDEC_DECODE_N_BYTES(buf_dst, buf_src, u8);
+ break;
+ case sizeof(u16):
+ QMI_ENCDEC_DECODE_N_BYTES(buf_dst, buf_src, u16);
+ break;
+ case sizeof(u32):
+ QMI_ENCDEC_DECODE_N_BYTES(buf_dst, buf_src, u32);
+ break;
+ case sizeof(u64):
+ QMI_ENCDEC_DECODE_N_BYTES(buf_dst, buf_src, u64);
+ break;
+ }
+
rc += elem_size;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 RESEND 3/4] soc: qcom: preserve CPU endianness for QMI_DATA_LEN
2025-09-17 7:04 [PATCH v2 RESEND 0/4] wifi: ath12k: Fix endianness handling in QMI Alexander Wilhelm
2025-09-17 7:04 ` [PATCH v2 RESEND 1/4] soc: qcom: introduce generic QMI encoding/decoding macros Alexander Wilhelm
2025-09-17 7:04 ` [PATCH v2 RESEND 2/4] soc: qcom: fix QMI encoding/decoding for basic elements Alexander Wilhelm
@ 2025-09-17 7:04 ` Alexander Wilhelm
2025-09-17 7:04 ` [PATCH v2 RESEND 4/4] wifi: ath12k: enforce CPU-endian format for all QMI messages Alexander Wilhelm
3 siblings, 0 replies; 6+ messages in thread
From: Alexander Wilhelm @ 2025-09-17 7:04 UTC (permalink / raw)
To: Jeff Johnson, Bjorn Andersson, Konrad Dybcio
Cc: linux-wireless, ath12k, linux-kernel, linux-arm-msm
To ensure correct handling of endianness in the QMI subsystem, the
QMI_DATA_LEN field used in host-side drivers remains in CPU-native byte
order. Remove unnecessary endianness conversions, considering that
QMI_DATA_LEN is always of type `u32` on the host. On the QMI wire
interface, however, its representation is variable and may use either 1 or
2 bytes.
Fixes: 3ced38da5f7d ("soc: qcom: QMI encoding/decoding for big endian")
Signed-off-by: Alexander Wilhelm <alexander.wilhelm@westermo.com>
---
drivers/soc/qcom/qmi_encdec.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/soc/qcom/qmi_encdec.c b/drivers/soc/qcom/qmi_encdec.c
index d8575e92dbf6..01f7045e91dc 100644
--- a/drivers/soc/qcom/qmi_encdec.c
+++ b/drivers/soc/qcom/qmi_encdec.c
@@ -365,6 +365,7 @@ static int qmi_encode(const struct qmi_elem_info *ei_array, void *out_buf,
break;
case QMI_DATA_LEN:
+ memcpy(&data_len_value, buf_src, sizeof(u32));
data_len_sz = temp_ei->elem_size == sizeof(u8) ?
sizeof(u8) : sizeof(u16);
/* Check to avoid out of range buffer access */
@@ -375,13 +376,11 @@ static int qmi_encode(const struct qmi_elem_info *ei_array, void *out_buf,
return -ETOOSMALL;
}
if (data_len_sz == sizeof(u8)) {
- val8 = *(u8 *)buf_src;
- data_len_value = (u32)val8;
+ val8 = data_len_value;
rc = qmi_encode_basic_elem(buf_dst, &val8,
1, data_len_sz);
} else {
- val16 = *(u16 *)buf_src;
- data_len_value = (u32)le16_to_cpu(val16);
+ val16 = data_len_value;
rc = qmi_encode_basic_elem(buf_dst, &val16,
1, data_len_sz);
}
@@ -664,7 +663,6 @@ static int qmi_decode(const struct qmi_elem_info *ei_array, void *out_c_struct,
int rc;
u8 val8;
u16 val16;
- u32 val32;
while (decoded_bytes < in_buf_len) {
if (dec_level >= 2 && temp_ei->data_type == QMI_EOTI)
@@ -712,8 +710,7 @@ static int qmi_decode(const struct qmi_elem_info *ei_array, void *out_c_struct,
1, data_len_sz);
data_len_value = (u32)val16;
}
- val32 = cpu_to_le32(data_len_value);
- memcpy(buf_dst, &val32, sizeof(u32));
+ memcpy(buf_dst, &data_len_value, sizeof(u32));
temp_ei = temp_ei + 1;
buf_dst = out_c_struct + temp_ei->offset;
tlv_len -= data_len_sz;
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 RESEND 4/4] wifi: ath12k: enforce CPU-endian format for all QMI messages
2025-09-17 7:04 [PATCH v2 RESEND 0/4] wifi: ath12k: Fix endianness handling in QMI Alexander Wilhelm
` (2 preceding siblings ...)
2025-09-17 7:04 ` [PATCH v2 RESEND 3/4] soc: qcom: preserve CPU endianness for QMI_DATA_LEN Alexander Wilhelm
@ 2025-09-17 7:04 ` Alexander Wilhelm
3 siblings, 0 replies; 6+ messages in thread
From: Alexander Wilhelm @ 2025-09-17 7:04 UTC (permalink / raw)
To: Jeff Johnson, Bjorn Andersson, Konrad Dybcio
Cc: linux-wireless, ath12k, linux-kernel, linux-arm-msm
Due to internal endianness handling within the QMI subsystem, all QMI
requests and responses must now be provided in CPU byte order. Replace all
QMI-related data types with CPU-endian types and add the necessary
conversions to ensure correct interpretation across architectures.
Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
Signed-off-by: Alexander Wilhelm <alexander.wilhelm@westermo.com>
---
drivers/net/wireless/ath/ath12k/qmi.c | 24 ++++++++++++++++--------
drivers/net/wireless/ath/ath12k/qmi.h | 16 ++++++++--------
2 files changed, 24 insertions(+), 16 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/qmi.c b/drivers/net/wireless/ath/ath12k/qmi.c
index 7c611a1fd6d0..36325e62aa24 100644
--- a/drivers/net/wireless/ath/ath12k/qmi.c
+++ b/drivers/net/wireless/ath/ath12k/qmi.c
@@ -3307,20 +3307,28 @@ static int ath12k_qmi_wlanfw_wlan_cfg_send(struct ath12k_base *ab)
/* This is number of CE configs */
req->tgt_cfg_len = ab->qmi.ce_cfg.tgt_ce_len;
for (pipe_num = 0; pipe_num < req->tgt_cfg_len ; pipe_num++) {
- req->tgt_cfg[pipe_num].pipe_num = ce_cfg[pipe_num].pipenum;
- req->tgt_cfg[pipe_num].pipe_dir = ce_cfg[pipe_num].pipedir;
- req->tgt_cfg[pipe_num].nentries = ce_cfg[pipe_num].nentries;
- req->tgt_cfg[pipe_num].nbytes_max = ce_cfg[pipe_num].nbytes_max;
- req->tgt_cfg[pipe_num].flags = ce_cfg[pipe_num].flags;
+ req->tgt_cfg[pipe_num].pipe_num =
+ __le32_to_cpu(ce_cfg[pipe_num].pipenum);
+ req->tgt_cfg[pipe_num].pipe_dir =
+ __le32_to_cpu(ce_cfg[pipe_num].pipedir);
+ req->tgt_cfg[pipe_num].nentries =
+ __le32_to_cpu(ce_cfg[pipe_num].nentries);
+ req->tgt_cfg[pipe_num].nbytes_max =
+ __le32_to_cpu(ce_cfg[pipe_num].nbytes_max);
+ req->tgt_cfg[pipe_num].flags =
+ __le32_to_cpu(ce_cfg[pipe_num].flags);
}
req->svc_cfg_valid = 1;
/* This is number of Service/CE configs */
req->svc_cfg_len = ab->qmi.ce_cfg.svc_to_ce_map_len;
for (pipe_num = 0; pipe_num < req->svc_cfg_len; pipe_num++) {
- req->svc_cfg[pipe_num].service_id = svc_cfg[pipe_num].service_id;
- req->svc_cfg[pipe_num].pipe_dir = svc_cfg[pipe_num].pipedir;
- req->svc_cfg[pipe_num].pipe_num = svc_cfg[pipe_num].pipenum;
+ req->svc_cfg[pipe_num].service_id =
+ __le32_to_cpu(svc_cfg[pipe_num].service_id);
+ req->svc_cfg[pipe_num].pipe_dir =
+ __le32_to_cpu(svc_cfg[pipe_num].pipedir);
+ req->svc_cfg[pipe_num].pipe_num =
+ __le32_to_cpu(svc_cfg[pipe_num].pipenum);
}
/* set shadow v3 configuration */
diff --git a/drivers/net/wireless/ath/ath12k/qmi.h b/drivers/net/wireless/ath/ath12k/qmi.h
index abdaade3b542..4767d9a2e309 100644
--- a/drivers/net/wireless/ath/ath12k/qmi.h
+++ b/drivers/net/wireless/ath/ath12k/qmi.h
@@ -392,17 +392,17 @@ enum qmi_wlanfw_pipedir_enum_v01 {
};
struct qmi_wlanfw_ce_tgt_pipe_cfg_s_v01 {
- __le32 pipe_num;
- __le32 pipe_dir;
- __le32 nentries;
- __le32 nbytes_max;
- __le32 flags;
+ u32 pipe_num;
+ u32 pipe_dir;
+ u32 nentries;
+ u32 nbytes_max;
+ u32 flags;
};
struct qmi_wlanfw_ce_svc_pipe_cfg_s_v01 {
- __le32 service_id;
- __le32 pipe_dir;
- __le32 pipe_num;
+ u32 service_id;
+ u32 pipe_dir;
+ u32 pipe_num;
};
struct qmi_wlanfw_shadow_reg_cfg_s_v01 {
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 RESEND 2/4] soc: qcom: fix QMI encoding/decoding for basic elements
2025-09-17 7:04 ` [PATCH v2 RESEND 2/4] soc: qcom: fix QMI encoding/decoding for basic elements Alexander Wilhelm
@ 2025-09-18 5:59 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2025-09-18 5:59 UTC (permalink / raw)
To: Alexander Wilhelm, Jeff Johnson, Bjorn Andersson, Konrad Dybcio
Cc: oe-kbuild-all, linux-wireless, ath12k, linux-kernel,
linux-arm-msm
Hi Alexander,
kernel test robot noticed the following build warnings:
[auto build test WARNING on ath/ath-next]
[also build test WARNING on linus/master v6.17-rc6 next-20250917]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Alexander-Wilhelm/soc-qcom-introduce-generic-QMI-encoding-decoding-macros/20250917-150826
base: https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git ath-next
patch link: https://lore.kernel.org/r/20250917070428.2909-3-alexander.wilhelm%40westermo.com
patch subject: [PATCH v2 RESEND 2/4] soc: qcom: fix QMI encoding/decoding for basic elements
config: openrisc-randconfig-r132-20250918 (https://download.01.org/0day-ci/archive/20250918/202509181302.j10W2wCw-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250918/202509181302.j10W2wCw-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509181302.j10W2wCw-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
drivers/soc/qcom/qmi_encdec.c:384:55: sparse: sparse: cast to restricted __le16
drivers/soc/qcom/qmi_encdec.c:384:55: sparse: sparse: cast to restricted __le16
drivers/soc/qcom/qmi_encdec.c:384:55: sparse: sparse: cast to restricted __le16
drivers/soc/qcom/qmi_encdec.c:384:55: sparse: sparse: cast to restricted __le16
drivers/soc/qcom/qmi_encdec.c:715:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] val32 @@ got restricted __le32 [usertype] @@
drivers/soc/qcom/qmi_encdec.c:715:31: sparse: expected unsigned int [usertype] val32
drivers/soc/qcom/qmi_encdec.c:715:31: sparse: got restricted __le32 [usertype]
>> drivers/soc/qcom/qmi_encdec.c:188:25: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] @@ got restricted __le16 [usertype] @@
drivers/soc/qcom/qmi_encdec.c:188:25: sparse: expected unsigned short [usertype]
drivers/soc/qcom/qmi_encdec.c:188:25: sparse: got restricted __le16 [usertype]
>> drivers/soc/qcom/qmi_encdec.c:191:25: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] @@ got restricted __le32 [usertype] @@
drivers/soc/qcom/qmi_encdec.c:191:25: sparse: expected unsigned int [usertype]
drivers/soc/qcom/qmi_encdec.c:191:25: sparse: got restricted __le32 [usertype]
>> drivers/soc/qcom/qmi_encdec.c:194:25: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned long long [usertype] @@ got restricted __le64 [usertype] @@
drivers/soc/qcom/qmi_encdec.c:194:25: sparse: expected unsigned long long [usertype]
drivers/soc/qcom/qmi_encdec.c:194:25: sparse: got restricted __le64 [usertype]
drivers/soc/qcom/qmi_encdec.c:485:25: sparse: sparse: cast to restricted __le16
drivers/soc/qcom/qmi_encdec.c:485:25: sparse: sparse: cast to restricted __le16
drivers/soc/qcom/qmi_encdec.c:485:25: sparse: sparse: cast to restricted __le16
drivers/soc/qcom/qmi_encdec.c:485:25: sparse: sparse: cast to restricted __le16
>> drivers/soc/qcom/qmi_encdec.c:488:25: sparse: sparse: cast to restricted __le32
>> drivers/soc/qcom/qmi_encdec.c:488:25: sparse: sparse: cast to restricted __le32
>> drivers/soc/qcom/qmi_encdec.c:488:25: sparse: sparse: cast to restricted __le32
>> drivers/soc/qcom/qmi_encdec.c:488:25: sparse: sparse: cast to restricted __le32
>> drivers/soc/qcom/qmi_encdec.c:488:25: sparse: sparse: cast to restricted __le32
>> drivers/soc/qcom/qmi_encdec.c:488:25: sparse: sparse: cast to restricted __le32
>> drivers/soc/qcom/qmi_encdec.c:491:25: sparse: sparse: cast to restricted __le64
>> drivers/soc/qcom/qmi_encdec.c:491:25: sparse: sparse: cast to restricted __le64
>> drivers/soc/qcom/qmi_encdec.c:491:25: sparse: sparse: cast to restricted __le64
>> drivers/soc/qcom/qmi_encdec.c:491:25: sparse: sparse: cast to restricted __le64
>> drivers/soc/qcom/qmi_encdec.c:491:25: sparse: sparse: cast to restricted __le64
>> drivers/soc/qcom/qmi_encdec.c:491:25: sparse: sparse: cast to restricted __le64
>> drivers/soc/qcom/qmi_encdec.c:491:25: sparse: sparse: cast to restricted __le64
>> drivers/soc/qcom/qmi_encdec.c:491:25: sparse: sparse: cast to restricted __le64
>> drivers/soc/qcom/qmi_encdec.c:491:25: sparse: sparse: cast to restricted __le64
>> drivers/soc/qcom/qmi_encdec.c:491:25: sparse: sparse: cast to restricted __le64
vim +188 drivers/soc/qcom/qmi_encdec.c
161
162 /**
163 * qmi_encode_basic_elem() - Encodes elements of basic/primary data type
164 * @buf_dst: Buffer to store the encoded information.
165 * @buf_src: Buffer containing the elements to be encoded.
166 * @elem_len: Number of elements, in the buf_src, to be encoded.
167 * @elem_size: Size of a single instance of the element to be encoded.
168 *
169 * This function encodes the "elem_len" number of data elements, each of
170 * size "elem_size" bytes from the source buffer "buf_src" and stores the
171 * encoded information in the destination buffer "buf_dst". The elements are
172 * of primary data type which include u8 - u64 or similar. This
173 * function returns the number of bytes of encoded information.
174 *
175 * Return: The number of bytes of encoded information.
176 */
177 static int qmi_encode_basic_elem(void *buf_dst, const void *buf_src,
178 u32 elem_len, u32 elem_size)
179 {
180 u32 i, rc = 0;
181
182 for (i = 0; i < elem_len; i++) {
183 switch (elem_size) {
184 case sizeof(u8):
185 QMI_ENCDEC_ENCODE_N_BYTES(buf_dst, buf_src, u8);
186 break;
187 case sizeof(u16):
> 188 QMI_ENCDEC_ENCODE_N_BYTES(buf_dst, buf_src, u16);
189 break;
190 case sizeof(u32):
> 191 QMI_ENCDEC_ENCODE_N_BYTES(buf_dst, buf_src, u32);
192 break;
193 case sizeof(u64):
> 194 QMI_ENCDEC_ENCODE_N_BYTES(buf_dst, buf_src, u64);
195 break;
196 }
197
198 rc += elem_size;
199 }
200
201 return rc;
202 }
203
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-09-18 6:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-17 7:04 [PATCH v2 RESEND 0/4] wifi: ath12k: Fix endianness handling in QMI Alexander Wilhelm
2025-09-17 7:04 ` [PATCH v2 RESEND 1/4] soc: qcom: introduce generic QMI encoding/decoding macros Alexander Wilhelm
2025-09-17 7:04 ` [PATCH v2 RESEND 2/4] soc: qcom: fix QMI encoding/decoding for basic elements Alexander Wilhelm
2025-09-18 5:59 ` kernel test robot
2025-09-17 7:04 ` [PATCH v2 RESEND 3/4] soc: qcom: preserve CPU endianness for QMI_DATA_LEN Alexander Wilhelm
2025-09-17 7:04 ` [PATCH v2 RESEND 4/4] wifi: ath12k: enforce CPU-endian format for all QMI messages Alexander Wilhelm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox