Linux wireless drivers development
 help / color / mirror / Atom feed
From: Marco Crivellari <marco.crivellari@suse.com>
To: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Marco Crivellari <marco.crivellari@suse.com>,
	Michal Hocko <mhocko@suse.com>,
	Miri Korenblit <miriam.rachel.korenblit@intel.com>,
	Johannes Berg <johannes@sipsolutions.net>
Subject: [PATCH v2 0/3] Replace uses of system_wq and system_unbound_wq
Date: Thu, 20 Nov 2025 11:08:47 +0100	[thread overview]
Message-ID: <20251120100850.66192-1-marco.crivellari@suse.com> (raw)

Hi,

=== Current situation: problems ===

Let's consider a nohz_full system with isolated CPUs: wq_unbound_cpumask is
set to the housekeeping CPUs, for !WQ_UNBOUND the local CPU is selected.

This leads to different scenarios if a work item is scheduled on an
isolated CPU where "delay" value is 0 or greater then 0:
        schedule_delayed_work(, 0);

This will be handled by __queue_work() that will queue the work item on the
current local (isolated) CPU, while:

        schedule_delayed_work(, 1);

Will move the timer on an housekeeping CPU, and schedule the work there.

Currently if a user enqueue a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistency cannot be addressed without refactoring the API.

=== Recent changes to the WQ API ===

The following, address the recent changes in the Workqueue API:

- commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
- commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

The old workqueues will be removed in a future release cycle.

=== Introduced Changes by this series ===

1) [P 1-2-3]  Replace uses of system_unbound_wq and system_wq

    Switch to using system_dfl_wq and system_percpu_wq  because
    system_unbound_wq and system_wq are going away
    as part of a workqueue restructuring.

    No intended behavior changes:
       system_wq -> system_percpu_wq
       system_unbound_wq -> system_dfl_wq

Thanks!

---
Changes in v2:
- improved commit logs

- P3: wrong commit log was about system_unbound_wq; subject changed with
  system_wq.


Marco Crivellari (3):
  wifi: iwlwifi: replace use of system_unbound_wq with system_dfl_wq
  wifi: iwlwifi: fw: replace use of system_unbound_wq with system_dfl_wq
  wifi: iwlwifi: nvm: replace use of system_wq with system_percpu_wq

 drivers/net/wireless/intel/iwlwifi/fw/dbg.c    | 4 ++--
 drivers/net/wireless/intel/iwlwifi/iwl-trans.h | 2 +-
 drivers/net/wireless/intel/iwlwifi/mvm/tdls.c  | 6 +++---
 3 files changed, 6 insertions(+), 6 deletions(-)

-- 
2.51.1


             reply	other threads:[~2025-11-20 10:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20 10:08 Marco Crivellari [this message]
2025-11-20 10:08 ` [PATCH v2 1/3] wifi: iwlwifi: replace use of system_unbound_wq with system_dfl_wq Marco Crivellari
2026-02-09  8:01   ` Korenblit, Miriam Rachel
2025-11-20 10:08 ` [PATCH v2 2/3] wifi: iwlwifi: fw: " Marco Crivellari
2026-02-09  8:01   ` Korenblit, Miriam Rachel
2025-11-20 10:08 ` [PATCH v2 3/3] wifi: iwlwifi: nvm: replace use of system_wq with system_percpu_wq Marco Crivellari
2026-02-09  7:58   ` Korenblit, Miriam Rachel
2026-02-10 14:22     ` Marco Crivellari
2025-12-24 15:27 ` [PATCH v2 0/3] Replace uses of system_wq and system_unbound_wq Marco Crivellari
2026-02-04 11:03   ` Marco Crivellari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251120100850.66192-1-marco.crivellari@suse.com \
    --to=marco.crivellari@suse.com \
    --cc=bigeasy@linutronix.de \
    --cc=frederic@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mhocko@suse.com \
    --cc=miriam.rachel.korenblit@intel.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox