[PATCH wireless] wifi: mac80211: correct FILS status codes

[PATCH wireless] wifi: mac80211: correct FILS status codes

[Ria Thomas]

The FILS status codes are set to 108/109, but the IEEE 802.11-2020
spec defines them as 112/113. Update the enum so it matches the
specification and keeps mac80211 consistent with standard values.

Fixes: a3caf7440ded ("wifi: mac80211: add corrected FILS status codes")
Signed-off-by: Ria Thomas <ria.thomas@morsemicro.com>
---
 include/linux/ieee80211.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
index ddff9102f633..1f4679092e69 100644
--- a/include/linux/ieee80211.h
+++ b/include/linux/ieee80211.h
@@ -3594,8 +3594,8 @@ enum ieee80211_statuscode {
 	WLAN_STATUS_DENIED_WITH_SUGGESTED_BAND_AND_CHANNEL = 99,
 	WLAN_STATUS_DENIED_DUE_TO_SPECTRUM_MANAGEMENT = 103,
 	/* 802.11ai */
-	WLAN_STATUS_FILS_AUTHENTICATION_FAILURE = 108,
-	WLAN_STATUS_UNKNOWN_AUTHENTICATION_SERVER = 109,
+	WLAN_STATUS_FILS_AUTHENTICATION_FAILURE = 112,
+	WLAN_STATUS_UNKNOWN_AUTHENTICATION_SERVER = 113,
 	WLAN_STATUS_SAE_HASH_TO_ELEMENT = 126,
 	WLAN_STATUS_SAE_PK = 127,
 	WLAN_STATUS_DENIED_TID_TO_LINK_MAPPING = 133,
-- 
2.25.1

Re: [PATCH wireless] wifi: mac80211: correct FILS status codes

[Johannes Berg]

On Mon, 2025-11-24 at 11:41 +0530, Ria Thomas wrote:
> The FILS status codes are set to 108/109, but the IEEE 802.11-2020
> spec defines them as 112/113. Update the enum so it matches the
> specification and keeps mac80211 consistent with standard values.
> 
> Fixes: a3caf7440ded ("wifi: mac80211: add corrected FILS status codes")

What?

johannes

Re: [PATCH wireless] wifi: mac80211: correct FILS status codes

[Pablo MARTIN-GOMEZ]

On 24/11/2025 12:58, Johannes Berg wrote:
> On Mon, 2025-11-24 at 11:41 +0530, Ria Thomas wrote:
>> The FILS status codes are set to 108/109, but the IEEE 802.11-2020
>> spec defines them as 112/113. Update the enum so it matches the
>> specification and keeps mac80211 consistent with standard values.
>>
>> Fixes: a3caf7440ded ("wifi: mac80211: add corrected FILS status codes")
> What?
>
> johannes
>
The SHA is correct, but the commit message should be "cfg80211: Add 
support for FILS shared key authentication offload"

Pablo MG

Re: [PATCH wireless] wifi: mac80211: correct FILS status codes

[Ria Thomas]

On Mon, Nov 24, 2025 at 01:44:00PM +0100, Pablo MARTIN-GOMEZ wrote:
> On 24/11/2025 12:58, Johannes Berg wrote:
> > On Mon, 2025-11-24 at 11:41 +0530, Ria Thomas wrote:
> > > The FILS status codes are set to 108/109, but the IEEE 802.11-2020
> > > spec defines them as 112/113. Update the enum so it matches the
> > > specification and keeps mac80211 consistent with standard values.
> > > 
> > > Fixes: a3caf7440ded ("wifi: mac80211: add corrected FILS status codes")
> > What?
> > 
> > johannes
> > 
> The SHA is correct, but the commit message should be "cfg80211: Add support
> for FILS shared key authentication offload"
> 
> Pablo MG
>
Thanks for the review johanned and Pablo. Corrected and resubmitted

Ria

[PATCH v2] wifi: mac80211: correct FILS status codes

[Ria Thomas]

The FILS status codes are set to 108/109, but the IEEE 802.11-2020
spec defines them as 112/113. Update the enum so it matches the
specification and keeps mac80211 consistent with standard values.

Fixes: a3caf7440ded ("cfg80211: Add support for FILS shared key authentication offload")
Signed-off-by: Ria Thomas <ria.thomas@morsemicro.com>
---
v2:
 - Correct the Fixes: tag to reference the right commit.
---
 include/linux/ieee80211.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
index ddff9102f633..1f4679092e69 100644
--- a/include/linux/ieee80211.h
+++ b/include/linux/ieee80211.h
@@ -3594,8 +3594,8 @@ enum ieee80211_statuscode {
 	WLAN_STATUS_DENIED_WITH_SUGGESTED_BAND_AND_CHANNEL = 99,
 	WLAN_STATUS_DENIED_DUE_TO_SPECTRUM_MANAGEMENT = 103,
 	/* 802.11ai */
-	WLAN_STATUS_FILS_AUTHENTICATION_FAILURE = 108,
-	WLAN_STATUS_UNKNOWN_AUTHENTICATION_SERVER = 109,
+	WLAN_STATUS_FILS_AUTHENTICATION_FAILURE = 112,
+	WLAN_STATUS_UNKNOWN_AUTHENTICATION_SERVER = 113,
 	WLAN_STATUS_SAE_HASH_TO_ELEMENT = 126,
 	WLAN_STATUS_SAE_PK = 127,
 	WLAN_STATUS_DENIED_TID_TO_LINK_MAPPING = 133,
-- 
2.25.1

Re: [PATCH v2] wifi: mac80211: correct FILS status codes

[Jeff Johnson]

On 11/24/2025 4:56 AM, Ria Thomas wrote:
> The FILS status codes are set to 108/109, but the IEEE 802.11-2020

Note that the current version is IEEE Std 802.11-2024, and it would be useful
to directly reference Table 9-80.

This issue was pointed out by IEEE in "Errata to IEEE Std 802.11ai-2016." In
addition to this issue, that errata also calls out renumbering the "Category
values" in what was then Table 9-47, now Table 9-81, for FILS from 22 to 26.
But the current enum ieee80211_category does not have an entry for FILS, so
that part of the errata does not need to be applied

But while researching this I see the current category 22 enum is incorrect:
	WLAN_CATEGORY_S1G = 22,

since IEEE Std 802.11-2024, Table 9-81 has:
	22 Unprotected S1G
	23 S1G

So that might also need to be addressed by someone.

> spec defines them as 112/113. Update the enum so it matches the
> specification and keeps mac80211 consistent with standard values.
> 
> Fixes: a3caf7440ded ("cfg80211: Add support for FILS shared key authentication offload")
> Signed-off-by: Ria Thomas <ria.thomas@morsemicro.com>
> ---
> v2:
>  - Correct the Fixes: tag to reference the right commit.
> ---
>  include/linux/ieee80211.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
> index ddff9102f633..1f4679092e69 100644
> --- a/include/linux/ieee80211.h
> +++ b/include/linux/ieee80211.h
> @@ -3594,8 +3594,8 @@ enum ieee80211_statuscode {
>  	WLAN_STATUS_DENIED_WITH_SUGGESTED_BAND_AND_CHANNEL = 99,
>  	WLAN_STATUS_DENIED_DUE_TO_SPECTRUM_MANAGEMENT = 103,
>  	/* 802.11ai */
> -	WLAN_STATUS_FILS_AUTHENTICATION_FAILURE = 108,
> -	WLAN_STATUS_UNKNOWN_AUTHENTICATION_SERVER = 109,
> +	WLAN_STATUS_FILS_AUTHENTICATION_FAILURE = 112,
> +	WLAN_STATUS_UNKNOWN_AUTHENTICATION_SERVER = 113,
>  	WLAN_STATUS_SAE_HASH_TO_ELEMENT = 126,
>  	WLAN_STATUS_SAE_PK = 127,
>  	WLAN_STATUS_DENIED_TID_TO_LINK_MAPPING = 133,

actual code change...
Reviewed-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>

Re: [PATCH v2] wifi: mac80211: correct FILS status codes

[Ria Thomas]

On Mon, Nov 24, 2025 at 09:52:31AM -0800, Jeff Johnson wrote:
> On 11/24/2025 4:56 AM, Ria Thomas wrote:
> > The FILS status codes are set to 108/109, but the IEEE 802.11-2020
> 
> Note that the current version is IEEE Std 802.11-2024, and it would be useful
> to directly reference Table 9-80.
Thanks, I've noted that the current revision is 802.11-2024.I cited
802.11-2020 because it’s the first revision that defines these status
codes. I can switch to 802.11-2024 if that’s preferred.
> 
> This issue was pointed out by IEEE in "Errata to IEEE Std 802.11ai-2016." In
> addition to this issue, that errata also calls out renumbering the "Category
> values" in what was then Table 9-47, now Table 9-81, for FILS from 22 to 26.
> But the current enum ieee80211_category does not have an entry for FILS, so
> that part of the errata does not need to be applied
> 
> But while researching this I see the current category 22 enum is incorrect:
> 	WLAN_CATEGORY_S1G = 22,
> 
> since IEEE Std 802.11-2024, Table 9-81 has:
> 	22 Unprotected S1G
> 	23 S1G
> 
> So that might also need to be addressed by someone.
>
Sure, will review the changes and submit the patch separately as S1G related change.

Re: [PATCH v2] wifi: mac80211: correct FILS status codes

[Johannes Berg]

On Tue, 2025-11-25 at 09:09 +0530, Ria Thomas wrote:
> On Mon, Nov 24, 2025 at 09:52:31AM -0800, Jeff Johnson wrote:
> > On 11/24/2025 4:56 AM, Ria Thomas wrote:
> > > The FILS status codes are set to 108/109, but the IEEE 802.11-2020
> > 
> > Note that the current version is IEEE Std 802.11-2024, and it would be useful
> > to directly reference Table 9-80.
> Thanks, I've noted that the current revision is 802.11-2024.I cited
> 802.11-2020 because it’s the first revision that defines these status
> codes. I can switch to 802.11-2024 if that’s preferred.
> 

Didn't really matter here, but generally I guess it would be better.

I did apply this now, but I do wonder if we're better off just removing
unused values? We don't (even pretend to) maintain a full definition of
everything 802.11 in the kernel, and don't need to either?

johannes

Re: [PATCH v2] wifi: mac80211: correct FILS status codes

[Ria Thomas]

On Tue, Nov 25, 2025 at 10:30:37AM +0100, Johannes Berg wrote:
> 
> I did apply this now, but I do wonder if we're better off just removing
> unused values? We don't (even pretend to) maintain a full definition of
> everything 802.11 in the kernel, and don't need to either?
> 
> johannes

Thanks for applying.
For context, I’m not using these status codes directly today. The change was
mainly to unblock the enum space for upcoming NDP work. This adjustment was necessary
to remove a dependency blocker in my series.

I’m fine with removing unused values altogether. If you prefer, I can follow up with a
cleanup patch that drops unused codes and adds a brief comment noting the list isn’t
exhaustive and new codes should be added on demand.

Ria