Re: [PATCH rtw-next 09/10] wifi: rtw89: fw: consider hardware AID for firmware elements

[kernel test robot <lkp@intel.com>]

Hi Ping-Ke,

kernel test robot noticed the following build errors:

[auto build test ERROR on wireless-next/main]
[also build test ERROR on wireless/main linus/master v6.19-rc3 next-20251219]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ping-Ke-Shih/wifi-rtw89-update-TXWD-v3-for-RTL8922D/20260102-152315
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link:    https://lore.kernel.org/r/20260102070840.62047-10-pkshih%40realtek.com
patch subject: [PATCH rtw-next 09/10] wifi: rtw89: fw: consider hardware AID for firmware elements
config: x86_64-rhel-9.4-ltp (https://download.01.org/0day-ci/archive/20260103/202601031731.PNwSACm3-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260103/202601031731.PNwSACm3-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601031731.PNwSACm3-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/net/wireless/realtek/rtw89/fw.c:11:
   drivers/net/wireless/realtek/rtw89/mac.h: In function 'rtw89_mac_chk_preload_allow':
   drivers/net/wireless/realtek/rtw89/mac.h:1728:61: error: 'struct rtw89_hal' has no member named 'cid'
    1728 |         if (rtwdev->chip->chip_id == RTL8922D && rtwdev->hal.cid == RTL8922D_CID7090)
         |                                                             ^
   drivers/net/wireless/realtek/rtw89/mac.h:1728:69: error: 'RTL8922D_CID7090' undeclared (first use in this function)
    1728 |         if (rtwdev->chip->chip_id == RTL8922D && rtwdev->hal.cid == RTL8922D_CID7090)
         |                                                                     ^~~~~~~~~~~~~~~~
   drivers/net/wireless/realtek/rtw89/mac.h:1728:69: note: each undeclared identifier is reported only once for each function it appears in
   drivers/net/wireless/realtek/rtw89/fw.c: In function 'rtw89_build_phy_tbl_from_elm':
>> drivers/net/wireless/realtek/rtw89/fw.c:1048:30: error: 'struct rtw89_hal' has no member named 'aid'
    1048 |         if (aid && aid != hal->aid)
         |                              ^~


vim +1048 drivers/net/wireless/realtek/rtw89/fw.c

  1009	
  1010	static
  1011	int rtw89_build_phy_tbl_from_elm(struct rtw89_dev *rtwdev,
  1012					 const struct rtw89_fw_element_hdr *elm,
  1013					 const union rtw89_fw_element_arg arg)
  1014	{
  1015		struct rtw89_fw_elm_info *elm_info = &rtwdev->fw.elm_info;
  1016		struct rtw89_hal *hal = &rtwdev->hal;
  1017		struct rtw89_phy_table *tbl, **pp;
  1018		struct rtw89_reg2_def *regs;
  1019		bool radio = false;
  1020		u32 n_regs, i;
  1021		u16 aid;
  1022		u8 idx;
  1023	
  1024		switch (le32_to_cpu(elm->id)) {
  1025		case RTW89_FW_ELEMENT_ID_BB_REG:
  1026			pp = &elm_info->bb_tbl;
  1027			break;
  1028		case RTW89_FW_ELEMENT_ID_BB_GAIN:
  1029			pp = &elm_info->bb_gain;
  1030			break;
  1031		case RTW89_FW_ELEMENT_ID_RADIO_A:
  1032		case RTW89_FW_ELEMENT_ID_RADIO_B:
  1033		case RTW89_FW_ELEMENT_ID_RADIO_C:
  1034		case RTW89_FW_ELEMENT_ID_RADIO_D:
  1035			idx = elm->u.reg2.idx;
  1036			pp = &elm_info->rf_radio[idx];
  1037	
  1038			radio = true;
  1039			break;
  1040		case RTW89_FW_ELEMENT_ID_RF_NCTL:
  1041			pp = &elm_info->rf_nctl;
  1042			break;
  1043		default:
  1044			return -ENOENT;
  1045		}
  1046	
  1047		aid = le16_to_cpu(elm->aid);
> 1048		if (aid && aid != hal->aid)
  1049			return 1; /* ignore if aid not matched */
  1050		else if (*pp)
  1051			return 1; /* ignore if an element is existing */
  1052	
  1053		tbl = kzalloc(sizeof(*tbl), GFP_KERNEL);
  1054		if (!tbl)
  1055			return -ENOMEM;
  1056	
  1057		n_regs = le32_to_cpu(elm->size) / sizeof(tbl->regs[0]);
  1058		regs = kcalloc(n_regs, sizeof(*regs), GFP_KERNEL);
  1059		if (!regs)
  1060			goto out;
  1061	
  1062		for (i = 0; i < n_regs; i++) {
  1063			regs[i].addr = le32_to_cpu(elm->u.reg2.regs[i].addr);
  1064			regs[i].data = le32_to_cpu(elm->u.reg2.regs[i].data);
  1065		}
  1066	
  1067		tbl->n_regs = n_regs;
  1068		tbl->regs = regs;
  1069	
  1070		if (radio) {
  1071			tbl->rf_path = arg.rf_path;
  1072			tbl->config = rtw89_phy_config_rf_reg_v1;
  1073		}
  1074	
  1075		*pp = tbl;
  1076	
  1077		return 0;
  1078	
  1079	out:
  1080		kfree(tbl);
  1081		return -ENOMEM;
  1082	}
  1083	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki