public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Saikiran <bjsaikiran@gmail.com>
To: ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, kvalo@kernel.org,
	Saikiran <bjsaikiran@gmail.com>
Subject: [PATCH v2 2/2] wifi: ath12k: Fix firmware stats leak when pdev list is empty
Date: Mon, 26 Jan 2026 15:22:44 +0530	[thread overview]
Message-ID: <20260126095244.113301-3-bjsaikiran@gmail.com> (raw)
In-Reply-To: <20260126095244.113301-1-bjsaikiran@gmail.com>

The commits bd6ec8111e65 and 2977567b244f changed firmware stats handling
to be caller-driven, requiring explicit ath12k_fw_stats_reset() calls
after using ath12k_mac_get_fw_stats().

In ath12k_mac_op_get_txpower(), when ath12k_mac_get_fw_stats() succeeds
but the pdev stats list is empty, the function exits without calling
ath12k_fw_stats_reset(). Even though the pdev list is empty, the firmware
may have populated other stats lists (vdevs, beacons, etc.) in the
ar->fw_stats structure.

Without resetting the stats buffer, this data accumulates across multiple
calls, eventually causing the stats buffer to overflow and leading to
firmware communication failures (error -71/EPROTO) during subsequent
operations.

The issue manifests during 5GHz scanning which triggers multiple TX power
queries. Symptoms include:
- "failed to pull fw stats: -71" errors in dmesg
- 5GHz networks not detected despite hardware support
- 2.4GHz networks work normally

Fix by calling ath12k_fw_stats_reset() when the pdev list is empty,
ensuring the stats buffer is properly cleaned up even when only partial
stats data is received from firmware.

Fixes: bd6ec8111e65 ("wifi: ath12k: Make firmware stats reset caller-driven")
Link: https://bugs.launchpad.net/ubuntu-concept/+bug/2138308
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302 (Lenovo Yoga Slim 7x)
Signed-off-by: Saikiran <bjsaikiran@gmail.com>
---
 drivers/net/wireless/ath/ath12k/mac.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
index e0e49f782bf8..6e35c3ee9864 100644
--- a/drivers/net/wireless/ath/ath12k/mac.c
+++ b/drivers/net/wireless/ath/ath12k/mac.c
@@ -5169,6 +5169,7 @@ static int ath12k_mac_op_get_txpower(struct ieee80211_hw *hw,
 					struct ath12k_fw_stats_pdev, list);
 	if (!pdev) {
 		spin_unlock_bh(&ar->data_lock);
+		ath12k_fw_stats_reset(ar);
 		goto err_fallback;
 	}
 
-- 
2.51.0


  parent reply	other threads:[~2026-01-26  9:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26  9:52 [PATCH v2 0/2] wifi: ath12k: Fix 5GHz issues on WCN7850 Saikiran
2026-01-26  9:52 ` [PATCH v2 1/2] wifi: ath12k: Remove frequency range filtering for single-phy devices Saikiran
2026-01-27  3:22   ` Baochen Qiang
2026-01-27  4:04     ` Saikiran B
2026-01-27  7:41       ` Baochen Qiang
2026-01-27  8:58         ` Saikiran B
2026-01-27 10:21           ` Baochen Qiang
2026-01-27 19:06             ` Saikiran B
2026-01-26  9:52 ` Saikiran [this message]
2026-01-27  3:27   ` [PATCH v2 2/2] wifi: ath12k: Fix firmware stats leak when pdev list is empty Baochen Qiang
2026-01-27  4:17     ` Saikiran B
2026-01-27  4:40       ` Saikiran B
2026-01-29  2:27         ` Baochen Qiang
2026-01-29 14:06           ` Saikiran B
2026-01-30  2:09             ` Baochen Qiang
2026-01-30  7:32               ` Saikiran B
2026-01-30  7:50                 ` Baochen Qiang
2026-01-30 14:27                 ` Jeff Johnson
2026-01-30 16:45                   ` Saikiran B

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260126095244.113301-3-bjsaikiran@gmail.com \
    --to=bjsaikiran@gmail.com \
    --cc=ath12k@lists.infradead.org \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox