From: Sun Jian <sun.jian.kdev@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Sun Jian <sun.jian.kdev@gmail.com>
Subject: [PATCH] wifi: nl80211: drop impossible negative band check
Date: Wed, 4 Feb 2026 16:18:21 +0800 [thread overview]
Message-ID: <20260204081821.730673-1-sun.jian.kdev@gmail.com> (raw)
band is derived from nla_type() of a nested netlink attribute, which is
a masked u16 value and therefore cannot be negative. Drop the dead
"band < 0" checks and keep the upper bound validation.
No functional change intended.
Signed-off-by: Sun Jian <sun.jian.kdev@gmail.com>
---
net/wireless/nl80211.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 03efd45c007f..a92b4e24b28b 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -5759,7 +5759,7 @@ static int nl80211_parse_tx_bitrate_mask(struct genl_info *info,
enum nl80211_band band = nla_type(tx_rates);
int err;
- if (band < 0 || band >= NUM_NL80211_BANDS)
+ if (band >= NUM_NL80211_BANDS)
return -EINVAL;
sband = rdev->wiphy.bands[band];
if (sband == NULL)
@@ -10536,7 +10536,7 @@ static int nl80211_trigger_scan(struct sk_buff *skb, struct genl_info *info)
tmp) {
enum nl80211_band band = nla_type(attr);
- if (band < 0 || band >= NUM_NL80211_BANDS) {
+ if (band >= NUM_NL80211_BANDS) {
err = -EINVAL;
goto out_free;
}
--
2.43.0
next reply other threads:[~2026-02-04 8:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 8:18 Sun Jian [this message]
2026-02-04 8:36 ` [PATCH] wifi: nl80211: drop impossible negative band check Johannes Berg
2026-02-04 9:13 ` sun jian
2026-02-04 11:11 ` Johannes Berg
2026-02-04 11:21 ` sun jian
2026-02-04 11:29 ` Johannes Berg
2026-02-04 11:33 ` sun jian
2026-02-04 16:20 ` Jeff Johnson
2026-02-06 2:16 ` sun jian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260204081821.730673-1-sun.jian.kdev@gmail.com \
--to=sun.jian.kdev@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox