From: Richard Acayan <mailingradian@gmail.com>
To: Jeff Johnson <jjohnson@kernel.org>,
Michal Kazior <michal.kazior@tieto.com>,
Kalle Valo <kvalo@qca.qualcomm.com>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Cc: Richard Acayan <mailingradian@gmail.com>
Subject: [RFC PATCH 2/2] wifi: ath10k: only wait for response to SET_KEY
Date: Mon, 9 Feb 2026 21:12:49 -0500 [thread overview]
Message-ID: <20260210021249.12132-3-mailingradian@gmail.com> (raw)
In-Reply-To: <20260210021249.12132-1-mailingradian@gmail.com>
When sending DELETE_KEY, the driver times out waiting for a response
that doesn't come. Only wait for a response when sending SET_KEY.
Sample dmesg:
[ 117.285854] wlan0: deauthenticating from XX:XX:XX:XX:XX:XX by local choice (Reason: 3=DEAUTH_LEAVING)
[ 120.302934] ath10k_snoc 18800000.wifi: failed to install key for vdev 0 peer XX:XX:XX:XX:XX:XX: -110
[ 120.302996] wlan0: failed to remove key (0, XX:XX:XX:XX:XX:XX) from hardware (-110)
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
drivers/net/wireless/ath/ath10k/mac.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index da6f7957a0ae..73aa93043f8a 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -324,9 +324,11 @@ static int ath10k_install_key(struct ath10k_vif *arvif,
if (ret)
return ret;
- time_left = wait_for_completion_timeout(&ar->install_key_done, 3 * HZ);
- if (time_left == 0)
- return -ETIMEDOUT;
+ if (cmd != DISABLE_KEY) {
+ time_left = wait_for_completion_timeout(&ar->install_key_done, 3 * HZ);
+ if (time_left == 0)
+ return -ETIMEDOUT;
+ }
return 0;
}
--
2.53.0
next prev parent reply other threads:[~2026-02-10 2:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 2:12 [RFC PATCH 0/2] ath10k wifi fixes Richard Acayan
2026-02-10 2:12 ` [RFC PATCH 1/2] wifi: ath10k: make in-order rx amsdu buffers persistent Richard Acayan
2026-02-12 17:38 ` Jeff Johnson
2026-02-10 2:12 ` Richard Acayan [this message]
2026-02-12 2:11 ` [RFC PATCH 2/2] wifi: ath10k: only wait for response to SET_KEY James Prestwood
2026-02-12 17:56 ` Jeff Johnson
2026-02-13 14:00 ` James Prestwood
2026-02-18 4:14 ` Felix Kaechele
2026-02-26 2:59 ` Baochen Qiang
2026-02-27 17:28 ` James Prestwood
2026-02-12 18:36 ` Felix Kaechele
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260210021249.12132-3-mailingradian@gmail.com \
--to=mailingradian@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox