From: Francesco Dolcini <francesco@dolcini.it>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: Brian Norris <briannorris@chromium.org>,
Francesco Dolcini <francesco@dolcini.it>,
Johannes Berg <johannes.berg@intel.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH] wifi: mwifiex: Fix dev_alloc_name() return value check
Date: Tue, 10 Feb 2026 11:54:53 +0100 [thread overview]
Message-ID: <20260210105453.GC214446@francesco-nb> (raw)
In-Reply-To: <20260210100337.1131279-1-wenst@chromium.org>
On Tue, Feb 10, 2026 at 06:03:34PM +0800, Chen-Yu Tsai wrote:
> dev_alloc_name() returns the allocated ID on success, which could be
> over 0.
>
> Fix the return value check to check for negative error codes.
>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/all/aYmsQfujoAe5qO02@stanley.mountain/
> Fixes: 7bab5bdb81e3 ("wifi: mwifiex: Allocate dev name earlier for interface workqueue name")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
prev parent reply other threads:[~2026-02-10 10:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 10:03 [PATCH] wifi: mwifiex: Fix dev_alloc_name() return value check Chen-Yu Tsai
2026-02-10 10:54 ` Francesco Dolcini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260210105453.GC214446@francesco-nb \
--to=francesco@dolcini.it \
--cc=briannorris@chromium.org \
--cc=dan.carpenter@linaro.org \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox