From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx3.wp.pl (mx3.wp.pl [212.77.101.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AEB92E3387 for ; Mon, 16 Feb 2026 18:44:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.77.101.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771267492; cv=none; b=m5T/cjjP4qgsQ1ylkwwN2ZXtnIGVQ3ACAw4yViN8igoPiqjGemp67Lmk/DVZV3497CrXGGHbAb9NfU9TKhRgaXz1ZItWdZcShv44hoR2p8PabNUjGxjPqbjSjklLudnIoxD2baBcv97kRwCm/wCemAMQ86CaAV+9i1c8HFggk3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771267492; c=relaxed/simple; bh=SqcFM0QZIXR5mNz9Q/hTHf9CMfMyffBH5iM9TEo2OZk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=keQTiUAJe4ssUReiKjkzLo6siJwafajPPLmPeZI2gTrIXBwFFovu7wbUOZxkAHpDFwfbjyT7H0w4Pm2edGEV5MkLZ7EnZulDsUk0tKBGi6sYaA14ZClpwZ5E7n9q9DSfBiwlzVaIjnJSrLSIgr4V+S4wC2k4LYv1xRL4JcdAW9A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wp.pl; spf=pass smtp.mailfrom=wp.pl; dkim=pass (2048-bit key) header.d=wp.pl header.i=@wp.pl header.b=TiYK+085; arc=none smtp.client-ip=212.77.101.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wp.pl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wp.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wp.pl header.i=@wp.pl header.b="TiYK+085" Received: (wp-smtpd smtp.wp.pl 45040 invoked from network); 16 Feb 2026 19:38:08 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=20241105; t=1771267088; bh=s/zeP5079+6V8e1bUW5YeqfAw436nt3wg6E8nJ8iSCM=; h=From:To:Cc:Subject; b=TiYK+085dE3CLobuMc/0P0hMH0T18xB248N0qqsUJD2f90OQyp8r8ZrdSVdtnrpP1 iQLX6c1ddXaSMyrPPRWWaIlJlhbmyMyz3j1KFsGiVAdjQ1HRPpdmd4dA6gAHPkjwJn PkAw5zJXS6ISgyIsEetmY4woRh/YpAjhBVctX9sjym7xMVJAR1PQzqp63e9GWFd05L 6AqWOez7E0QjpK1h0aG0O0SyEQDfKeXWpgRDdFniB/wCpyM+oaV2+RRONHw/gjlA7a gpmmuQJoJfow7YQfjIt5xKxaTTj3dg6iTBUNTLu1tY4J/dt9EZ1QL2Xina/9Pupzdl aP5aQ3EmOD8qg== Received: from 89-64-3-178.dynamic.play.pl (HELO localhost) (stf_xl@wp.pl@[89.64.3.178]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with TLS_AES_256_GCM_SHA384 encrypted SMTP for ; 16 Feb 2026 19:38:08 +0100 Date: Mon, 16 Feb 2026 19:38:08 +0100 From: Stanislaw Gruszka To: Kees Cook Cc: "Gustavo A. R. Silva" , Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2][next] iwlegacy: Avoid multiple -Wflex-array-member-not-at-end warnings Message-ID: <20260216183808.GA10063@wp.pl> References: <202602091212.743C6B9B7C@keescook> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202602091212.743C6B9B7C@keescook> X-WP-MailID: 6b2f477e8aaab6c42e78d28ed9add274 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000001 [4XKh] On Mon, Feb 09, 2026 at 12:46:23PM -0800, Kees Cook wrote: > @@ -2664,7 +2668,8 @@ struct il3945_beacon_notif { > } __packed; > > struct il4965_beacon_notif { > - struct il4965_tx_resp beacon_notify_hdr; > + struct il4965_tx_resp_hdr beacon_notify_hdr; > + __le32 status; > __le32 low_tsf; > __le32 high_tsf; > __le32 ibss_mgr_status; > > > What do folks think? Both options, with __struct_group(), and this one, are ok for me. Regards Stanislaw