From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx3.wp.pl (mx3.wp.pl [212.77.101.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DC462C375A for ; Sat, 21 Feb 2026 10:07:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.77.101.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771668476; cv=none; b=UCccm3M9G0oPWwvMBNt9gMJAVI/6dZksq+nB3rW7VFYe8T6mvXMjkW1I928ApXjFegYaDm+JYT52gbA+Ab8TiK61f12i/3fsj4nKRY6UpK9IUhRPaiNmH7ktwAyC7yutHXSugGd7ojv58vIhP7DmPtObpELgo7d9qaYoNLY2cqU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771668476; c=relaxed/simple; bh=iVw1HVSiTMw4bZ+cqRx8IQfw76zVemzdRWQ1EP9QMj0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CnvTPH6uR10AIziPxtoABb5TGOtzCSqCTuQMvYiHj8weL2kvRvvyPYE7G12UOjl4eqLm4sqedv4egw7o/2dPYWQMThom6xf/MQKjDVoA8DfaZRzXQQfUJBbjyLWourqbU/OoPRPYH+dhAuPLcY6CTRvKHUgWyXZfCteFWTC0RYo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wp.pl; spf=pass smtp.mailfrom=wp.pl; dkim=pass (2048-bit key) header.d=wp.pl header.i=@wp.pl header.b=LGWMXvjR; arc=none smtp.client-ip=212.77.101.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wp.pl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wp.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wp.pl header.i=@wp.pl header.b="LGWMXvjR" Received: (wp-smtpd smtp.wp.pl 15318 invoked from network); 21 Feb 2026 11:07:50 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=20241105; t=1771668471; bh=gvcQcgZ9/Edyb3cXnLgqPNfRojiY4ttZwqd54VF0Ay0=; h=From:To:Cc:Subject; b=LGWMXvjRS5xOTIKLYoUqhnEh2HCmYd1MKAcbTatiPFdR35VvmmNDqIKCL39RQLDKn a8KZ+jxkU99gKMvAKNtoLk4ErpzqyB3M7i/vfVE0l4IDXVisNmSC25phmD9tj1hkMD ubMsyqo4EyDcsmHUCprnqpipHTqTMC3RAZ7vYFUMKv018ycLOzEBGGwiBDSGzyERmZ HUA98PVviCyqieBibQ/0HTNVfBaSdNT3LUTs8w0ry8gSdEvruWOOAS4CERbOB+CpEE NN2FlRgMVgIjux6dJCVKP6NOQYHOzLSOOOZ1K1vA8j9rpSOroxXYLs2w+FGgKiMl59 GS4Twyrr2yxpg== Received: from 89-64-9-107.dynamic.play.pl (HELO localhost) (stf_xl@wp.pl@[89.64.9.107]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with TLS_AES_256_GCM_SHA384 encrypted SMTP for ; 21 Feb 2026 11:07:50 +0100 Date: Sat, 21 Feb 2026 11:07:50 +0100 From: Stanislaw Gruszka To: Rosen Penev Cc: linux-wireless@vger.kernel.org, open list Subject: Re: [PATCH] wifi: rt2x00: use non of nvmem_cell_get Message-ID: <20260221100750.GA62045@wp.pl> References: <20260220020908.40115-1-rosenp@gmail.com> <20260220103739.GA20961@wp.pl> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-WP-MailID: 72b8da6172d50e35f4a4fc2f94e658dc X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000000 [AcNB] On Fri, Feb 20, 2026 at 01:32:55PM -0800, Rosen Penev wrote: > On Fri, Feb 20, 2026 at 2:37 AM Stanislaw Gruszka wrote: > > > > On Thu, Feb 19, 2026 at 06:09:08PM -0800, Rosen Penev wrote: > > > The library doesn't necessarily depend on OF. This codepath is used by > > > both soc (OF only) and pci (no such requirement). After this, the only > > > of specific function is of_get_mac_address, which is needed for nvmem. > > > > > > Signed-off-by: Rosen Penev > > Acked-by: Stanislaw Gruszka > > > > > --- > > > drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c > > > index 65d0f805459c..93e4ce604171 100644 > > > --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c > > > +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c > > > @@ -10965,13 +10965,13 @@ EXPORT_SYMBOL_GPL(rt2800_read_eeprom_efuse); > > > > > > int rt2800_read_eeprom_nvmem(struct rt2x00_dev *rt2x00dev) > > > { > > > - struct device_node *np = rt2x00dev->dev->of_node; > > > + struct device *dev = rt2x00dev->dev; > > > unsigned int len = rt2x00dev->ops->eeprom_size; > > > struct nvmem_cell *cell; > > > const void *data; > > > size_t retlen; > > > > > > - cell = of_nvmem_cell_get(np, "eeprom"); > > > + cell = nvmem_cell_get(dev, "eeprom"); > most usages of nvmem_cell_get in wireless use devm instead. Seems > pointless to extend the lifetime of cell until removal but what do I > know... No need for devm_ here, we release resources locally. You can change other drivers, to avoid keeping nvem cell reference needlessly, if you think that's beneficial. Regards Stanislaw