From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-wireless@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ping-Ke Shih <pkshih@realtek.com>, stable <stable@kernel.org>
Subject: [PATCH net] wifi: rtw88: properly drop usb interface reference on error
Date: Mon, 23 Feb 2026 12:37:34 +0100 [thread overview]
Message-ID: <2026022333-periscope-unusual-f0a0@gregkh> (raw)
If an error happens in the usb probe path, in rtw_usb_intf_init(), the
usb interface reference needs to be properly dropped, otherwise is is
incorrectly increased when returning to the USB core.
Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: stable <stable@kernel.org>
Assisted-by: gkh_clanker_2000
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/net/wireless/realtek/rtw88/usb.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wireless/realtek/rtw88/usb.c
index 433b06c8d8a6..36ac20039ce2 100644
--- a/drivers/net/wireless/realtek/rtw88/usb.c
+++ b/drivers/net/wireless/realtek/rtw88/usb.c
@@ -1046,13 +1046,17 @@ static int rtw_usb_intf_init(struct rtw_dev *rtwdev,
rtwusb->udev = udev;
ret = rtw_usb_parse(rtwdev, intf);
- if (ret)
+ if (ret) {
+ usb_put_dev(udev);
return ret;
+ }
rtwusb->usb_data = kcalloc(RTW_USB_MAX_RXTX_COUNT, sizeof(u32),
GFP_KERNEL);
- if (!rtwusb->usb_data)
+ if (!rtwusb->usb_data) {
+ usb_put_dev(udev);
return -ENOMEM;
+ }
usb_set_intfdata(intf, rtwdev->hw);
--
2.53.0
next reply other threads:[~2026-02-23 11:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 11:37 Greg Kroah-Hartman [this message]
2026-02-24 0:46 ` [PATCH net] wifi: rtw88: properly drop usb interface reference on error Ping-Ke Shih
2026-02-24 1:09 ` Greg Kroah-Hartman
2026-02-24 1:49 ` Ping-Ke Shih
2026-02-24 6:18 ` Greg Kroah-Hartman
2026-03-03 3:07 ` Ping-Ke Shih
2026-03-09 0:43 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026022333-periscope-unusual-f0a0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox