From: Greg KH <gregkh@linuxfoundation.org>
To: Alejandro Colomar <alx@kernel.org>
Cc: "Jeff Johnson" <jeff.johnson@oss.qualcomm.com>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
linux-wireless@vger.kernel.org,
"Rajkumar Manoharan" <rmanohar@qti.qualcomm.com>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH v1] wifi: ath9k: Fix typo
Date: Tue, 24 Feb 2026 13:37:09 -0800 [thread overview]
Message-ID: <2026022405-mundane-caucus-6aa9@gregkh> (raw)
In-Reply-To: <aZ4Wq6h-nMt-G3pC@devuan>
On Tue, Feb 24, 2026 at 10:27:56PM +0100, Alejandro Colomar wrote:
> Hi Jeff,
>
> On 2026-02-24T10:45:02-0800, Jeff Johnson wrote:
> > On 2/23/2026 7:17 AM, Toke Høiland-Jørgensen wrote:
> > > Alejandro Colomar <alx@kernel.org> writes:
> > >
> > >> This only worked by chance, because all callers of this macro used the
> > >> same identifiers that were expected by the macro.
> > >>
> > >> $ grep -rn ath_for_each_chanctx
> > >> drivers/net/wireless/ath/ath9k/main.c:1576: ath_for_each_chanctx(sc, ctx)
> > >> drivers/net/wireless/ath/ath9k/main.c:2554: ath_for_each_chanctx(sc, ctx) {
> > >> drivers/net/wireless/ath/ath9k/channel.c:165: ath_for_each_chanctx(sc, ctx) {
> > >> drivers/net/wireless/ath/ath9k/channel.c:291: ath_for_each_chanctx(sc, ctx) {
> > >> drivers/net/wireless/ath/ath9k/channel.c:861: ath_for_each_chanctx(sc, ctx) {
> > >> drivers/net/wireless/ath/ath9k/debug.c:717: ath_for_each_chanctx(sc, ctx) {
> > >> drivers/net/wireless/ath/ath9k/ath9k.h:446:#define ath_for_each_chanctx(_sc, _ctx) \
> > >>
> > >> Fixes: c4dc0d040e35 (2014-06-19; "ath9k: Fetch appropriate operating channel context")
> >
> > I'm dropping the Fixes tag since the existing code actually works and hence
> > there is no need to backport to LTS kernels.
>
> Sounds reasonable. Alternatively, a line next to it saying
>
> [Do not backport]
>
> would work, I guess.
>
> Greg, I've seen this situation already a few times. A Fixes tag getting
> removed to avoid triggering a stable backport. But I think keeping the
> Fixes tag could be useful. Should we have a standard way to document
> that a patch fixes an old commit without meaning that it should be
> backported? Maybe something like this?:
>
> [Do not backport to stable]
> Fixes: ...
As per the in-kernel documentation file
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
There furthermore is a variant of the stable tag you can use to make the stable
team's backporting tools (e.g AUTOSEL or scripts that look for commits
containing a 'Fixes:' tag) ignore a change::
Cc: <stable+noautosel@kernel.org> # reason goes here, and must be present
So I think it is documented already :)
thanks,
greg k-h
next prev parent reply other threads:[~2026-02-24 21:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-21 22:25 [PATCH v1] wifi: ath9k: Fix typo Alejandro Colomar
2026-02-23 15:17 ` Toke Høiland-Jørgensen
2026-02-24 18:45 ` Jeff Johnson
2026-02-24 21:27 ` Alejandro Colomar
2026-02-24 21:34 ` Jeff Johnson
2026-02-24 22:55 ` Alejandro Colomar
2026-02-24 23:07 ` Jeff Johnson
2026-02-24 23:09 ` Jeff Johnson
2026-02-24 23:23 ` Alejandro Colomar
2026-02-25 0:04 ` Jeff Johnson
2026-02-25 0:10 ` Alejandro Colomar
2026-02-24 21:37 ` Greg KH [this message]
2026-02-24 22:52 ` Alejandro Colomar
2026-02-26 21:29 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026022405-mundane-caucus-6aa9@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alx@kernel.org \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rmanohar@qti.qualcomm.com \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox